Re: [Freedreno] [PATCH 6/9] PM / OPP: dt-bindings: Add opp-interconnect-bw

2018-09-27 Thread Georgi Djakov
Hi Jordan, Thanks for the patch! On 08/27/2018 06:11 PM, Jordan Crouse wrote: > Add the "opp-interconnect-bw" property to specify the > average and peak bandwidth for an interconnect path for > a specific operating power point. A separate bandwidth > pair can be specified for each of the

Re: [Freedreno] [PATCH v3 1/3] drm/msm/a6xx: Add support for an interconnect path

2019-01-21 Thread Georgi Djakov
Hi Rob, On 1/18/19 21:16, Rob Clark wrote: > On Fri, Jan 18, 2019 at 1:06 PM Doug Anderson wrote: >> >> Hi, >> >> On Thu, Dec 20, 2018 at 9:30 AM Jordan Crouse wrote: >>> >>> Try to get the interconnect path for the GPU and vote for the maximum >>> bandwidth to support all frequencies. This is

Re: [Freedreno] [PATCH 1/1] drm/msm/a6xx: Add support for an interconnect path

2018-12-05 Thread Georgi Djakov
Hi Jordan, Thanks for the patch! On 11/29/18 19:26, Jordan Crouse wrote: > Try to get the interconnect path for the GPU and vote for the maximum > bandwidth to support all frequencies. This is needed for performance. > Later we will want to scale the bandwidth based on the frequency to > also

Re: [Freedreno] [PATCH v4 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

2019-01-09 Thread Georgi Djakov
(Matthias Kaehlcke) > > Changes in v4: > - Add comments, spacings, tabs, proper port name > and icc macro (Georgi Djakov) The changes should not be part of the commit text, but should move below the "---" line. > > Signed-off-by: Sravanthi Kollukudu

Re: [Freedreno] [PATCH v3 3/3] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2018-12-19 Thread Georgi Djakov
Hi Sravanthi, Thanks for the patch! On 11/22/18 11:06, Sravanthi Kollukuduru wrote: > Add interconnect properties such as interconnect provider specifier > , the edge source and destination ports which are required by the > interconnect API to configure interconnect path for MDSS. > > Changes

Re: [Freedreno] [PATCH v3 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

2018-12-19 Thread Georgi Djakov
Hi Sravanthi, Thanks for the patch! On 11/22/18 11:06, Sravanthi Kollukuduru wrote: > The interconnect framework is designed to provide a > standard kernel interface to control the settings of > the interconnects on a SoC. > > The interconnect API uses a consumer/provider-based model, > where

Re: [Freedreno] [PATCH v3 2/3] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU

2019-02-21 Thread Georgi Djakov
power for the GPU. Applicable targets: > - qcom,adreno-630.2 > @@ -68,6 +70,8 @@ Example a6xx (with GMU): > > operating-points-v2 = <_opp_table>; > > + interconnects = <_hlos MASTER_GFX3D _hlos SLAVE_EBI1>;

Re: [Freedreno] [PATCH] drm/msm/a6xx: Add support for an interconnect path

2019-02-12 Thread Georgi Djakov
Hi Greg, On 2/12/19 12:16, Greg KH wrote: > On Tue, Feb 12, 2019 at 11:52:38AM +0200, Georgi Djakov wrote: >> From: Jordan Crouse >> >> Try to get the interconnect path for the GPU and vote for the maximum >> bandwidth to support all frequencies. This is needed f

[Freedreno] [PATCH] drm/msm/a6xx: Add support for an interconnect path

2019-02-12 Thread Georgi Djakov
infrastructure that does not yet exist. v6: use icc_set_bw() instead of icc_set() v5: Remove hardcoded interconnect name and just use the default v4: Don't use a port string at all to skip the need for names in the DT v3: Use macros and change port string per Georgi Djakov Signed-off-by: Jordan Crouse

Re: [Freedreno] [PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS

2019-05-29 Thread Georgi Djakov
hange, removal >>of extra paranthesis and variables (Matthias Kaehlcke) >> >> Changes in v4: >> - Add comments, spacings, tabs, proper port name >>and icc macro (Georgi Djakov) >> >> Changes in v5: >> - Commit text and pa

Re: [Freedreno] [PATCH 5/5] drm/msm/mdp5: Use the interconnect API

2019-05-29 Thread Georgi Djakov
On 5/8/19 23:42, Rob Clark wrote: > From: Georgi Djakov > Let's put some text in the commit message: The interconnect API provides an interface for consumer drivers to express their bandwidth needs in the SoC. This data is aggregated and the on-chip interconnect hardware is conf

Re: [PATCH] qcom: Add BCM vote macro to TCS header

2019-07-24 Thread Georgi Djakov
Hi Jordan, On 7/17/19 18:53, Jordan Crouse wrote: > The A6XX family of Adreno GPUs use a microcontroller to control the > GPU clock independently. The microcontroller also has the capability > to vote for the bus but doesn't currently do so except for one initial > vote that is hard coded [1]. >

Re: [Freedreno] [PATCH 5/5] ARM: dts: qcom: msm8974: add interconnect nodes

2019-10-24 Thread Georgi Djakov
On 24.10.19 г. 10:07 ч., Brian Masney wrote: > On Wed, Oct 23, 2019 at 04:39:21PM +0300, Georgi Djakov wrote: >> On 23.10.19 г. 15:47 ч., Brian Masney wrote: >>> On Wed, Oct 23, 2019 at 02:50:19PM +0300, Georgi Djakov wrote: >>>> On 13.10.19 г. 11:08 ч., Brian Masney

Re: [Freedreno] [v2 1/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-04-15 Thread Georgi Djakov
Hi Krishna, Thanks for the patch! On 4/2/20 09:52, Krishna Manikandan wrote: > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to mdp > device node from mdss to facilitate the scaling. No

[Freedreno] [PATCH] drm/msm: Remove depends on interconnect

2020-09-16 Thread Georgi Djakov
The dependency on interconnect in the Kconfig was introduced to avoid the case of interconnect=m and driver=y, but the interconnect framework has been converted from tristate to bool now. Remove the dependency as the framework can't be a module anymore. Signed-off-by: Georgi Djakov --- drivers

Re: [Freedreno] [RFC PATCH] interconnect: qcom: add functions to query addr/cmds for a path

2020-07-13 Thread Georgi Djakov
On 7/1/20 07:25, Jonathan Marek wrote: > The a6xx GMU can vote for ddr and cnoc bandwidth, but it needs to be able > to query the interconnect driver for bcm addresses and commands. It's not very clear to me how the GMU firmware would be dealing with this? Does anyone have an idea whether the GMU

Re: [Freedreno] [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration

2020-12-23 Thread Georgi Djakov
Hi Isaac, On 22.12.20 2:44, Isaac J. Manjarres wrote: The io-pgtable code constructs an array of init functions for each page table format at compile time. This is not ideal, as this increases the footprint of the io-pgtable code, as well as prevents io-pgtable formats from being built as

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-07-28 Thread Georgi Djakov
On Mon, Jan 11, 2021 at 07:45:02PM +0530, Sai Prakash Ranjan wrote: > commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") > removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went > the memory type setting required for the non-coherent masters to use > system cache.

Re: [Freedreno] [PATCH v3 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2022-12-05 Thread Georgi Djakov
Hi Robert, On 5.12.22 18:37, Robert Foss wrote: Use two interconnect cells in order to optionally support a path tag. Signed-off-by: Robert Foss Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++-- 1 file changed, 14 insertions(+), 14

Re: [Freedreno] [PATCH v2 4/5] drm/msm/mdss: Handle the reg bus ICC path

2023-04-24 Thread Georgi Djakov
Hi Konrad, On 18.04.23 15:10, Konrad Dybcio wrote: Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there's another path that needs to be handled to ensure MDSS functions properly, namely the "reg bus", a.k.a the CPU-MDSS interconnect. Gating that path may have a variety of