Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-29 Thread Linus Walleij
_helper.c: msecs_to_jiffies(50) Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Linus Walleij
ts, and I also notice the update is slow in the display, as if the DSI panel was running in low power (LP) mode. Was booting this to do some other work, but happy to see the progress! Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.

Re: [Freedreno] [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-06 Thread Linus Walleij
iewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH RFC 3/6] ARM: qcom_defconfig: add display-related options

2019-05-06 Thread Linus Walleij
alwaĆ½s get up, as serial console might not always be available. For example for people who can't solder special cables but still want to boot a custom ROM on their Nexus. So I'd say keep it like this. Yours, Linus Walleij ___ Freedreno mailing list Freedre

Re: [Freedreno] [PATCH RFC 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-06 Thread Linus Walleij
vblank will be fired from something like a monitor at 50 or 60 HZ ~20 ms so 50ms seemed like a good timeout at the time. On a DSI display this is dubious, absolutely in LP mode, and even in HS mode. Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH RFC 5/6] ARM: dts: qcom: msm8974-hammerhead: add support for backlight

2019-05-06 Thread Linus Walleij
On Sun, May 5, 2019 at 3:04 PM Brian Masney wrote: > Add necessary device tree nodes for the main LCD backlight. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij > This requires this series that I submitted to the LED / backlight > subsystem: > https://lo

Re: [Freedreno] [PATCH RFC 6/6] ARM: dts: qcom: msm8974-hammerhead: add support for display

2019-05-06 Thread Linus Walleij
On Sun, May 5, 2019 at 3:04 PM Brian Masney wrote: > Add initial support for the display found on the LG Nexus 5 (hammerhead) > phone. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno

Re: [Freedreno] [PATCH 4/7] gpio: of: Support some legacy Qualcomm HDMI bindings

2019-06-30 Thread Linus Walleij
the opinion that if a tree falls in the forest and noone is there to hear it, who cares what sound it makes. So we can just apply the other patches and not this one, which should work just fine. It will support the variants of the bindings ending with "-gpios" or "-g

[Freedreno] [PATCH 4/7] gpio: of: Support some legacy Qualcomm HDMI bindings

2019-06-29 Thread Linus Walleij
st resort. Provide an explicit whitelist for those GPIOs. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- Rob/Sean: if the approach is overall OK I will merge this one patch already for v5.3 so the rest can be queued f

[Freedreno] [PATCH 7/7] RFT: drm/msm/hdmi: Do not initialize HPD line value

2019-06-29 Thread Linus Walleij
be seen from the code reading the HPD GPIO. Stop try driving a value to the HPD input GPIO. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2 +- 1 file changed, 1 insertion

[Freedreno] [PATCH 1/7] drm/msm/mdp4: Drop unused GPIO include

2019-06-29 Thread Linus Walleij
This file is not using any symbols from so just drop this include. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c | 2 -- 1 file changed, 2 deletions

[Freedreno] [PATCH 5/7] drm/msm/hdmi: Convert to use GPIO descriptors

2019-06-29 Thread Linus Walleij
freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/hdmi/hdmi.c | 66 +++ drivers/gpu/drm/msm/hdmi/hdmi.h | 4 +- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 42 +-- 3 files changed, 45 insertions(+), 67 deletions(-)

[Freedreno] [PATCH 6/7] RFT: drm/msm/hdmi: Bring up HDMI connector OFF

2019-06-29 Thread Linus Walleij
-by: Linus Walleij --- drivers/gpu/drm/msm/hdmi/hdmi.c | 19 - drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 25 ++- 2 files changed, 20 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index

[Freedreno] [PATCH 3/7] drm/msm/dpu: Drop unused GPIO code

2019-06-29 Thread Linus Walleij
@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h | 9 - drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c| 4 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm

[Freedreno] [PATCH 2/7] drm/msm/dsi: Drop unused GPIO includes

2019-06-29 Thread Linus Walleij
This DSI driver uses the new descriptor API so these old GPIO API includes are surplus. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 -- 1 file changed, 2 deletions

Re: [Freedreno] [PATCH 05/11] drm/bridge: analogix-anx78xx: correct value of TX_P0

2019-08-15 Thread Linus Walleij
X_P0 is 0x78, not 0x70, so correct the value to allow device > probing to succeed. > > [1] > https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/drivers/video/slimport/slimport_tx_reg.h > > Signed-off-by: Brian Masney Reviewed-by: Linus

Re: [Freedreno] [PATCH RFC 10/11] ARM: dts: qcom: msm8974: add HDMI nodes

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add HDMI tx and phy nodes to support an external display that can be > connected over the SlimPort. This is based on work from Jonathan Marek. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH 03/11] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Silence two warning messages that occur due to -EPROBE_DEFER errors to > help cleanup the system boot log. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH 08/11] drm/msm/hdmi: silence -EPROBE_DEFER warning

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Silence a warning message due to an -EPROBE_DEFER error to help cleanup > the system boot log. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij _

Re: [Freedreno] [PATCH 02/11] drm/bridge: analogix-anx78xx: add new variants

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add support for the 7808 variant. While we're here, the of match table > was missing support for the 7812 and 7818 variants, so add them as well. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH 01/11] dt-bindings: drm/bridge: analogix-anx78xx: add new variants

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add support for the analogix,anx7808, analogix,anx7812, and > analogix,anx7818 variants. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freed

Re: [Freedreno] [PATCH 04/11] drm/bridge: analogix-anx78xx: convert to i2c_new_dummy_device

2019-08-15 Thread Linus Walleij
t; > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator

2019-08-15 Thread Linus Walleij
pdata); Clever idea. Good for initial support, probably later on it would need to be reworked using runtime PM so it's not constantly powered up. See for example how I try to push down power dissipation of sensors in 3d838118c6aa. Reviewed-by: Linus Walleij Yours, Linus Walleij _

Re: [Freedreno] [PATCH 07/11] ARM: qcom_defconfig: add CONFIG_DRM_ANALOGIX_ANX78XX

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add CONFIG_DRM_ANALOGIX_ANX78XX as a module so that the external display > can be used on the Nexus 5 phones. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH RFC 11/11] ARM: dts: qcom: msm8974-hammerhead: add support for external display

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add HDMI nodes and other supporting infrastructure in order to support > the external display. This is based on work from Jonathan Marek. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node

2019-08-15 Thread Linus Walleij
I suppose it is named "mvs" on both PMICs and this is just a rail name so as not to confuse the schematic? > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedeskt

Re: [Freedreno] [PATCH 1/7] drm/msm/mdp4: Drop unused GPIO include

2019-07-28 Thread Linus Walleij
On Sat, Jun 29, 2019 at 3:01 PM Linus Walleij wrote: > This file is not using any symbols from so just > drop this include. > > Cc: Rob Clark > Cc: Sean Paul > Cc: linux-arm-...@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Linus Wall

Re: [Freedreno] [PATCH 1/7] drm/msm/mdp4: Drop unused GPIO include

2019-08-05 Thread Linus Walleij
On Sun, Jul 28, 2019 at 12:02 PM Linus Walleij wrote: > On Sat, Jun 29, 2019 at 3:01 PM Linus Walleij > wrote: > > > This file is not using any symbols from so just > > drop this include. > > > > Cc: Rob Clark > > Cc: Sean Paul > > Cc: li

Re: [Freedreno] [PATCH 5/6 v2] drm/msm/hdmi: Bring up HDMI connector OFF

2019-09-02 Thread Linus Walleij
t; are in boxes right now) so I'm going to wait on the last two I think. That's fine. It is just occasional drive-by coding anyway. Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM

2019-08-23 Thread Linus Walleij
On Tue, Aug 13, 2019 at 4:46 PM Jordan Crouse wrote: > Now that CONFIG_DRM_MSM is no longer default 'y' add it as a module to all > ARCH_QCOM enabled defconfigs to restore the previous expected build > behavior. > > Signed-off-by: Jordan Crouse Reviewed-by: Linus Walleij

[Freedreno] [PATCH 2/6 v2] drm/msm/dsi: Drop unused GPIO includes

2019-08-23 Thread Linus Walleij
This DSI driver uses the new descriptor API so these old GPIO API includes are surplus. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-

[Freedreno] [PATCH 6/6 v2] drm/msm/hdmi: Do not initialize HPD line value

2019-08-23 Thread Linus Walleij
be seen from the code reading the HPD GPIO. Stop try driving a value to the HPD input GPIO. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collec

[Freedreno] [PATCH 4/6 v2] drm/msm/hdmi: Convert to use GPIO descriptors

2019-08-23 Thread Linus Walleij
freedreno@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collected review tag --- drivers/gpu/drm/msm/hdmi/hdmi.c | 66 +++ drivers/gpu/drm/msm/hdmi/hdmi.h | 4 +- drivers/gpu

[Freedreno] [PATCH 5/6 v2] drm/msm/hdmi: Bring up HDMI connector OFF

2019-08-23 Thread Linus Walleij
-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collected review tag --- drivers/gpu/drm/msm/hdmi/hdmi.c | 19 - drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 25 ++- 2 files changed, 20 insertions(+), 24 deleti

[Freedreno] [PATCH 3/6 v2] drm/msm/dpu: Drop unused GPIO code

2019-08-23 Thread Linus Walleij
@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collected review tag --- drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h | 9 - drivers/gpu/drm/msm/disp/dpu1/dpu_mds

[Freedreno] [PATCH 1/6 v2] drm/msm/mdp4: Drop unused GPIO include

2019-08-23 Thread Linus Walleij
This file is not using any symbols from so just drop this include. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collected review