Re: [Freedreno] [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-03-01 Thread Linus Walleij
gt; dsi->mode_flags = > MIPI_DSI_CLOCK_NON_CONTINUOUS | > - MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_NO_EOT_PACKET; Same, just delete the flag. These are all just semantic bugs due to the amb

Re: [Freedreno] [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-06-28 Thread Linus Walleij
On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat wrote: > On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij wrote: > > > dsi->mode_flags = > > > MIPI_DSI_CLOCK_NON_CONTINUOUS | > > > -

Re: [Freedreno] [PATCH v2] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-06-29 Thread Linus Walleij
O_EOT_PACKET. > > Signed-off-by: Nicolas Boichat Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH v4 28/34] power: supply: ab8500: Migrate to aggregate driver

2021-12-02 Thread Linus Walleij
n Reichel > Cc: > Cc: Daniel Vetter > Cc: Linus Walleij > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Saravana Kannan > Signed-off-by: Stephen Boyd Pulled in that patches and tested. Works! Tested-by: Linus Walleij Yours, Linus Walleij

Re: [Freedreno] [PATCH v4 00/34] component: Make into an aggregate bus

2021-12-02 Thread Linus Walleij
On Thu, Dec 2, 2021 at 11:27 PM Stephen Boyd wrote: > drm/mcde: Migrate to aggregate driver This also works fine after the patch series. Tested-by: Linus Walleij Yours, Linus Walleij

Re: [Freedreno] [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-06 Thread Linus Walleij
iewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH RFC 3/6] ARM: qcom_defconfig: add display-related options

2019-05-06 Thread Linus Walleij
d to alwaĆ½s get up, as serial console might not always be available. For example for people who can't solder special cables but still want to boot a custom ROM on their Nexus. So I'd say keep it like this. Yours, Linus Walleij ___ Freedreno maili

Re: [Freedreno] [PATCH RFC 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-06 Thread Linus Walleij
vblank will be fired from something like a monitor at 50 or 60 HZ ~20 ms so 50ms seemed like a good timeout at the time. On a DSI display this is dubious, absolutely in LP mode, and even in HS mode. Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH RFC 5/6] ARM: dts: qcom: msm8974-hammerhead: add support for backlight

2019-05-06 Thread Linus Walleij
On Sun, May 5, 2019 at 3:04 PM Brian Masney wrote: > Add necessary device tree nodes for the main LCD backlight. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij > This requires this series that I submitted to the LED / backlight > subsystem: > https://lo

Re: [Freedreno] [PATCH RFC 6/6] ARM: dts: qcom: msm8974-hammerhead: add support for display

2019-05-06 Thread Linus Walleij
On Sun, May 5, 2019 at 3:04 PM Brian Masney wrote: > Add initial support for the display found on the LG Nexus 5 (hammerhead) > phone. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Linus Walleij
timouts, and I also notice the update is slow in the display, as if the DSI panel was running in low power (LP) mode. Was booting this to do some other work, but happy to see the progress! Yours, Linus Walleij ___ Freedreno mailing list Freedr

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Linus Walleij
/drm/drm_atomic_helper.c: msecs_to_jiffies(50) Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PATCH 3/7] drm/msm/dpu: Drop unused GPIO code

2019-06-29 Thread Linus Walleij
@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h | 9 - drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c| 4 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm

[Freedreno] [PATCH 2/7] drm/msm/dsi: Drop unused GPIO includes

2019-06-29 Thread Linus Walleij
This DSI driver uses the new descriptor API so these old GPIO API includes are surplus. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 -- 1 file changed, 2 deletions

[Freedreno] [PATCH 4/7] gpio: of: Support some legacy Qualcomm HDMI bindings

2019-06-29 Thread Linus Walleij
ast resort. Provide an explicit whitelist for those GPIOs. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- Rob/Sean: if the approach is overall OK I will merge this one patch already for v5.3 so the rest can be que

[Freedreno] [PATCH 7/7] RFT: drm/msm/hdmi: Do not initialize HPD line value

2019-06-29 Thread Linus Walleij
seen from the code reading the HPD GPIO. Stop try driving a value to the HPD input GPIO. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2 +- 1 file changed, 1 insertion

[Freedreno] [PATCH 1/7] drm/msm/mdp4: Drop unused GPIO include

2019-06-29 Thread Linus Walleij
This file is not using any symbols from so just drop this include. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c | 2 -- 1 file changed, 2 deletions

[Freedreno] [PATCH 5/7] drm/msm/hdmi: Convert to use GPIO descriptors

2019-06-29 Thread Linus Walleij
freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/hdmi/hdmi.c | 66 +++ drivers/gpu/drm/msm/hdmi/hdmi.h | 4 +- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 42 +-- 3 files changed, 45 insertions(+), 67 deletions(-) di

[Freedreno] [PATCH 6/7] RFT: drm/msm/hdmi: Bring up HDMI connector OFF

2019-06-29 Thread Linus Walleij
ff-by: Linus Walleij --- drivers/gpu/drm/msm/hdmi/hdmi.c | 19 - drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 25 ++- 2 files changed, 20 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c

Re: [Freedreno] [PATCH 4/7] gpio: of: Support some legacy Qualcomm HDMI bindings

2019-06-30 Thread Linus Walleij
usually of the opinion that if a tree falls in the forest and noone is there to hear it, who cares what sound it makes. So we can just apply the other patches and not this one, which should work just fine. It will support the variants of the bindings ending with "-gpios" o

Re: [Freedreno] [PATCH 1/7] drm/msm/mdp4: Drop unused GPIO include

2019-07-28 Thread Linus Walleij
On Sat, Jun 29, 2019 at 3:01 PM Linus Walleij wrote: > This file is not using any symbols from so just > drop this include. > > Cc: Rob Clark > Cc: Sean Paul > Cc: linux-arm-...@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Linus Walleij Ro

Re: [Freedreno] [PATCH 1/7] drm/msm/mdp4: Drop unused GPIO include

2019-08-05 Thread Linus Walleij
On Sun, Jul 28, 2019 at 12:02 PM Linus Walleij wrote: > On Sat, Jun 29, 2019 at 3:01 PM Linus Walleij > wrote: > > > This file is not using any symbols from so just > > drop this include. > > > > Cc: Rob Clark > > Cc: Sean Paul > > Cc: li

Re: [Freedreno] [PATCH 01/11] dt-bindings: drm/bridge: analogix-anx78xx: add new variants

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add support for the analogix,anx7808, analogix,anx7812, and > analogix,anx7818 variants. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freed

Re: [Freedreno] [PATCH 02/11] drm/bridge: analogix-anx78xx: add new variants

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add support for the 7808 variant. While we're here, the of match table > was missing support for the 7812 and 7818 variants, so add them as well. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij You

Re: [Freedreno] [PATCH 04/11] drm/bridge: analogix-anx78xx: convert to i2c_new_dummy_device

2019-08-15 Thread Linus Walleij
> Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator

2019-08-15 Thread Linus Walleij
pdata); Clever idea. Good for initial support, probably later on it would need to be reworked using runtime PM so it's not constantly powered up. See for example how I try to push down power dissipation of sensors in 3d838118c6aa. Reviewed-by: Linus Walleij Yours, Linus Walleij ___

Re: [Freedreno] [PATCH 07/11] ARM: qcom_defconfig: add CONFIG_DRM_ANALOGIX_ANX78XX

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add CONFIG_DRM_ANALOGIX_ANX78XX as a module so that the external display > can be used on the Nexus 5 phones. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH 05/11] drm/bridge: analogix-anx78xx: correct value of TX_P0

2019-08-15 Thread Linus Walleij
is 0x78, not 0x70, so correct the value to allow device > probing to succeed. > > [1] > https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/drivers/video/slimport/slimport_tx_reg.h > > Signed-off-by: Brian Masney Reviewed-by: Linus

Re: [Freedreno] [PATCH RFC 10/11] ARM: dts: qcom: msm8974: add HDMI nodes

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add HDMI tx and phy nodes to support an external display that can be > connected over the SlimPort. This is based on work from Jonathan Marek. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH RFC 11/11] ARM: dts: qcom: msm8974-hammerhead: add support for external display

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Add HDMI nodes and other supporting infrastructure in order to support > the external display. This is based on work from Jonathan Marek. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node

2019-08-15 Thread Linus Walleij
mvs2. I suppose it is named "mvs" on both PMICs and this is just a rail name so as not to confuse the schematic? > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.free

Re: [Freedreno] [PATCH 03/11] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Silence two warning messages that occur due to -EPROBE_DEFER errors to > help cleanup the system boot log. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, L

Re: [Freedreno] [PATCH 08/11] drm/msm/hdmi: silence -EPROBE_DEFER warning

2019-08-15 Thread Linus Walleij
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > Silence a warning message due to an -EPROBE_DEFER error to help cleanup > the system boot log. > > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij _

Re: [Freedreno] [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM

2019-08-22 Thread Linus Walleij
On Tue, Aug 13, 2019 at 4:46 PM Jordan Crouse wrote: > Now that CONFIG_DRM_MSM is no longer default 'y' add it as a module to all > ARCH_QCOM enabled defconfigs to restore the previous expected build > behavior. > > Signed-off-by: Jordan Crouse Reviewed-by: Linus Wall

[Freedreno] [PATCH 2/6 v2] drm/msm/dsi: Drop unused GPIO includes

2019-08-23 Thread Linus Walleij
This DSI driver uses the new descriptor API so these old GPIO API includes are surplus. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-

[Freedreno] [PATCH 6/6 v2] drm/msm/hdmi: Do not initialize HPD line value

2019-08-23 Thread Linus Walleij
seen from the code reading the HPD GPIO. Stop try driving a value to the HPD input GPIO. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collec

[Freedreno] [PATCH 4/6 v2] drm/msm/hdmi: Convert to use GPIO descriptors

2019-08-23 Thread Linus Walleij
freedreno@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collected review tag --- drivers/gpu/drm/msm/hdmi/hdmi.c | 66 +++ drivers/gpu/drm/msm/hdmi/hdmi.h | 4 +- drivers/gpu

[Freedreno] [PATCH 5/6 v2] drm/msm/hdmi: Bring up HDMI connector OFF

2019-08-23 Thread Linus Walleij
ed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collected review tag --- drivers/gpu/drm/msm/hdmi/hdmi.c | 19 - drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 25 ++- 2 files changed, 20 insertions(+), 24 d

[Freedreno] [PATCH 3/6 v2] drm/msm/dpu: Drop unused GPIO code

2019-08-23 Thread Linus Walleij
@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collected review tag --- drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h | 9 - drivers/gpu/drm/msm/disp/dpu1/dpu_mds

[Freedreno] [PATCH 1/6 v2] drm/msm/mdp4: Drop unused GPIO include

2019-08-23 Thread Linus Walleij
This file is not using any symbols from so just drop this include. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedreno@lists.freedesktop.org Reviewed-by: Brian Masney Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Rebased on v5.3-rc1 - Collected review

Re: [Freedreno] [PATCH 5/6 v2] drm/msm/hdmi: Bring up HDMI connector OFF

2019-09-02 Thread Linus Walleij
ds that > are in boxes right now) so I'm going to wait on the last two I think. That's fine. It is just occasional drive-by coding anyway. Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH] drm/msm/dpu: ignore NULL clocks

2019-11-14 Thread Linus Walleij
On Thu, Nov 14, 2019 at 7:54 PM Rob Clark wrote: > From: Rob Clark > > This isn't an error. Also the clk APIs handle the NULL case, so we can > just delete the check. > > Signed-off-by: Rob Clark > Tested-by: Matthias Kaehlcke Reviewed-by: Linus Wall

Re: [Freedreno] [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

2020-05-05 Thread Linus Walleij
ange the helper to only look at this variable if debugfs is present. > > Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP > buffers") > Signed-off-by: Arnd Bergmann This fixes a compilation error for me on the APQ

Re: [Freedreno] [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

2020-06-09 Thread Linus Walleij
On Tue, May 5, 2020 at 10:27 AM Linus Walleij wrote: > On Wed, Apr 8, 2020 at 9:15 PM Arnd Bergmann wrote: > > > I ran into a randconfig link error with debugfs disabled: > > > > arm-linux-gnueabi-ld: > > drivers/gpu/drm/msm/msm_gpu.o: in function `should_dump

Re: [Freedreno] [PATCH] drm/msm: fix link error without CONFIG_DEBUG_FS

2020-06-09 Thread Linus Walleij
On Tue, Jun 9, 2020 at 4:04 PM Rob Clark wrote: > On Tue, Jun 9, 2020 at 5:48 AM Linus Walleij wrote: > > On Tue, May 5, 2020 at 10:27 AM Linus Walleij > > wrote: > > > On Wed, Apr 8, 2020 at 9:15 PM Arnd Bergmann wrote: > > > > > > > I ran into

Re: [Freedreno] [PATCH 1/2] drm/msm: sync generated headers

2020-07-11 Thread Linus Walleij
On Tue, Jul 7, 2020 at 10:36 PM Rob Clark wrote: > From: Rob Clark > > We haven't sync'd for a while.. pull in updates to get definitions for > some fields in pkt7 payloads. > > Signed-off-by: Rob Clark Out of curiosity : where are the syncs coming from?