Re: [Freedreno] [DPU PATCH v2 03/12] drm/msm/dpu: add MDSS top level driver for dpu

On 2018-05-11 20:58, Sean Paul wrote: On Fri, May 11, 2018 at 08:19:29PM +0530, Rajesh Yadav wrote: SoCs containing dpu have a MDSS top level wrapper which includes sub-blocks as dpu, dsi, phy, dp etc. MDSS top level wrapper manages common resources like common clocks, power and irq for its

Re: [Freedreno] [DPU PATCH 10/11] drm/msm/dpu: correct dpu_io_util.h include path

On 2018-05-30 22:00, Jordan Crouse wrote: On Wed, May 30, 2018 at 08:19:47PM +0530, Rajesh Yadav wrote: dpu_io_util.h is moved from standard include path to driver folder, correct the include path in code. Signed-off-by: Rajesh Yadav If the previous patch doesn't compile without this fix

Re: [Freedreno] [DPU PATCH 02/19] drm/msm: dpu_crtc: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_crtc with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 122 ++--

Re: [Freedreno] [DPU PATCH 01/19] drm/msm: dpu_encoder: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_encoder with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 290 -

Re: [Freedreno] [DPU PATCH 03/19] drm/msm: dpu_plane: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_plane with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 +++---

Re: [Freedreno] [DPU PATCH 05/19] drm/msm: dpu_kms: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_kms with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 19 ---

Re: [Freedreno] [DPU PATCH 11/19] drm/msm: dpu_core_perf: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_core_perf with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +-

Re: [Freedreno] [DPU PATCH 13/19] drm/msm: dpu: Remove dpu evtlog

On 2018-06-21 02:18, Sean Paul wrote: Now that everything has been converted to tracepoints, remove the dpu evtlog. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 -

Re: [Freedreno] [DPU PATCH 12/19] drm/msm: dpu_mdss: Replace DPU_EVT with DRM_ERROR

On 2018-06-21 02:18, Sean Paul wrote: The events are only issued in error cases, so use DRM_ERROR instead. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Freedreno] [DPU PATCH 09/19] drm/msm: dpu_pingpong: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_pingpong with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 3 ++-

Re: [Freedreno] [DPU PATCH 1/2] drm/msm: dpu: Remove dpu_format_populate_layout_with_roi()

On 2018-06-22 00:32, Sean Paul wrote: It's unused, so let's get rid of it. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 31 - drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 16 --- 2 files changed, 47

Re: [Freedreno] [DPU PATCH 09/11] drm/msm/dpu: Remove unused code and move the header

On 2018-06-22 21:03, Jordan Crouse wrote: On Fri, Jun 22, 2018 at 09:51:28AM -0400, Sean Paul wrote: On Wed, May 30, 2018 at 10:50 AM Rajesh Yadav wrote: > > From: Jordan Crouse > > Remove unused code from dpu_io_util.c. The functions are only > used inside of the msm driver so remove the

Re: [Freedreno] [DPU PATCH 2/5] drm/msm/dpu: enable cursor plane for primary crtc

On 2018-06-20 19:18, Rob Clark wrote: On Wed, Jun 20, 2018 at 8:50 AM, Sravanthi Kollukuduru wrote: Reserve one DMA pipe as cursor plane and also, update crtc support of cursor in crtc_init. hmm, mdp5 in 820 had real cursor planes in hw, did these go away? If so I guess DMA plane is best

Re: [Freedreno] [DPU PATCH 10/19] drm/msm: dpu_core_irq: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_core_irq with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 52

Re: [Freedreno] [DPU PATCH 04/19] drm/msm: dpu_rm: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_rm with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c| 65 ++-

Re: [Freedreno] [DPU PATCH 06/19] drm/msm: dpu_encoder_phys_cmd: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_encoder_phys_cmd with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 79 +--

Re: [Freedreno] [DPU PATCH 07/19] drm/msm: dpu_encoder_phys_vid: Replace DPU_EVT with tracepoints

On 2018-06-21 02:18, Sean Paul wrote: This patch converts all DPU_EVTs in dpu_encoder_phys_vid with either a DRM_* log message or a linux tracepoint. Signed-off-by: Sean Paul --- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 36 --- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h

Re: [Freedreno] [DPU PATCH 3/6] drm/msm: Remove dpu bus scaling code

On 2018-06-29 02:23, Sean Paul wrote: QC bus scaling isn't upstream yet, so remove the bus scaling code until it is. Hi Sean, MDP5 driver does have bus_scaling code under DOWNSTREAM_CONFIG_MSM_BUS_SCALING gate. On similar lines we kept the DPU bus_scaling code under the

Re: [Freedreno] [DPU PATCH] drm/msm: Remove msm_hdcp devicetree bindings

On 2018-07-04 01:40, Sean Paul wrote: hdcp support was (temporarily) removed from msm. Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- .../devicetree/bindings/msm_hdcp/msm_hdcp.txt | 14 -- 1 file changed, 14 deletions(-) delete mode 100644

Re: [Freedreno] [DPU PATCH 2/3] dt-bindings: dpu: Fixup dt-bindings discrepencies

On 2018-07-04 01:18, Sean Paul wrote: Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- .../devicetree/bindings/display/msm/dpu.txt | 22 +++ 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/dpu.txt

Re: [Freedreno] [DPU PATCH 1/3] arm64: dts: qcom: Remove obsolete dpu dts files

On 2018-07-04 01:18, Sean Paul wrote: Signed-off-by: Sean Paul Reviewed-by: Rajesh Yadav --- .../boot/dts/qcom/sdm845-dpu-display.dtsi | 248 -- arch/arm64/boot/dts/qcom/sdm845-dpu.dtsi | 323 -- 2 files changed, 571 deletions(-) delete mode 100644

Re: [Freedreno] [DPU PATCH v3 05/12] drm/msm/dpu: update dpu sub-block offsets wrt dpu base address

Hi Sean, Looks like this patch is missing on for-next branch. Can you please help pull it in? Thanks, Rajesh On 2018-05-14 20:56, Rajesh Yadav wrote: The dpu sub-block offsets were defined wrt mdss base address instead of dpu base address. Since, dpu is now defined as a separate device, update

Re: [Freedreno] [[DPU]PATCH] drm/msm/dsi: move the API setting PLL src to modeset_init()

A brief update on this topic: The DSI clock warnings are addressed after adding runtime_pm support to DPU driver [1]. MDSS GDSC is used as genpd w/ above series and is requested by parent MDSS device on behalf of all child devices (like DPU, DSI etc). Before adding the runtime_pm support, DSI

Re: [Freedreno] [DPU PATCH 0/3] drm/msm: Fix build warnings

On 2018-04-03 01:40, Sean Paul wrote: Finally got around to this, I've split the worst 2 out into their own patches. Sean Sean Paul (3): drm/msm: Fix uninitialized use of prefill_lines drm/msm: Properly cast return with ERR_PTR drm/msm: Fix dpu build warnings Hi Sean, Some of these

Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

On 2018-04-04 15:56, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: MSM display controller hardware (DPU) has an inbuilt RSC block which can control power resources and bus bandwidth voting based on frame timing parameters w/o DPU driver intervention. In

Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

On 2018-04-05 01:51, Sean Paul wrote: On Wed, Apr 04, 2018 at 02:34:40PM +0530, Rajesh Yadav wrote: MSM display controller hardware (DPU) has an inbuilt RSC block which can control power resources and bus bandwidth voting based on frame timing parameters w/o DPU driver intervention. In absence

Re: [Freedreno] [DPU PATCH 1/3] drm/msm: Fix uninitialized use of prefill_lines

On 2018-04-03 01:40, Sean Paul wrote: prefill_lines initialization was removed in da61c67cdec4, but it's still being used :( Fixes: da61c67cdec4 drm/msm: remove hw rotation support Cc: Jeykumar Sankaran Signed-off-by: Sean Paul Reviewed-by:

Re: [Freedreno] [DPU PATCH 3/3] drm/msm: Fix dpu build warnings

On 2018-04-03 01:40, Sean Paul wrote: A bunch of warning fixes, build is clean now. Some of the changes done in this patch are unique and were not present in previous patch series to fix dpu driver warnings. Please consider refactoring this patch a bit to include the remaining valid fixes.