Re: [Freedreno] [patch] drm/msm/dsi: free first element on error

2017-02-16 Thread walter harms
Am 16.02.2017 12:53, schrieb Dan Carpenter: > On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote: >> On Thu, 16 Feb 2017, Dan Carpenter wrote: >>> We want to free msm_host->bus_clks[0] so the > should be >=. >>> >>> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") >>> S

Re: [Freedreno] [PATCH] drm/msm/dsi: Fix the releasing of resources in error path in 'dsi_bus_clk_enable()'

2017-02-26 Thread walter harms
Am 26.02.2017 08:52, schrieb Christophe JAILLET: > If a 'clk_prepare_enable()' fails, then we need to disable_unprepare the > clk already handled. > > With the current implemenatation, we try to do that on the clk that has > triggered the error, which is a no-op, and leave 'msm_host->bus_clks[0]

Re: [Freedreno] [PATCH v2] drm/msm/dsi: Fix the releasing of resources in error path in 'dsi_bus_clk_enable()'

2017-02-26 Thread walter harms
looks good to me. Reviewed-by: wha...@bfs.de Am 26.02.2017 13:10, schrieb Christophe JAILLET: > If a 'clk_prepare_enable()' fails, then we need to disable_unprepare the > clk already handled. > > With the current implemenatation, we try to do that on the clk that has > triggered the error, which