Re: [Freedreno] [DPU PATCH v3 0/5] List of patches for DP drivers on SnapDragon
On Mon, Dec 2, 2019 at 5:47 AM Chandan Uddaraju wrote: > > These patches are to enable DisplayPort driver on SanpDragon. > > These patches have dependency on clock driver changes that > provide DP clock support. This looks like just a functional/runtime dependency? Ie. it would only be the corresponding dt nodes that have compile time dependency on the clock driver? (vidcc, I assume?) BR, -R > > Changes in V2: > Core Dp driver: > -- Update copyright markings on all relevant files. > -- Change pr_err() to DRM_ERROR() > -- Use APIs directly instead of function pointers. > -- Use drm_display_mode structure to store link parameters in the driver. > -- Use macros for register definitions instead of hardcoded values in > dp_catalog.c file. > -- Replace writel_relaxed/readl_relaxed with writel/readl and remove > memory barriers. > -- Remove unnecessary NULL checks. > -- Use drm helper functions for dpcd read/write. > -- Use DRM_DEBUG_DP for debug msgs. > DP PLL driver: > -- Update copyright markings on all relevant files. > -- Use DRM_DEBUG_DP for debug msgs. > > Changes in V3: > Core Dp Driver: > -- Removed changes in dpu_io_util.[ch] > -- Added locking around "is_connected" flag and removed atomic_set() > -- Removed the argument validation checks in all the static functions >except initialization functions and few API calls across msm/dp files > -- Removed hardcoded values for register reads/writes > -- Removed vreg related generic structures. > -- Added return values where ever necessary. > -- Updated dp_ctrl_on function. > -- Calling the ctrl specific catalog functions directly instead of >function pointers. > -- Added seperate change that adds standard value in drm_dp_helper file. > -- Added separate change in this list that is used to initialize >displayport in DPU driver. > -- Added change to use drm_dp_get_adjust_request_voltage() function. > > > Chandan Uddaraju (4): > dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon > 845 > drm: add constant N value in helper file > drm/msm/dp: add displayPort driver support > drm/msm/dp: add support for DP PLL driver > > Jeykumar Sankaran (1): > drm/msm/dpu: add display port support in DPU > > .../devicetree/bindings/display/msm/dp.txt | 249 +++ > .../devicetree/bindings/display/msm/dpu.txt| 16 +- > drivers/gpu/drm/i915/display/intel_display.c |2 +- > drivers/gpu/drm/msm/Kconfig| 22 + > drivers/gpu/drm/msm/Makefile | 17 + > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 28 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 65 +- > drivers/gpu/drm/msm/dp/dp_aux.c| 548 +++ > drivers/gpu/drm/msm/dp/dp_aux.h| 37 + > drivers/gpu/drm/msm/dp/dp_catalog.c| 841 +++ > drivers/gpu/drm/msm/dp/dp_catalog.h| 84 ++ > drivers/gpu/drm/msm/dp/dp_ctrl.c | 1590 > > drivers/gpu/drm/msm/dp/dp_ctrl.h | 34 + > drivers/gpu/drm/msm/dp/dp_display.c| 997 > drivers/gpu/drm/msm/dp/dp_display.h| 32 + > drivers/gpu/drm/msm/dp/dp_drm.c| 173 +++ > drivers/gpu/drm/msm/dp/dp_drm.h| 20 + > drivers/gpu/drm/msm/dp/dp_extcon.c | 216 +++ > drivers/gpu/drm/msm/dp/dp_extcon.h | 84 ++ > drivers/gpu/drm/msm/dp/dp_link.c | 1185 +++ > drivers/gpu/drm/msm/dp/dp_link.h | 132 ++ > drivers/gpu/drm/msm/dp/dp_panel.c | 450 ++ > drivers/gpu/drm/msm/dp/dp_panel.h | 92 ++ > drivers/gpu/drm/msm/dp/dp_parser.c | 496 ++ > drivers/gpu/drm/msm/dp/dp_parser.h | 226 +++ > drivers/gpu/drm/msm/dp/dp_power.c | 558 +++ > drivers/gpu/drm/msm/dp/dp_power.h | 51 + > drivers/gpu/drm/msm/dp/dp_reg.h| 488 ++ > drivers/gpu/drm/msm/dp/pll/dp_pll.c| 135 ++ > drivers/gpu/drm/msm/dp/pll/dp_pll.h| 57 + > drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c | 401 + > drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.h | 86 ++ > drivers/gpu/drm/msm/dp/pll/dp_pll_10nm_util.c | 494 ++ > drivers/gpu/drm/msm/msm_drv.c |2 + > drivers/gpu/drm/msm/msm_drv.h | 42 + > include/drm/drm_dp_helper.h|1 + > 36 files changed, 9931 insertions(+), 20 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/msm/dp.txt > create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h > create mode 100644
[Freedreno] [DPU PATCH v3 0/5] List of patches for DP drivers on SnapDragon
These patches are to enable DisplayPort driver on SanpDragon. These patches have dependency on clock driver changes that provide DP clock support. Changes in V2: Core Dp driver: -- Update copyright markings on all relevant files. -- Change pr_err() to DRM_ERROR() -- Use APIs directly instead of function pointers. -- Use drm_display_mode structure to store link parameters in the driver. -- Use macros for register definitions instead of hardcoded values in dp_catalog.c file. -- Replace writel_relaxed/readl_relaxed with writel/readl and remove memory barriers. -- Remove unnecessary NULL checks. -- Use drm helper functions for dpcd read/write. -- Use DRM_DEBUG_DP for debug msgs. DP PLL driver: -- Update copyright markings on all relevant files. -- Use DRM_DEBUG_DP for debug msgs. Changes in V3: Core Dp Driver: -- Removed changes in dpu_io_util.[ch] -- Added locking around "is_connected" flag and removed atomic_set() -- Removed the argument validation checks in all the static functions except initialization functions and few API calls across msm/dp files -- Removed hardcoded values for register reads/writes -- Removed vreg related generic structures. -- Added return values where ever necessary. -- Updated dp_ctrl_on function. -- Calling the ctrl specific catalog functions directly instead of function pointers. -- Added seperate change that adds standard value in drm_dp_helper file. -- Added separate change in this list that is used to initialize displayport in DPU driver. -- Added change to use drm_dp_get_adjust_request_voltage() function. Chandan Uddaraju (4): dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon 845 drm: add constant N value in helper file drm/msm/dp: add displayPort driver support drm/msm/dp: add support for DP PLL driver Jeykumar Sankaran (1): drm/msm/dpu: add display port support in DPU .../devicetree/bindings/display/msm/dp.txt | 249 +++ .../devicetree/bindings/display/msm/dpu.txt| 16 +- drivers/gpu/drm/i915/display/intel_display.c |2 +- drivers/gpu/drm/msm/Kconfig| 22 + drivers/gpu/drm/msm/Makefile | 17 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 28 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 65 +- drivers/gpu/drm/msm/dp/dp_aux.c| 548 +++ drivers/gpu/drm/msm/dp/dp_aux.h| 37 + drivers/gpu/drm/msm/dp/dp_catalog.c| 841 +++ drivers/gpu/drm/msm/dp/dp_catalog.h| 84 ++ drivers/gpu/drm/msm/dp/dp_ctrl.c | 1590 drivers/gpu/drm/msm/dp/dp_ctrl.h | 34 + drivers/gpu/drm/msm/dp/dp_display.c| 997 drivers/gpu/drm/msm/dp/dp_display.h| 32 + drivers/gpu/drm/msm/dp/dp_drm.c| 173 +++ drivers/gpu/drm/msm/dp/dp_drm.h| 20 + drivers/gpu/drm/msm/dp/dp_extcon.c | 216 +++ drivers/gpu/drm/msm/dp/dp_extcon.h | 84 ++ drivers/gpu/drm/msm/dp/dp_link.c | 1185 +++ drivers/gpu/drm/msm/dp/dp_link.h | 132 ++ drivers/gpu/drm/msm/dp/dp_panel.c | 450 ++ drivers/gpu/drm/msm/dp/dp_panel.h | 92 ++ drivers/gpu/drm/msm/dp/dp_parser.c | 496 ++ drivers/gpu/drm/msm/dp/dp_parser.h | 226 +++ drivers/gpu/drm/msm/dp/dp_power.c | 558 +++ drivers/gpu/drm/msm/dp/dp_power.h | 51 + drivers/gpu/drm/msm/dp/dp_reg.h| 488 ++ drivers/gpu/drm/msm/dp/pll/dp_pll.c| 135 ++ drivers/gpu/drm/msm/dp/pll/dp_pll.h| 57 + drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c | 401 + drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.h | 86 ++ drivers/gpu/drm/msm/dp/pll/dp_pll_10nm_util.c | 494 ++ drivers/gpu/drm/msm/msm_drv.c |2 + drivers/gpu/drm/msm/msm_drv.h | 42 + include/drm/drm_dp_helper.h|1 + 36 files changed, 9931 insertions(+), 20 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/msm/dp.txt create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h create mode 100644
