Re: [Freedreno] [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node
On Thu, Aug 15, 2019 at 10:34:17AM +0200, Linus Walleij wrote: > On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > > > pm8941 is missing the 5vs2 regulator node so let's add it since its > > needed to get the external display working. This regulator was already > > configured in the interrupts property on the parent node. > > > > Note that this regulator is referred to as mvs2 in the downstream MSM > > kernel sources. > > When I looked at it it seemed like this convention is used for power > supplies that appear on both the main PMIC and the "extra (boot? basic? > low power?) PMIC that the main 80xx PMIC has mvs1 and the > other 89xx PMIC has mvs2. According to the downstream MSM sources, the 5vs1 and 5vs2 rails are both on the second pm8941 PMIC: https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/arch/arm/boot/dts/msm8974-regulator.dtsi#L18 > I suppose it is named "mvs" on both PMICs and this is just a rail > name so as not to confuse the schematic? That sounds reasonable. > > Signed-off-by: Brian Masney > > Reviewed-by: Linus Walleij Thank you! Brian ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
Re: [Freedreno] [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node
On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > pm8941 is missing the 5vs2 regulator node so let's add it since its > needed to get the external display working. This regulator was already > configured in the interrupts property on the parent node. > > Note that this regulator is referred to as mvs2 in the downstream MSM > kernel sources. When I looked at it it seemed like this convention is used for power supplies that appear on both the main PMIC and the "extra (boot? basic? low power?) PMIC that the main 80xx PMIC has mvs1 and the other 89xx PMIC has mvs2. I suppose it is named "mvs" on both PMICs and this is just a rail name so as not to confuse the schematic? > Signed-off-by: Brian Masney Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
[Freedreno] [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node
pm8941 is missing the 5vs2 regulator node so let's add it since its
needed to get the external display working. This regulator was already
configured in the interrupts property on the parent node.
Note that this regulator is referred to as mvs2 in the downstream MSM
kernel sources.
Signed-off-by: Brian Masney
---
arch/arm/boot/dts/qcom-pm8941.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi
b/arch/arm/boot/dts/qcom-pm8941.dtsi
index f198480c8ef4..c1f2012d1c8b 100644
--- a/arch/arm/boot/dts/qcom-pm8941.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
@@ -178,6 +178,16 @@
qcom,vs-soft-start-strength = <0>;
regulator-initial-mode = <1>;
};
+
+ pm8941_5vs2: 5vs2 {
+ regulator-enable-ramp-delay = <1000>;
+ regulator-pull-down;
+ regulator-over-current-protection;
+ qcom,ocp-max-retries = <10>;
+ qcom,ocp-retry-delay = <30>;
+ qcom,vs-soft-start-strength = <0>;
+ regulator-initial-mode = <1>;
+ };
};
};
};
--
2.21.0
___
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
