Re: [Freedreno] [PATCH 4/6] drm/atomic: add new drm_debug bit to dump atomic state before commit

2016-10-17 Thread Sean Paul
On Fri, Oct 14, 2016 at 7:55 PM, Rob Clark wrote: Could you add a commit message detailing what and when the state is dumped? > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/drm_atomic.c | 93 > > include/drm/drmP.h | 1 + > include/d

Re: [Freedreno] [PATCH 4/6] drm/atomic: add new drm_debug bit to dump atomic state before commit

2016-10-16 Thread Daniel Vetter
On Fri, Oct 14, 2016 at 07:55:51PM -0400, Rob Clark wrote: > Signed-off-by: Rob Clark General comment: Some drivers (and I think this would be useful in general) also dump state into debugfs with seq_file. And we have a bunch of other places where unfortunately we duplicate dumping functions betw

[Freedreno] [PATCH 4/6] drm/atomic: add new drm_debug bit to dump atomic state before commit

2016-10-14 Thread Rob Clark
Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic.c | 93 include/drm/drmP.h | 1 + include/drm/drm_crtc.h | 37 ++ 3 files changed, 131 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/d