Re: [Freedreno] [PATCH v2 1/6] drm: msm: remove resv fields from msm_gem_object struct

2019-05-13 Thread Brian Masney
On Mon, May 13, 2019 at 01:32:39PM -0700, Bjorn Andersson wrote: > On Wed 08 May 19:03 PDT 2019, Brian Masney wrote: > > > The msm_gem_object structure contains resv and _resv fields that are > > no longer needed since the reservation object is now stored on > > drm_gem_object.

Re: [Freedreno] [PATCH v2 1/6] drm: msm: remove resv fields from msm_gem_object struct

2019-05-13 Thread Bjorn Andersson
On Wed 08 May 19:03 PDT 2019, Brian Masney wrote: > The msm_gem_object structure contains resv and _resv fields that are > no longer needed since the reservation object is now stored on > drm_gem_object. msm_atomic_prepare_fb() and msm_atomic_prepare_fb() > both referenced the wrong reservation

[Freedreno] [PATCH v2 1/6] drm: msm: remove resv fields from msm_gem_object struct

2019-05-08 Thread Brian Masney
The msm_gem_object structure contains resv and _resv fields that are no longer needed since the reservation object is now stored on drm_gem_object. msm_atomic_prepare_fb() and msm_atomic_prepare_fb() both referenced the wrong reservation object, and would lead to an attempt to dereference a NULL