Re: [Freedreno] linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c: 2 * pointless tests ?

2016-06-15 Thread David Binderman
Hello there, >yup, looks like we can drop the two pipe<0 checks. Righto. >Care to send a patch? Oh dear. My success rate with patches is near zero. Maybe something like this might be suitable: *** linux-3.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c.sav 2016-06-15 10:58:04.868619030 +0100 ---

Re: [Freedreno] linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c: 2 * pointless tests ?

2016-06-13 Thread Rob Clark
yup, looks like we can drop the two pipe<0 checks. Care to send a patch? BR, -R On Mon, Jun 13, 2016 at 10:51 AM, David Binderman wrote: > Hello there, > > 1. > > linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:545]: (style) > Checking if unsigned variable 'pipe' is less than zero. > > So

[Freedreno] linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c: 2 * pointless tests ?

2016-06-13 Thread David Binderman
Hello there, 1. linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:545]: (style) Checking if unsigned variable 'pipe' is less than zero. Source code is if (pipe < 0 || pipe >= priv->num_crtcs) { 2. linux-4.7-rc3/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:567]: (style) Checking if unsigned