Re: [Freedreno] [PATCH 10/13] drm/msm: Support multiple ringbuffers

2017-05-31 Thread Daniel Vetter
On Tue, May 30, 2017 at 12:34:34PM -0400, Alex Deucher wrote: > On Tue, May 30, 2017 at 12:20 PM, Jordan Crouse > wrote: > > On Sun, May 28, 2017 at 09:43:35AM -0400, Rob Clark wrote: > >> On Mon, May 8, 2017 at 4:35 PM, Jordan Crouse > >> wrote: > >> > Add the infrastructure to support the ide

Re: [Freedreno] [PATCH 10/13] drm/msm: Support multiple ringbuffers

2017-05-30 Thread Alex Deucher
On Tue, May 30, 2017 at 12:20 PM, Jordan Crouse wrote: > On Sun, May 28, 2017 at 09:43:35AM -0400, Rob Clark wrote: >> On Mon, May 8, 2017 at 4:35 PM, Jordan Crouse wrote: >> > Add the infrastructure to support the idea of multiple ringbuffers. >> > Assign each ringbuffer an id and use that as an

Re: [Freedreno] [PATCH 10/13] drm/msm: Support multiple ringbuffers

2017-05-30 Thread Jordan Crouse
On Sun, May 28, 2017 at 09:43:35AM -0400, Rob Clark wrote: > On Mon, May 8, 2017 at 4:35 PM, Jordan Crouse wrote: > > Add the infrastructure to support the idea of multiple ringbuffers. > > Assign each ringbuffer an id and use that as an index for the various > > ring specific operations. > > > >

Re: [Freedreno] [PATCH 10/13] drm/msm: Support multiple ringbuffers

2017-05-28 Thread Rob Clark
On Mon, May 8, 2017 at 4:35 PM, Jordan Crouse wrote: > Add the infrastructure to support the idea of multiple ringbuffers. > Assign each ringbuffer an id and use that as an index for the various > ring specific operations. > > The biggest delta is to support legacy fences. Each fence gets its own

Re: [Freedreno] [PATCH 10/13] drm/msm: Support multiple ringbuffers

2017-05-25 Thread Rob Clark
On Thu, May 25, 2017 at 1:25 PM, Jordan Crouse wrote: > On Mon, May 08, 2017 at 02:35:06PM -0600, Jordan Crouse wrote: >> -#define rbmemptr(adreno_gpu, member) \ >> +#define _sizeof(member) \ >> + sizeof(((struct adreno_rbmemptrs *) 0)->member[0]) >> + >> +#define _base(adreno_gpu, member) \

Re: [Freedreno] [PATCH 10/13] drm/msm: Support multiple ringbuffers

2017-05-25 Thread Jordan Crouse
On Mon, May 08, 2017 at 02:35:06PM -0600, Jordan Crouse wrote: > -#define rbmemptr(adreno_gpu, member) \ > +#define _sizeof(member) \ > + sizeof(((struct adreno_rbmemptrs *) 0)->member[0]) > + > +#define _base(adreno_gpu, member) \ > ((adreno_gpu)->memptrs_iova + offsetof(struct adreno_