Re: [Freedreno] [PATCH 12/12] drm/msm: gpu: Use the zap shader on 5XX if we can

2016-12-06 Thread Bjorn Andersson
On Tue 06 Dec 07:35 PST 2016, Jordan Crouse wrote: > On Mon, Dec 05, 2016 at 11:57:12AM -0800, Bjorn Andersson wrote: > > On Mon 28 Nov 11:28 PST 2016, Jordan Crouse wrote: > > > > > The A5XX GPU powers on in "secure" mode. In secure mode the GPU can > > > only render to buffers that are marked

Re: [Freedreno] [PATCH 12/12] drm/msm: gpu: Use the zap shader on 5XX if we can

2016-12-06 Thread Rob Clark
On Tue, Dec 6, 2016 at 10:35 AM, Jordan Crouse wrote: > On Mon, Dec 05, 2016 at 11:57:12AM -0800, Bjorn Andersson wrote: >> On Mon 28 Nov 11:28 PST 2016, Jordan Crouse wrote: >> >> > The A5XX GPU powers on in "secure" mode. In secure mode the GPU can >> > only render to

Re: [Freedreno] [PATCH 12/12] drm/msm: gpu: Use the zap shader on 5XX if we can

2016-12-06 Thread Jordan Crouse
On Mon, Dec 05, 2016 at 11:57:12AM -0800, Bjorn Andersson wrote: > On Mon 28 Nov 11:28 PST 2016, Jordan Crouse wrote: > > > The A5XX GPU powers on in "secure" mode. In secure mode the GPU can > > only render to buffers that are marked as secure and inaccessible > > to the kernel and user through

Re: [Freedreno] [PATCH 12/12] drm/msm: gpu: Use the zap shader on 5XX if we can

2016-12-05 Thread Bjorn Andersson
On Mon 05 Dec 11:57 PST 2016, Bjorn Andersson wrote: [..] > You should rather add a struct device zap_dev to your adreno context, do > minimal initialization (name and a parent I think is enough), call > device_register(_dev);, of_reserved_mem_device_init() and then use > that for your dma

Re: [Freedreno] [PATCH 12/12] drm/msm: gpu: Use the zap shader on 5XX if we can

2016-12-05 Thread Bjorn Andersson
On Mon 28 Nov 11:28 PST 2016, Jordan Crouse wrote: > The A5XX GPU powers on in "secure" mode. In secure mode the GPU can > only render to buffers that are marked as secure and inaccessible > to the kernel and user through a series of hardware protections. In > practice secure mode is used to draw