Re: [Freedreno] [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema
On 10/2/19 6:06 PM, Krzysztof Kozlowski wrote: > Convert Generic Power Domain bindings to DT schema format using > json-schema. The consumer bindings are split to separate file. > > Signed-off-by: Krzysztof Kozlowski For the media bindings: Acked-by: Hans Verkuil Thanks! Hans > > --- > > Changes since v1: > 1. Select all nodes for consumers, > 2. Remove from consumers duplicated properties with dt-schema, > 3. Fix power domain pattern, > 4. Remove unneeded types. > --- > .../devicetree/bindings/arm/arm,scmi.txt | 2 +- > .../devicetree/bindings/arm/arm,scpi.txt | 2 +- > .../bindings/arm/freescale/fsl,scu.txt| 2 +- > .../bindings/clock/clk-exynos-audss.txt | 2 +- > .../bindings/clock/exynos5433-clock.txt | 4 +- > .../bindings/clock/renesas,cpg-mssr.txt | 2 +- > .../clock/renesas,r8a7778-cpg-clocks.txt | 2 +- > .../clock/renesas,r8a7779-cpg-clocks.txt | 2 +- > .../clock/renesas,rcar-gen2-cpg-clocks.txt| 2 +- > .../bindings/clock/renesas,rz-cpg-clocks.txt | 2 +- > .../bindings/clock/ti/davinci/psc.txt | 2 +- > .../bindings/display/etnaviv/etnaviv-drm.txt | 2 +- > .../devicetree/bindings/display/msm/dpu.txt | 2 +- > .../devicetree/bindings/display/msm/mdp5.txt | 2 +- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 2 +- > .../firmware/nvidia,tegra186-bpmp.txt | 2 +- > .../bindings/media/imx7-mipi-csi2.txt | 3 +- > .../bindings/media/mediatek-jpeg-decoder.txt | 3 +- > .../bindings/media/mediatek-mdp.txt | 3 +- > .../bindings/opp/qcom-nvmem-cpufreq.txt | 2 +- > .../devicetree/bindings/pci/pci-keystone.txt | 2 +- > .../bindings/phy/ti,phy-am654-serdes.txt | 2 +- > .../bindings/power/amlogic,meson-gx-pwrc.txt | 2 +- > .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +- > .../bindings/power/fsl,imx-gpcv2.txt | 2 +- > .../power/power-domain-consumers.yaml | 105 + > .../bindings/power/power-domain.yaml | 134 > .../bindings/power/power_domain.txt | 205 -- > .../devicetree/bindings/power/qcom,rpmpd.txt | 2 +- > .../bindings/power/renesas,rcar-sysc.txt | 2 +- > .../bindings/power/renesas,sysc-rmobile.txt | 2 +- > .../bindings/power/xlnx,zynqmp-genpd.txt | 2 +- > .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 2 +- > .../bindings/soc/mediatek/scpsys.txt | 2 +- > .../bindings/soc/ti/sci-pm-domain.txt | 2 +- > .../bindings/usb/nvidia,tegra124-xusb.txt | 4 +- > MAINTAINERS | 2 +- > 37 files changed, 278 insertions(+), 241 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/power/power-domain-consumers.yaml > create mode 100644 Documentation/devicetree/bindings/power/power-domain.yaml > delete mode 100644 Documentation/devicetree/bindings/power/power_domain.txt > > diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt > b/Documentation/devicetree/bindings/arm/arm,scmi.txt > index 083dbf96ee00..f493d69e6194 100644 > --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt > +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt > @@ -100,7 +100,7 @@ Required sub-node properties: > > [0] http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/index.html > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[2] Documentation/devicetree/bindings/power/power_domain.txt > +[2] Documentation/devicetree/bindings/power/power-domain.yaml > [3] Documentation/devicetree/bindings/thermal/thermal.txt > [4] Documentation/devicetree/bindings/sram/sram.txt > [5] Documentation/devicetree/bindings/reset/reset.txt > diff --git a/Documentation/devicetree/bindings/arm/arm,scpi.txt > b/Documentation/devicetree/bindings/arm/arm,scpi.txt > index 401831973638..7b83ef43b418 100644 > --- a/Documentation/devicetree/bindings/arm/arm,scpi.txt > +++ b/Documentation/devicetree/bindings/arm/arm,scpi.txt > @@ -110,7 +110,7 @@ Required properties: > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > [2] Documentation/devicetree/bindings/thermal/thermal.txt > [3] Documentation/devicetree/bindings/sram/sram.txt > -[4] Documentation/devicetree/bindings/power/power_domain.txt > +[4] Documentation/devicetree/bindings/power/power-domain.yaml > > Example: > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index c149fadc6f47..6c8a61b971f1 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -124,7 +124,7 @@ Required properties for Pinctrl sub nodes: > CONFIG settings. > > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[2] Documentation/devicetree/bindings/power/power_domain.txt > +[2]
Re: [Freedreno] [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema
On Fri, Oct 11, 2019 at 10:03:39AM -0500, Rob Herring wrote: > On Wed, Oct 02, 2019 at 06:06:30PM +0200, Krzysztof Kozlowski wrote: > > Convert Generic Power Domain bindings to DT schema format using > > json-schema. The consumer bindings are split to separate file. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v1: > > 1. Select all nodes for consumers, > > 2. Remove from consumers duplicated properties with dt-schema, > > 3. Fix power domain pattern, > > 4. Remove unneeded types. > > --- > > .../devicetree/bindings/arm/arm,scmi.txt | 2 +- > > .../devicetree/bindings/arm/arm,scpi.txt | 2 +- > > .../bindings/arm/freescale/fsl,scu.txt| 2 +- > > .../bindings/clock/clk-exynos-audss.txt | 2 +- > > .../bindings/clock/exynos5433-clock.txt | 4 +- > > .../bindings/clock/renesas,cpg-mssr.txt | 2 +- > > .../clock/renesas,r8a7778-cpg-clocks.txt | 2 +- > > .../clock/renesas,r8a7779-cpg-clocks.txt | 2 +- > > .../clock/renesas,rcar-gen2-cpg-clocks.txt| 2 +- > > .../bindings/clock/renesas,rz-cpg-clocks.txt | 2 +- > > .../bindings/clock/ti/davinci/psc.txt | 2 +- > > .../bindings/display/etnaviv/etnaviv-drm.txt | 2 +- > > .../devicetree/bindings/display/msm/dpu.txt | 2 +- > > .../devicetree/bindings/display/msm/mdp5.txt | 2 +- > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 2 +- > > .../firmware/nvidia,tegra186-bpmp.txt | 2 +- > > .../bindings/media/imx7-mipi-csi2.txt | 3 +- > > .../bindings/media/mediatek-jpeg-decoder.txt | 3 +- > > .../bindings/media/mediatek-mdp.txt | 3 +- > > .../bindings/opp/qcom-nvmem-cpufreq.txt | 2 +- > > .../devicetree/bindings/pci/pci-keystone.txt | 2 +- > > .../bindings/phy/ti,phy-am654-serdes.txt | 2 +- > > .../bindings/power/amlogic,meson-gx-pwrc.txt | 2 +- > > .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +- > > .../bindings/power/fsl,imx-gpcv2.txt | 2 +- > > .../power/power-domain-consumers.yaml | 105 + > > .../bindings/power/power-domain.yaml | 134 > > .../bindings/power/power_domain.txt | 205 -- > > .../devicetree/bindings/power/qcom,rpmpd.txt | 2 +- > > .../bindings/power/renesas,rcar-sysc.txt | 2 +- > > .../bindings/power/renesas,sysc-rmobile.txt | 2 +- > > .../bindings/power/xlnx,zynqmp-genpd.txt | 2 +- > > .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 2 +- > > .../bindings/soc/mediatek/scpsys.txt | 2 +- > > .../bindings/soc/ti/sci-pm-domain.txt | 2 +- > > .../bindings/usb/nvidia,tegra124-xusb.txt | 4 +- > > MAINTAINERS | 2 +- > > 37 files changed, 278 insertions(+), 241 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/power/power-domain-consumers.yaml > > create mode 100644 > > Documentation/devicetree/bindings/power/power-domain.yaml > > delete mode 100644 Documentation/devicetree/bindings/power/power_domain.txt > > > > diff --git > > a/Documentation/devicetree/bindings/power/power-domain-consumers.yaml > > b/Documentation/devicetree/bindings/power/power-domain-consumers.yaml > > new file mode 100644 > > index ..f65078e1260e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/power-domain-consumers.yaml > > @@ -0,0 +1,105 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/power/power-domain-consumers.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: PM domain consumers > > + > > +maintainers: > > + - Rafael J. Wysocki > > + - Kevin Hilman > > + - Ulf Hansson > > + > > +description: |+ > > + See power-domain.yaml > > + > > +select: true > > + > > +allOf: > > + - $ref: /schemas/power-domain/power-domain-consumer.yaml > > I don't like this split. We should move the contents of this file to the > above file. > > I checked the authorship of the relevant lines and they are all except > for a small number of lines from Linaro authors (Viresh and Ulf). I have > permission from Linaro to dual license Linaro authored bindings, so it's > not a problem to move this. I can do that and you can just drop this file. Sure, what to do with the references to power-domain consumers part? I could leave the text file and do not update the references for consumers (like I did in last PWM bindings patch, v4). Best regards, Krzysztof > > > + > > +properties: > > + required-opps: > > +$ref: /schemas/types.yaml#/definitions/phandle > > +description: > > + This contains phandle to an OPP node in another device's OPP table. > > + It may contain an array of phandles, where each phandle points to an > > OPP > > + of a different device. It should not contain multiple phandles to > > the OPP > > + nodes in the same OPP table. This
Re: [Freedreno] [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema
On Wed, Oct 02, 2019 at 06:06:30PM +0200, Krzysztof Kozlowski wrote:
> Convert Generic Power Domain bindings to DT schema format using
> json-schema. The consumer bindings are split to separate file.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
>
> Changes since v1:
> 1. Select all nodes for consumers,
> 2. Remove from consumers duplicated properties with dt-schema,
> 3. Fix power domain pattern,
> 4. Remove unneeded types.
> ---
> .../devicetree/bindings/arm/arm,scmi.txt | 2 +-
> .../devicetree/bindings/arm/arm,scpi.txt | 2 +-
> .../bindings/arm/freescale/fsl,scu.txt| 2 +-
> .../bindings/clock/clk-exynos-audss.txt | 2 +-
> .../bindings/clock/exynos5433-clock.txt | 4 +-
> .../bindings/clock/renesas,cpg-mssr.txt | 2 +-
> .../clock/renesas,r8a7778-cpg-clocks.txt | 2 +-
> .../clock/renesas,r8a7779-cpg-clocks.txt | 2 +-
> .../clock/renesas,rcar-gen2-cpg-clocks.txt| 2 +-
> .../bindings/clock/renesas,rz-cpg-clocks.txt | 2 +-
> .../bindings/clock/ti/davinci/psc.txt | 2 +-
> .../bindings/display/etnaviv/etnaviv-drm.txt | 2 +-
> .../devicetree/bindings/display/msm/dpu.txt | 2 +-
> .../devicetree/bindings/display/msm/mdp5.txt | 2 +-
> .../devicetree/bindings/dsp/fsl,dsp.yaml | 2 +-
> .../firmware/nvidia,tegra186-bpmp.txt | 2 +-
> .../bindings/media/imx7-mipi-csi2.txt | 3 +-
> .../bindings/media/mediatek-jpeg-decoder.txt | 3 +-
> .../bindings/media/mediatek-mdp.txt | 3 +-
> .../bindings/opp/qcom-nvmem-cpufreq.txt | 2 +-
> .../devicetree/bindings/pci/pci-keystone.txt | 2 +-
> .../bindings/phy/ti,phy-am654-serdes.txt | 2 +-
> .../bindings/power/amlogic,meson-gx-pwrc.txt | 2 +-
> .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +-
> .../bindings/power/fsl,imx-gpcv2.txt | 2 +-
> .../power/power-domain-consumers.yaml | 105 +
> .../bindings/power/power-domain.yaml | 134
> .../bindings/power/power_domain.txt | 205 --
> .../devicetree/bindings/power/qcom,rpmpd.txt | 2 +-
> .../bindings/power/renesas,rcar-sysc.txt | 2 +-
> .../bindings/power/renesas,sysc-rmobile.txt | 2 +-
> .../bindings/power/xlnx,zynqmp-genpd.txt | 2 +-
> .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 2 +-
> .../bindings/soc/mediatek/scpsys.txt | 2 +-
> .../bindings/soc/ti/sci-pm-domain.txt | 2 +-
> .../bindings/usb/nvidia,tegra124-xusb.txt | 4 +-
> MAINTAINERS | 2 +-
> 37 files changed, 278 insertions(+), 241 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/power/power-domain-consumers.yaml
> create mode 100644 Documentation/devicetree/bindings/power/power-domain.yaml
> delete mode 100644 Documentation/devicetree/bindings/power/power_domain.txt
> diff --git
> a/Documentation/devicetree/bindings/power/power-domain-consumers.yaml
> b/Documentation/devicetree/bindings/power/power-domain-consumers.yaml
> new file mode 100644
> index ..f65078e1260e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/power-domain-consumers.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/power-domain-consumers.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PM domain consumers
> +
> +maintainers:
> + - Rafael J. Wysocki
> + - Kevin Hilman
> + - Ulf Hansson
> +
> +description: |+
> + See power-domain.yaml
> +
> +select: true
> +
> +allOf:
> + - $ref: /schemas/power-domain/power-domain-consumer.yaml
I don't like this split. We should move the contents of this file to the
above file.
I checked the authorship of the relevant lines and they are all except
for a small number of lines from Linaro authors (Viresh and Ulf). I have
permission from Linaro to dual license Linaro authored bindings, so it's
not a problem to move this. I can do that and you can just drop this file.
> +
> +properties:
> + required-opps:
> +$ref: /schemas/types.yaml#/definitions/phandle
> +description:
> + This contains phandle to an OPP node in another device's OPP table.
> + It may contain an array of phandles, where each phandle points to an
> OPP
> + of a different device. It should not contain multiple phandles to the
> OPP
> + nodes in the same OPP table. This specifies the minimum required OPP
> + of the device(s), whose OPP's phandle is present in this property,
> + for the functioning of the current device at the current OPP (where
> this
> + property is present).
> +
> +examples:
> + - |
> +leaky-device@1235 {
> + compatible = "foo,i-leak-current";
> + reg = <0x1235 0x1000>;
> + power-domains = < 0>;
> + power-domain-names = "io";
> +};
> +
> +leaky-device@12351000 {
> +
Re: [Freedreno] [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema
Quoting Krzysztof Kozlowski (2019-10-02 09:06:30) > Convert Generic Power Domain bindings to DT schema format using > json-schema. The consumer bindings are split to separate file. > > Signed-off-by: Krzysztof Kozlowski > > --- Acked-by: Stephen Boyd ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
Re: [Freedreno] [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema
On Wed, 2 Oct 2019 at 18:06, Krzysztof Kozlowski wrote: > > Convert Generic Power Domain bindings to DT schema format using > json-schema. The consumer bindings are split to separate file. > > Signed-off-by: Krzysztof Kozlowski Thanks for working on this, it looks good to me! Although, I have to admit that I am still learning about the DT json-schema. So, FWIW: Reviewed-by: Ulf Hansson Kind regards Uffe > > --- > > Changes since v1: > 1. Select all nodes for consumers, > 2. Remove from consumers duplicated properties with dt-schema, > 3. Fix power domain pattern, > 4. Remove unneeded types. > --- > .../devicetree/bindings/arm/arm,scmi.txt | 2 +- > .../devicetree/bindings/arm/arm,scpi.txt | 2 +- > .../bindings/arm/freescale/fsl,scu.txt| 2 +- > .../bindings/clock/clk-exynos-audss.txt | 2 +- > .../bindings/clock/exynos5433-clock.txt | 4 +- > .../bindings/clock/renesas,cpg-mssr.txt | 2 +- > .../clock/renesas,r8a7778-cpg-clocks.txt | 2 +- > .../clock/renesas,r8a7779-cpg-clocks.txt | 2 +- > .../clock/renesas,rcar-gen2-cpg-clocks.txt| 2 +- > .../bindings/clock/renesas,rz-cpg-clocks.txt | 2 +- > .../bindings/clock/ti/davinci/psc.txt | 2 +- > .../bindings/display/etnaviv/etnaviv-drm.txt | 2 +- > .../devicetree/bindings/display/msm/dpu.txt | 2 +- > .../devicetree/bindings/display/msm/mdp5.txt | 2 +- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 2 +- > .../firmware/nvidia,tegra186-bpmp.txt | 2 +- > .../bindings/media/imx7-mipi-csi2.txt | 3 +- > .../bindings/media/mediatek-jpeg-decoder.txt | 3 +- > .../bindings/media/mediatek-mdp.txt | 3 +- > .../bindings/opp/qcom-nvmem-cpufreq.txt | 2 +- > .../devicetree/bindings/pci/pci-keystone.txt | 2 +- > .../bindings/phy/ti,phy-am654-serdes.txt | 2 +- > .../bindings/power/amlogic,meson-gx-pwrc.txt | 2 +- > .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +- > .../bindings/power/fsl,imx-gpcv2.txt | 2 +- > .../power/power-domain-consumers.yaml | 105 + > .../bindings/power/power-domain.yaml | 134 > .../bindings/power/power_domain.txt | 205 -- > .../devicetree/bindings/power/qcom,rpmpd.txt | 2 +- > .../bindings/power/renesas,rcar-sysc.txt | 2 +- > .../bindings/power/renesas,sysc-rmobile.txt | 2 +- > .../bindings/power/xlnx,zynqmp-genpd.txt | 2 +- > .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 2 +- > .../bindings/soc/mediatek/scpsys.txt | 2 +- > .../bindings/soc/ti/sci-pm-domain.txt | 2 +- > .../bindings/usb/nvidia,tegra124-xusb.txt | 4 +- > MAINTAINERS | 2 +- > 37 files changed, 278 insertions(+), 241 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/power/power-domain-consumers.yaml > create mode 100644 Documentation/devicetree/bindings/power/power-domain.yaml > delete mode 100644 Documentation/devicetree/bindings/power/power_domain.txt > > diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt > b/Documentation/devicetree/bindings/arm/arm,scmi.txt > index 083dbf96ee00..f493d69e6194 100644 > --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt > +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt > @@ -100,7 +100,7 @@ Required sub-node properties: > > [0] http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/index.html > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[2] Documentation/devicetree/bindings/power/power_domain.txt > +[2] Documentation/devicetree/bindings/power/power-domain.yaml > [3] Documentation/devicetree/bindings/thermal/thermal.txt > [4] Documentation/devicetree/bindings/sram/sram.txt > [5] Documentation/devicetree/bindings/reset/reset.txt > diff --git a/Documentation/devicetree/bindings/arm/arm,scpi.txt > b/Documentation/devicetree/bindings/arm/arm,scpi.txt > index 401831973638..7b83ef43b418 100644 > --- a/Documentation/devicetree/bindings/arm/arm,scpi.txt > +++ b/Documentation/devicetree/bindings/arm/arm,scpi.txt > @@ -110,7 +110,7 @@ Required properties: > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > [2] Documentation/devicetree/bindings/thermal/thermal.txt > [3] Documentation/devicetree/bindings/sram/sram.txt > -[4] Documentation/devicetree/bindings/power/power_domain.txt > +[4] Documentation/devicetree/bindings/power/power-domain.yaml > > Example: > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index c149fadc6f47..6c8a61b971f1 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -124,7 +124,7 @@ Required properties for Pinctrl sub nodes: > CONFIG settings. > > [1]
