Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Jan Cholasta
On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically run the lint script during make rpms|client-rpms|srpms. NACK until ticket 1184 is resolved and pushed. Currently, pylint check fails when optional python packages (like python-rhsm)

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Martin Kosek
On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically run the lint script during make rpms|client-rpms|srpms. NACK until ticket 1184 is resolved and pushed. Currently, pylint

[Freeipa-devel] [PATCH] 052 Log temporary files in ipa-client-install

2011-04-27 Thread Martin Kosek
This patch will help investigating issues like in ticket 1100 resolved by my patch 50. -- This patch adds logging of temporary files (Kerberos configuration, nsupdate commands) that may be very useful for debugging purposes. https://fedorahosted.org/freeipa/ticket/1093

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Jan Cholasta
On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically run the lint script during make rpms|client-rpms|srpms. NACK until ticket 1184 is

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Dmitri Pal
On 04/27/2011 08:13 AM, Jan Cholasta wrote: On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically run the lint script during make

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Adam Young
On 04/27/2011 09:34 AM, Dmitri Pal wrote: On 04/27/2011 08:13 AM, Jan Cholasta wrote: On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011 18:14, Martin Kosek wrote: On Tue, 2011-04-26 at 13:42 +0200, Jan Cholasta wrote: Automatically

[Freeipa-devel] [PATCH] 053 Forbid reinstallation in ipa-client-install

2011-04-27 Thread Martin Kosek
The --force option may be misused to reinstall an existing IPA client. This is not supported and may lead to unexpected errors. When required, the cleanest way to re-install IPA client is to run uninstall and then install again. This patch also includes few cosmetic changes in LDAP term case to

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Martin Kosek
On Wed, 2011-04-27 at 09:56 -0400, Adam Young wrote: On 04/27/2011 09:34 AM, Dmitri Pal wrote: On 04/27/2011 08:13 AM, Jan Cholasta wrote: On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011 18:14, Martin Kosek wrote: On Tue,

Re: [Freeipa-devel] [PATCH] 143 Entitlement quantity validation.

2011-04-27 Thread Endi Sukma Dewata
On 4/26/2011 8:23 PM, Adam Young wrote: The widget base class has been modified to validate integer value if the type is specified in the metadata. This is used to validate entitlement quantity. Logic looks good. I'd like to make the validator an external object, and have the builder select

Re: [Freeipa-devel] [PATCH] 049 IPA replica is not started after the reboot

2011-04-27 Thread Simo Sorce
On Tue, 2011-04-26 at 10:41 +0200, Martin Kosek wrote: https://fedorahosted.org/freeipa/ticket/1191 ACK! Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 051 Improve Directory Service open port checker

2011-04-27 Thread Simo Sorce
On Wed, 2011-04-27 at 12:43 +0200, Martin Kosek wrote: Wait for DS ports to open after _every_ DS service restart. Several restarts were missed by the current open port checker implementation. https://fedorahosted.org/freeipa/ticket/1182 Ack Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [Freeipa-devel] [PATCH] 052 Log temporary files in ipa-client-install

2011-04-27 Thread Simo Sorce
On Wed, 2011-04-27 at 13:29 +0200, Martin Kosek wrote: This patch will help investigating issues like in ticket 1100 resolved by my patch 50. -- This patch adds logging of temporary files (Kerberos configuration, nsupdate commands) that may be very useful for debugging purposes.

Re: [Freeipa-devel] [PATCH] admiyo-0225-remove-jquery-cookie-library

2011-04-27 Thread Endi Sukma Dewata
On 4/26/2011 7:33 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 143 Entitlement quantity validation.

2011-04-27 Thread Dmitri Pal
On 04/27/2011 10:34 AM, Endi Sukma Dewata wrote: On 4/26/2011 8:23 PM, Adam Young wrote: The widget base class has been modified to validate integer value if the type is specified in the metadata. This is used to validate entitlement quantity. Logic looks good. I'd like to make the validator

Re: [Freeipa-devel] [PATCH] fixes #1193 init script related

2011-04-27 Thread Rob Crittenden
Simo Sorce wrote: On Tue, 2011-04-26 at 17:08 -0400, Rob Crittenden wrote: Simo Sorce wrote: With this patch we stop clearing the environment variables when running binaries allowing for env variables to be passed down by default. This fixes also the init script against Fedora 15 and systemd

[Freeipa-devel] [PATCH] 780 Handle principal not found errors when converting replication agreements

2011-04-27 Thread Rob Crittenden
There are times where one side or the other is missing its peers krbprincipalname when converting from simple to GSSAPI replication. Ticket 1188 should address the cause of this. This patch provides better information and handling should either side be missing. ticket 1044 rob

Re: [Freeipa-devel] [PATCH] fixes #1193 init script related

2011-04-27 Thread Simo Sorce
On Wed, 2011-04-27 at 10:59 -0400, Rob Crittenden wrote: Simo Sorce wrote: On Tue, 2011-04-26 at 17:08 -0400, Rob Crittenden wrote: Simo Sorce wrote: With this patch we stop clearing the environment variables when running binaries allowing for env variables to be passed down by default.

Re: [Freeipa-devel] [PATCH] 143 Entitlement quantity validation.

2011-04-27 Thread Endi Sukma Dewata
On 4/27/2011 10:43 AM, Adam Young wrote: The widget base class has been modified to validate integer value if the type is specified in the metadata. This is used to validate entitlement quantity. Logic looks good. I'd like to make the validator an external object, and have the builder select

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Adam Young
On 04/27/2011 10:24 AM, Martin Kosek wrote: On Wed, 2011-04-27 at 09:56 -0400, Adam Young wrote: On 04/27/2011 09:34 AM, Dmitri Pal wrote: On 04/27/2011 08:13 AM, Jan Cholasta wrote: On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40 +0200, Jan Cholasta wrote: On 26.4.2011

Re: [Freeipa-devel] [PATCH] fixes #1193 init script related

2011-04-27 Thread Rob Crittenden
Simo Sorce wrote: On Wed, 2011-04-27 at 10:59 -0400, Rob Crittenden wrote: Simo Sorce wrote: On Tue, 2011-04-26 at 17:08 -0400, Rob Crittenden wrote: Simo Sorce wrote: With this patch we stop clearing the environment variables when running binaries allowing for env variables to be passed

Re: [Freeipa-devel] [PATCH] 14 Run lint during each build

2011-04-27 Thread Dmitri Pal
On 04/27/2011 12:33 PM, Adam Young wrote: On 04/27/2011 10:24 AM, Martin Kosek wrote: On Wed, 2011-04-27 at 09:56 -0400, Adam Young wrote: On 04/27/2011 09:34 AM, Dmitri Pal wrote: On 04/27/2011 08:13 AM, Jan Cholasta wrote: On 27.4.2011 13:17, Martin Kosek wrote: On Wed, 2011-04-27 at 12:40

[Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

2011-04-27 Thread Adam Young
From f4f5a644ffcc31c417c6d81998b52e2b17c8f0e3 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 27 Apr 2011 13:32:14 -0400 Subject: [PATCH] Added a container for the facet --- install/ui/details.js |2 +- install/ui/entity.js | 24 ++-- 2 files

Re: [Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

2011-04-27 Thread Endi Sukma Dewata
On 4/27/2011 12:56 PM, Adam Young wrote: Currently we have this DOM structure: div id='user' class='entity-container' div class='entity-header' div class='entity-title'/ span class='action-controls'/ div class='entity-title'/ input id='pkey' type='hidden'/ span

Re: [Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

2011-04-27 Thread Adam Young
On 04/27/2011 09:09 PM, Adam Young wrote: On 04/27/2011 04:39 PM, Endi Sukma Dewata wrote: On 4/27/2011 12:56 PM, Adam Young wrote: Currently we have this DOM structure: div id='user' class='entity-container' div class='entity-header' div class='entity-title'/ span class='action-controls'/

Re: [Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

2011-04-27 Thread Endi Sukma Dewata
On 4/27/2011 8:09 PM, Adam Young wrote: div name='user' class='entity' div class='entity-header' div class='entity-title'/ div class='entity-controls'/ div class='entity-search'/ div class='entity-tabs'/ /div div class='entity-content' div name='search' class='facet' div class='facet-header'/