Re: [Freeipa-devel] [PATCH] 796 better detection of CA DS installation status

2011-06-13 Thread Martin Kosek
On Fri, 2011-06-10 at 15:33 -0400, Rob Crittenden wrote: Do better detection on status of CA DS instance when installing. The conditional used to determine if thd CA 389-ds instance was already configured was rather poor so it was possible to pass command-line arguments in to confuse it.

Re: [Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

2011-06-13 Thread Jan Cholasta
On 9.6.2011 14:50, Martin Kosek wrote: On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1283 https://fedorahosted.org/freeipa/ticket/1284 Honza Patch works fine, but I'd like to improve code quality a bit. Please don't call sys.exit() from

Re: [Freeipa-devel] [PATCH] 797 fix re-initializing replica binding using GSSAPI

2011-06-13 Thread Martin Kosek
On Fri, 2011-06-10 at 16:32 -0400, Rob Crittenden wrote: Support initializing memberof during replication re-init using GSSAPI The last step of a replication re-initiailization is to run the memberof task. The current function would only authenticate using simple auth to monitor the task

Re: [Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

2011-06-13 Thread Martin Kosek
On Mon, 2011-06-13 at 12:32 +0200, Jan Cholasta wrote: On 9.6.2011 14:50, Martin Kosek wrote: On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1283 https://fedorahosted.org/freeipa/ticket/1284 Honza Patch works fine, but I'd like to

Re: [Freeipa-devel] [PATCH] JSON-marshalling-list

2011-06-13 Thread Martin Kosek
On Fri, 2011-06-10 at 14:41 -0400, Adam Young wrote: Pushed under the one line rule Does this bug affect also the old IPA 2.0 WebUI? In that case I think this patch should be pushed to branch ipa-2-0 as well. Martin ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] JSON-marshalling-list

2011-06-13 Thread Adam Young
On 06/13/2011 07:14 AM, Martin Kosek wrote: On Fri, 2011-06-10 at 14:41 -0400, Adam Young wrote: Pushed under the one line rule Does this bug affect also the old IPA 2.0 WebUI? In that case I think this patch should be pushed to branch ipa-2-0 as well. Martin Haven't tested it.

Re: [Freeipa-devel] [PATCH] 173 Fixed resizing issues.

2011-06-13 Thread Adam Young
On 06/10/2011 03:21 PM, Endi Sukma Dewata wrote: On 6/9/2011 5:01 PM, Endi Sukma Dewata wrote: The UI has been modified to fix some resizing issues: Previously the size of scrollable facet content was roughly calculated using resize(). Now the size can be more accurately defined in CSS.

Re: [Freeipa-devel] [PATCH] 174 Added selectable option for table widget.

2011-06-13 Thread Adam Young
On 06/09/2011 07:03 PM, Endi Sukma Dewata wrote: A selectable option has been added to the table widget to show/hide the checkbox column for selecting table rows. By default it's set to true. The indirect association facet has been modified to hide the column because it is non-editable.

Re: [Freeipa-devel] [PATCH] 175 Entitlement status.

2011-06-13 Thread Adam Young
On 06/09/2011 07:36 PM, Endi Sukma Dewata wrote: A new facet has been added to show entitlement status and download the registration certificate. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 30 Display remaining external hosts when removing from sudorule

2011-06-13 Thread JR Aquino
This small 2 line patch addresses 2 bugs: https://fedorahosted.org/freeipa/ticket/1269 - (Remaining external hosts not displayed while removing one from a sudorule.) https://fedorahosted.org/freeipa/ticket/1270 - (Removed external host is displayed in the output when --all switch is used)

[Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-13 Thread Rob Crittenden
Indirect membership is calculated by looking at each member and pulling all the memberof out of it. What was missing was doing nested searches on any members in that member group. So if group2 was a member of group1 and group3 was a member of group2 we would miss group3 as being an indirect

[Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-13 Thread Rob Crittenden
Compare the configured interfaces with the supplied IP address and optional netmask to determine if the interface is available. Note the subtle change when comparing addresses. We have two object types, IPNetwork and IPAddress. We should only compare addresses when we don't have an IPNetwork

[Freeipa-devel] [PATCH] 800 remove extra call to version-update

2011-06-13 Thread Rob Crittenden
Remove extra call to version-update in spec file. We had reports that the build would fail here when running with many jobs. ticket https://fedorahosted.org/freeipa/ticket/1215 rob From ed2a8b25374fbb3d25ab4556e4bb323ef6ed4ef1 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-13 Thread Endi Sukma Dewata
On 6/13/2011 2:45 PM, Rob Crittenden wrote: Indirect membership is calculated by looking at each member and pulling all the memberof out of it. What was missing was doing nested searches on any members in that member group. So if group2 was a member of group1 and group3 was a member of group2

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-13 Thread Rob Crittenden
Endi Sukma Dewata wrote: On 6/13/2011 2:45 PM, Rob Crittenden wrote: Indirect membership is calculated by looking at each member and pulling all the memberof out of it. What was missing was doing nested searches on any members in that member group. So if group2 was a member of group1 and

[Freeipa-devel] [PATCH] 176 Fixed tab navigation.

2011-06-13 Thread Endi Sukma Dewata
The buttons were previously skipped during tab navigation because they do not have an href attribute. The IPA.button has been fixed to always provide an href attribute. Ticket #983 -- Endi S. Dewata From 13a15e6de3ef904f33fd3ba8611f5d9bebd656aa Mon Sep 17 00:00:00 2001 From: Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-13 Thread Endi Sukma Dewata
On 6/13/2011 6:00 PM, Rob Crittenden wrote: Endi Sukma Dewata wrote: On 6/13/2011 2:45 PM, Rob Crittenden wrote: Indirect membership is calculated by looking at each member and pulling all the memberof out of it. What was missing was doing nested searches on any members in that member group.

Re: [Freeipa-devel] [PATCH] 176 Fixed tab navigation.

2011-06-13 Thread Adam Young
On 06/13/2011 07:28 PM, Endi Sukma Dewata wrote: The buttons were previously skipped during tab navigation because they do not have an href attribute. The IPA.button has been fixed to always provide an href attribute. Ticket #983 ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-13 Thread Rob Crittenden
Endi Sukma Dewata wrote: On 6/13/2011 6:00 PM, Rob Crittenden wrote: Endi Sukma Dewata wrote: On 6/13/2011 2:45 PM, Rob Crittenden wrote: Indirect membership is calculated by looking at each member and pulling all the memberof out of it. What was missing was doing nested searches on any

Re: [Freeipa-devel] [PATCH] 798 Fix indirect member calculation

2011-06-13 Thread Simo Sorce
On Mon, 2011-06-13 at 23:28 -0400, Rob Crittenden wrote: Endi Sukma Dewata wrote: On 6/13/2011 6:00 PM, Rob Crittenden wrote: Endi Sukma Dewata wrote: On 6/13/2011 2:45 PM, Rob Crittenden wrote: Indirect membership is calculated by looking at each member and pulling all the memberof out