Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule

2011-06-16 Thread Martin Kosek
On Wed, 2011-06-15 at 17:29 +, JR Aquino wrote: On Jun 14, 2011, at 6:36 PM, Rob Crittenden wrote: Some of the sudorule commands were missing a message summary. ticket https://fedorahosted.org/freeipa/ticket/1255 rob

[Freeipa-devel] [PATCH] 083 Improve IP address handling in IPA option parser

2011-06-16 Thread Martin Kosek
Implements a way to pass match_local and parse_netmask parameters to IP option checker. Now, there is just one common option type ip with new optional attributes ip_local and ip_netmask which can be used to pass IP address validation parameters. https://fedorahosted.org/freeipa/ticket/1333 From

Re: [Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-16 Thread Martin Kosek
On Wed, 2011-06-15 at 14:29 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-06-14 at 08:56 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-06-13 at 16:41 -0400, Rob Crittenden wrote: Compare the configured interfaces with the supplied IP

Re: [Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-16 Thread Jan Cholasta
On 15.6.2011 20:29, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-06-14 at 08:56 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-06-13 at 16:41 -0400, Rob Crittenden wrote: Compare the configured interfaces with the supplied IP address and

Re: [Freeipa-devel] [PATCH] 22 Improve IP address handling in the host-add command

2011-06-16 Thread Jan Cholasta
On 14.6.2011 20:54, Simo Sorce wrote: On Tue, 2011-06-14 at 14:26 -0400, Rob Crittenden wrote: Jan Cholasta wrote: This patch enables the user to specify netmasks in the --ip-address option of host-add. They're used for proper DNS reverse zone and PTR record creation. Also the IP addresses are

Re: [Freeipa-devel] [PATCH] 779 Require an imported certificate's issuer to match our issuer

2011-06-16 Thread Jan Cholasta
On 14.6.2011 15:16, Rob Crittenden wrote: Jan Cholasta wrote: On 6.6.2011 21:25, Rob Crittenden wrote: Jan Cholasta wrote: On 26.4.2011 22:52, Rob Crittenden wrote: The goal is to not import foreign certificates. This caused a bunch of tests to fail because we had a hardcoded server

Re: [Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-16 Thread Rob Crittenden
Jan Cholasta wrote: On 15.6.2011 20:29, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-06-14 at 08:56 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-06-13 at 16:41 -0400, Rob Crittenden wrote: Compare the configured interfaces with the supplied

Re: [Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-16 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2011-06-15 at 14:29 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-06-14 at 08:56 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-06-13 at 16:41 -0400, Rob Crittenden wrote: Compare the configured interfaces

Re: [Freeipa-devel] [PATCH] 779 Require an imported certificate's issuer to match our issuer

2011-06-16 Thread Rob Crittenden
Jan Cholasta wrote: On 14.6.2011 15:16, Rob Crittenden wrote: Jan Cholasta wrote: On 6.6.2011 21:25, Rob Crittenden wrote: Jan Cholasta wrote: On 26.4.2011 22:52, Rob Crittenden wrote: The goal is to not import foreign certificates. This caused a bunch of tests to fail because we had a

Re: [Freeipa-devel] [PATCH] 779 Require an imported certificate's issuer to match our issuer

2011-06-16 Thread Rob Crittenden
Rob Crittenden wrote: Jan Cholasta wrote: On 14.6.2011 15:16, Rob Crittenden wrote: Jan Cholasta wrote: On 6.6.2011 21:25, Rob Crittenden wrote: Jan Cholasta wrote: On 26.4.2011 22:52, Rob Crittenden wrote: The goal is to not import foreign certificates. This caused a bunch of tests to

[Freeipa-devel] [PATCH] 181 Fixed self-service links.

2011-06-16 Thread Endi Sukma Dewata
In self-service mode the user's association facets have been modified such that the entries are not linked since the only available entity is the user entity. A 'link' parameter has been added to IPA.association_facet and IPA.column to control whether to link the entries. The link_handler()

Re: [Freeipa-devel] [PATCH] 779 Require an imported certificate's issuer to match our issuer

2011-06-16 Thread Jan Cholasta
On 16.6.2011 15:12, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 14.6.2011 15:16, Rob Crittenden wrote: Jan Cholasta wrote: On 6.6.2011 21:25, Rob Crittenden wrote: Jan Cholasta wrote: On 26.4.2011 22:52, Rob Crittenden wrote: The goal is to not import foreign

Re: [Freeipa-devel] [PATCH] 29 Raise DuplicateEntry Error when adding a duplicate sudo option

2011-06-16 Thread Rob Crittenden
JR Aquino wrote: On Jun 15, 2011, at 8:03 AM, Rob Crittenden wrote: A minor issue and a question. The minor issue is you changed a couple of options from optional to mandatory, which is fine, but we need to bump up the minor version in VERSION (older clients otherwise could not send the

Re: [Freeipa-devel] [PATCH] 179 Fixed paging for indirect members.

2011-06-16 Thread Adam Young
On 06/15/2011 06:10 PM, Endi Sukma Dewata wrote: Since ticket #1273 has been fixed, the indirect members can be shown using the regular association facet which supports paging. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 804 slight perf improvement

2011-06-16 Thread Rob Crittenden
This patch adds the production mode test to a few more places in the code. The speed increase is slight, a few hundred ms in my tests, but every little bit helps. ticket 1023 rob From 3eae1ef4f31a4ec5d1f9e16b2c9bc06f8ea41cf8 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com

Re: [Freeipa-devel] [PATCH] 180 Renamed associate.js to association.js.

2011-06-16 Thread Adam Young
On 06/15/2011 06:24 PM, Endi Sukma Dewata wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK. Pushed to master ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH] 181 Fixed self-service links.

2011-06-16 Thread Adam Young
On 06/16/2011 09:55 AM, Endi Sukma Dewata wrote: In self-service mode the user's association facets have been modified such that the entries are not linked since the only available entity is the user entity. A 'link' parameter has been added to IPA.association_facet and IPA.column to control

Re: [Freeipa-devel] [PATCH] 799 The IP address provided to ipa-server-install must be local

2011-06-16 Thread Martin Kosek
On Thu, 2011-06-16 at 09:07 -0400, Rob Crittenden wrote: I think this is still not right. When you let match_local default to False, --ip-address option in ipa-server-install is checked with match_local=False and thus the check required by BZ isn't made. Yes but it is checked again later.

[Freeipa-devel] [PATCH] 0238-test-for-dirty

2011-06-16 Thread Adam Young
From 76786348d9b0cf8fc5b0760a1ce4053fdf60c73e Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Thu, 16 Jun 2011 12:44:47 -0400 Subject: [PATCH] test for dirty instead of always setting dirty, we do the original test, and then set the flag and show the link.

Re: [Freeipa-devel] [PATCH] 0238-test-for-dirty

2011-06-16 Thread Endi Sukma Dewata
On 6/16/2011 11:46 AM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 29 Raise DuplicateEntry Error when adding a duplicate sudo option

2011-06-16 Thread JR Aquino
On Jun 16, 2011, at 8:01 AM, Rob Crittenden wrote: JR Aquino wrote: On Jun 15, 2011, at 8:03 AM, Rob Crittenden wrote: A minor issue and a question. The minor issue is you changed a couple of options from optional to mandatory, which is fine, but we need to bump up the minor version in

[Freeipa-devel] [PATCH] 0239-test-dirty-multivalue

2011-06-16 Thread Adam Young
From 4c22666ff142eaf86658b8df8f73797c371e2b5d Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Thu, 16 Jun 2011 15:24:48 -0400 Subject: [PATCH] test dirty multivalue test the multivalue widgets for changes before showing the undo link.

[Freeipa-devel] 32 Don't add empty tuple to entry_attrs['externalhost']

2011-06-16 Thread JR Aquino
https://fedorahosted.org/freeipa/ticket/1339 binniSici8OHk.bin Description: freeipa-jraquino-0032-Dont-add-empty-tuple-to-entry_attrs-externalhost.patch ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH]0240-test-dirty-onchange

2011-06-16 Thread Adam Young
From 472d1828957795b60df0d409ba29b1755fb921d5 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Thu, 16 Jun 2011 15:37:27 -0400 Subject: [PATCH] test dirty onchange instead of blindly setting dirty, check if the filed has a different value than it originally did.

Re: [Freeipa-devel] [PATCH] 0239-test-dirty-multivalue

2011-06-16 Thread Endi Sukma Dewata
On 6/16/2011 2:26 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH]0240-test-dirty-onchange

2011-06-16 Thread Endi Sukma Dewata
On 6/16/2011 2:39 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 182 Merged direct and indirect association facets

2011-06-16 Thread Endi Sukma Dewata
The direct and indirect associations are now displayed in the same facet. The type of association to be displayed can be selected using radio buttons. Ticket #1338 -- Endi S. Dewata From 8e667ca1c43fc2b766027d94b48bfc7b3b00a095 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com

Re: [Freeipa-devel] [PATCH] 182 Merged direct and indirect association facets

2011-06-16 Thread Adam Young
On 06/16/2011 07:25 PM, Endi Sukma Dewata wrote: The direct and indirect associations are now displayed in the same facet. The type of association to be displayed can be selected using radio buttons. Ticket #1338 ___ Freeipa-devel mailing list