Re: [Freeipa-devel] [PATCH] 241 Fixed broken links in ipa_error.css and ipa_migration.css.

2011-08-11 Thread Petr Vobornik
On 08/10/2011 04:21 AM, Endi Sukma Dewata wrote: Some of the images that were previously deleted are actually needed by ipa_error.css and ipa_migration.css, so they have been restored. Ticket #1564 ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] [WIP] 108 Fix client enrollment

2011-08-11 Thread Martin Kosek
This is a first shot for client enrollment fix. I had to pull the new version of xmlrpc-c from koji as it is not in updates-testing repo yet: http://koji.fedoraproject.org/koji/buildinfo?buildID=257947 Fixed curl package is already in stable repos. Unfortunately, it seems that credentials are

Re: [Freeipa-devel] [PATCH] [WIP] 108 Fix client enrollment

2011-08-11 Thread Martin Kosek
On Thu, 2011-08-11 at 13:07 +0300, Alexander Bokovoy wrote: On 11.08.2011 12:19, Martin Kosek wrote: This is a first shot for client enrollment fix. I had to pull the new version of xmlrpc-c from koji as it is not in updates-testing repo yet:

Re: [Freeipa-devel] [PATCH] [WIP] 108 Fix client enrollment

2011-08-11 Thread Alexander Bokovoy
On 11.08.2011 14:59, Martin Kosek wrote: On Thu, 2011-08-11 at 13:07 +0300, Alexander Bokovoy wrote: On 11.08.2011 12:19, Martin Kosek wrote: This is a first shot for client enrollment fix. I had to pull the new version of xmlrpc-c from koji as it is not in updates-testing repo yet:

[Freeipa-devel] [PATCH] 109 Update 389-ds-base version

2011-08-11 Thread Martin Kosek
The patch is applicable on top of my patch 108. --- Bump minimal 389-ds-base version in spec file to get in recent Directory Server bug fixes. https://fedorahosted.org/freeipa/ticket/1513 https://fedorahosted.org/freeipa/ticket/1525 https://fedorahosted.org/freeipa/ticket/1552 From

Re: [Freeipa-devel] [PATCH] 109 Update 389-ds-base version

2011-08-11 Thread Alexander Bokovoy
On 11.08.2011 15:07, Martin Kosek wrote: The patch is applicable on top of my patch 108. --- Bump minimal 389-ds-base version in spec file to get in recent Directory Server bug fixes. https://fedorahosted.org/freeipa/ticket/1513 https://fedorahosted.org/freeipa/ticket/1525

Re: [Freeipa-devel] [PATCH] 109 Update 389-ds-base version

2011-08-11 Thread Simo Sorce
On Thu, 2011-08-11 at 14:07 +0200, Martin Kosek wrote: The patch is applicable on top of my patch 108. Shouldn't we also have a requires on libcurl and xmlrpc-c = the version with the fixes ? Simo. -- Simo Sorce * Red Hat, Inc * New York ___

Re: [Freeipa-devel] [PATCH] 109 Update 389-ds-base version

2011-08-11 Thread Alexander Bokovoy
On 11.08.2011 15:46, Simo Sorce wrote: On Thu, 2011-08-11 at 14:07 +0200, Martin Kosek wrote: The patch is applicable on top of my patch 108. Shouldn't we also have a requires on libcurl and xmlrpc-c = the version with the fixes ? These are in patch 108 already. -- / Alexander Bokovoy

Re: [Freeipa-devel] [PATCH] 109 Update 389-ds-base version

2011-08-11 Thread Martin Kosek
On Thu, 2011-08-11 at 08:46 -0400, Simo Sorce wrote: On Thu, 2011-08-11 at 14:07 +0200, Martin Kosek wrote: The patch is applicable on top of my patch 108. Shouldn't we also have a requires on libcurl and xmlrpc-c = the version with the fixes ? Simo. We do. Please check my patch 108.

Re: [Freeipa-devel] [PATCH] 109 Update 389-ds-base version

2011-08-11 Thread Simo Sorce
On Thu, 2011-08-11 at 15:12 +0200, Martin Kosek wrote: On Thu, 2011-08-11 at 08:46 -0400, Simo Sorce wrote: On Thu, 2011-08-11 at 14:07 +0200, Martin Kosek wrote: The patch is applicable on top of my patch 108. Shouldn't we also have a requires on libcurl and xmlrpc-c = the version

[Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-11 Thread Petr Vobornik
[PATCH] error dialog for batch command https://fedorahosted.org/freeipa/ticket/1597 https://fedorahosted.org/freeipa/ticket/1592 Added option to show multiple errors in error dialog. Notes: - also covering '[ipa webui] Does not return appropriate error when deleting an external host but

Re: [Freeipa-devel] [PATCH] 241 Fixed broken links in ipa_error.css and ipa_migration.css.

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 3:53 AM, Petr Vobornik wrote: ACK I don't like that there is no pattern in image file naming. Sometimes it uses dashes, sometimes underscores. Some file names are capitalized. But this isn't the subject of this patch (ticket). Yes, it's an existing issue. I opened a new ticket

[Freeipa-devel] [PATCH] 110 Update pki-ca version

2011-08-11 Thread Martin Kosek
Bump minimal pki-ca version in spec file to get fix for ipa cert-request command. https://fedorahosted.org/freeipa/ticket/1578 From 5175751b910ad16b69ff600f35c7dd067b00326d Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Thu, 11 Aug 2011 17:54:41 +0200 Subject: [PATCH] Update

Re: [Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 9:01 AM, Petr Vobornik wrote: [PATCH] error dialog for batch command https://fedorahosted.org/freeipa/ticket/1597 https://fedorahosted.org/freeipa/ticket/1592 Added option to show multiple errors in error dialog. Notes: - also covering '[ipa webui] Does not return appropriate

Re: [Freeipa-devel] [PATCH] 110 Update pki-ca version

2011-08-11 Thread Martin Kosek
Just a note - applies on top of 108 and 109. When all these new packages are in updates-testing repo, I will push the patches upstream. A hint how to test this: 1) Install newest pki-ca from koji 2) run ./make-testcert - it should succeed Martin On Thu, 2011-08-11 at 18:02 +0200, Martin Kosek

Re: [Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 11:03 AM, Endi Sukma Dewata wrote: Some issues: 1. I think by default all batch commands should use this feature. The batch command is used for various purposes, not just for deletion. Consider this scenario: First, find a way to log in simultaneously using different accounts. You

[Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-11 Thread Endi Sukma Dewata
The dialog box for resetting user password has been modified to use the standard layout. -- Endi S. Dewata From d1c3958f1f0e5a2b5cdc3a45e03bcf5c009a2268 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Wed, 10 Aug 2011 22:47:39 -0500 Subject: [PATCH] Removed custom layout

[Freeipa-devel] [PATCH] 243 Fixed problem clicking 3rd level tabs.

2011-08-11 Thread Endi Sukma Dewata
The 3rd level tabs were partially covered by the content panel, so only the top portion can be clicked. The content panel has been repositioned to avoid the problem. Pushed under one-liner/trivial rule. -- Endi S. Dewata From 7f18bd82c86867d5cc1e3af607a2ba76177402e3 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH 36/36] ticket 1600 - convert unittests to use DN objects

2011-08-11 Thread John Dennis
On 08/10/2011 09:41 AM, Alexander Bokovoy wrote: *Huge* work, very appreciated! It is much cleaner to see now what we are actually expecting in a structured way. Thank you. There are plenty more similar fixes coming to a review near you soon :-) Unrelated comment: There are few place where

Re: [Freeipa-devel] [PATCH] [WIP] 108 Fix client enrollment

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 7:06 AM, Alexander Bokovoy wrote: On 11.08.2011 14:59, Martin Kosek wrote: Thanks, that was the problem. I wonder how I missed it. Attaching the updated patch, client enrollment on F-15 works. ACK. Should we wait until xmlrpc-c flies into F15 updates? Pushed to master. -- Endi

Re: [Freeipa-devel] [PATCH] 109 Update 389-ds-base version

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 7:12 AM, Alexander Bokovoy wrote: On 11.08.2011 15:07, Martin Kosek wrote: The patch is applicable on top of my patch 108. ACK as well. This is straight-forward. Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH 37/37] Transifex translation adjustment

2011-08-11 Thread John Dennis
Self NAK'ing. There was no reason to pull in new translations at this juncture. Plus the new po files didn't have correct plural-forms and only the translators know what they should be. This patch has been superseded by [PATCH 38/38] transifex translation adjustment -- John Dennis

Re: [Freeipa-devel] [PATCH 38/38] transifex translation adjustment

2011-08-11 Thread Adam Young
On 08/11/2011 08:00 PM, John Dennis wrote: Pull the new translations for Spanish (es) and Ukrainian (uk) Update the LINGUAS file to add comment showing the friendly name for the language abbreviation. The make target msg-stats which produces a report about the state of the translations no

Re: [Freeipa-devel] [PATCH 38/38] transifex translation adjustment

2011-08-11 Thread Adam Young
On 08/11/2011 09:21 PM, Adam Young wrote: On 08/11/2011 08:00 PM, John Dennis wrote: Pull the new translations for Spanish (es) and Ukrainian (uk) Update the LINGUAS file to add comment showing the friendly name for the language abbreviation. The make target msg-stats which produces a report

Re: [Freeipa-devel] [PATCH 38/38] transifex translation adjustment

2011-08-11 Thread Alexander Bokovoy
On 12.08.2011 03:00, John Dennis wrote: Pull the new translations for Spanish (es) and Ukrainian (uk) Update the LINGUAS file to add comment showing the friendly name for the language abbreviation. The make target msg-stats which produces a report about the state of the translations no