Re: [Freeipa-devel] [PATCH] 310 Updated sample data.

2011-11-11 Thread Petr Vobornik
On 11/09/2011 09:28 PM, Endi Sukma Dewata wrote: New sample data files have been added for search facet paging. Unused files have been removed. The names used in the files have been updated for consistency. Ticket #981 ACK -- Petr Vobornik ___

Re: [Freeipa-devel] [PATCH] 311 Added paging on search facet.

2011-11-11 Thread Petr Vobornik
On 11/09/2011 09:28 PM, Endi Sukma Dewata wrote: The search facet has been modified to support paging on most entities using the --pkey-only option to get the primary keys and a batch command to get the complete records. Paging on DNS records is not supported because a record may appear as

Re: [Freeipa-devel] Ticket #1976 - Tab color groups

2011-11-11 Thread Petr Vobornik
On 11/10/2011 10:23 PM, Endi Sukma Dewata wrote: On 11/10/2011 2:00 PM, Kyle Baker wrote: Attached a mockup which shows each tab in a color set. This offers a quick visual reference as to the tab groupings. The colored tab looks good. What are the color settings? Suppose we have more than 3

[Freeipa-devel] [PATCH] ipa-client-install with --no-sssd option should check for nss_ldap

2011-11-11 Thread Ondrej Hamada
https://fedorahosted.org/freeipa/ticket/2063 In order to check presence of nss_ldap when installing client with '--no-sssd' option there was added code into ipa-client-install. Check is base on existence of nss_ldap configuration files. This configuration could be in 'etc/ldap.conf',

Re: [Freeipa-devel] [PATCH] ipa-client-install with --no-sssd option should check for nss_ldap

2011-11-11 Thread Rob Crittenden
Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2063 In order to check presence of nss_ldap when installing client with '--no-sssd' option there was added code into ipa-client-install. Check is base on existence of nss_ldap configuration files. This configuration could be in

[Freeipa-devel] [PATCH] 166+167 Zonemgr improvements

2011-11-11 Thread Martin Kosek
There are 2 patches improving our zone zonemgr: 1) ipa-server-install --zonemgr option validation and normalization + the same thing in ipa dnszone-add/mod --admin-email. They now allow and correctly process '.' in a local-part of the zonemgr e-mail (it is encoded as '\.'. How to test:

Re: [Freeipa-devel] [PATCH] ipa-client-install with --no-sssd option should check for nss_ldap

2011-11-11 Thread Alexander Bokovoy
On Fri, 11 Nov 2011, Rob Crittenden wrote: Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2063 In order to check presence of nss_ldap when installing client with '--no-sssd' option there was added code into ipa-client-install. Check is base on existence of nss_ldap

[Freeipa-devel] [PATCH] 904 two more buildrequires

2011-11-11 Thread Rob Crittenden
We need two more buildrequires, libtalloc-devel and libtevent-devel. rob From cf1c05582fd51c9ec1d582e3276d8c641bff1d4b Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Fri, 11 Nov 2011 10:08:53 -0500 Subject: [PATCH] Add libtalloc-devel and libtevent-devel as

Re: [Freeipa-devel] [PATCH] 904 two more buildrequires

2011-11-11 Thread Alexander Bokovoy
On Fri, 11 Nov 2011, Rob Crittenden wrote: We need two more buildrequires, libtalloc-devel and libtevent-devel. ACK but do we need to specify versioning? Do we depend on specific features? I remember there was issue with upgrade of libtalloc/libtevent in Fedora that blocked using samba4.

[Freeipa-devel] [PATCH] fix copy/paste

2011-11-11 Thread Jérôme Fenal
Hi all, A trivial patch found during French translation : diff --git a/ipalib/plugins/aci.py b/ipalib/plugins/aci.py index fc5582d..429ae6e 100644 --- a/ipalib/plugins/aci.py +++ b/ipalib/plugins/aci.py @@ -543,7 +543,7 @@ class aci_del(crud.Delete): Execute the aci-delete

Re: [Freeipa-devel] [PATCH] 904 two more buildrequires

2011-11-11 Thread Simo Sorce
On Fri, 2011-11-11 at 10:10 -0500, Rob Crittenden wrote: We need two more buildrequires, libtalloc-devel and libtevent-devel. They should be dragged in from samba-4.0-devel If it doesn;t do so it is a samba-4.0 packaging bug. We should not explicitly add the requires to freeipa.spec I think.

Re: [Freeipa-devel] [PATCH] fix copy/paste

2011-11-11 Thread Alexander Bokovoy
On Fri, 11 Nov 2011, Jérôme Fenal wrote: A trivial patch found during French translation : diff --git a/ipalib/plugins/aci.py b/ipalib/plugins/aci.py index fc5582d..429ae6e 100644 --- a/ipalib/plugins/aci.py +++ b/ipalib/plugins/aci.py @@ -543,7 +543,7 @@ class aci_del(crud.Delete):

Re: [Freeipa-devel] [PATCH] 904 two more buildrequires

2011-11-11 Thread Rob Crittenden
Simo Sorce wrote: On Fri, 2011-11-11 at 17:28 +0200, Alexander Bokovoy wrote: On Fri, 11 Nov 2011, Rob Crittenden wrote: We need two more buildrequires, libtalloc-devel and libtevent-devel. ACK but do we need to specify versioning? Do we depend on specific features? I remember there was issue

Re: [Freeipa-devel] [PATCH] 310 Updated sample data.

2011-11-11 Thread Endi Sukma Dewata
On 11/11/2011 4:02 AM, Petr Vobornik wrote: ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 311 Added paging on search facet.

2011-11-11 Thread Endi Sukma Dewata
On 11/11/2011 4:07 AM, Petr Vobornik wrote: On facets where paging is not enabled is still shown pager (because page_length property is set). This can be misleading. As discussed, this is highly subjective. Ultimately this will be decided by UXD. Otherwise it is OK. I pushed it to

Re: [Freeipa-devel] [PATCH] ipa-client-install with --no-sssd option should check for nss_ldap

2011-11-11 Thread Ondrej Hamada
On 11/11/2011 03:25 PM, Alexander Bokovoy wrote: On Fri, 11 Nov 2011, Rob Crittenden wrote: Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2063 In order to check presence of nss_ldap when installing client with '--no-sssd' option there was added code into ipa-client-install.

Re: [Freeipa-devel] [PATCH] 120 Improve DNS record data validation

2011-11-11 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2011-11-04 at 16:53 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-10-19 at 15:38 -0400, Adam Young wrote: On 10/19/2011 08:15 AM, Martin Kosek wrote: On Wed, 2011-09-07 at 15:18 +0200, Martin Kosek wrote: On Wed, 2011-09-07 at 15:05 +0200, Martin

Re: [Freeipa-devel] [PATCH] ipa-client-install with --no-sssd option should check for nss_ldap

2011-11-11 Thread Alexander Bokovoy
On Fri, 11 Nov 2011, Ondrej Hamada wrote: I think we should check for nslcd.conf as well and report that neither nss-ldap nor nss-pam-ldapd are installed. We have already code in configure_ldap_config() and configure_nslcd_conf that checks all these different files and after configuration

Re: [Freeipa-devel] [PATCH] ipa-client-install with --no-sssd option should check for nss_ldap

2011-11-11 Thread Dmitri Pal
On 11/11/2011 11:35 AM, Ondrej Hamada wrote: On 11/11/2011 03:25 PM, Alexander Bokovoy wrote: On Fri, 11 Nov 2011, Rob Crittenden wrote: Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2063 In order to check presence of nss_ldap when installing client with '--no-sssd' option

Re: [Freeipa-devel] [PATCH] fix copy/paste

2011-11-11 Thread Rob Crittenden
Alexander Bokovoy wrote: On Fri, 11 Nov 2011, Jérôme Fenal wrote: A trivial patch found during French translation : diff --git a/ipalib/plugins/aci.py b/ipalib/plugins/aci.py index fc5582d..429ae6e 100644 --- a/ipalib/plugins/aci.py +++ b/ipalib/plugins/aci.py @@ -543,7 +543,7 @@ class

Re: [Freeipa-devel] [PATCH] the 'Keytab:' field in ipa user-show output is misleading

2011-11-11 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2011-11-10 at 14:01 +0100, Ondrej Hamada wrote: On 11/10/2011 10:30 AM, Martin Kosek wrote: On Tue, 2011-11-08 at 20:41 +0100, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/1961 The 'Keytab' filed in output of all 'user-*' commands was changed to

Re: [Freeipa-devel] [PATCH] 165 Polish ipa config help

2011-11-11 Thread Rob Crittenden
Martin Kosek wrote: Remove config-mod options help from config module help to keep the option doc on one place and without unnecessary redundancy. The new format is more consistent with the rest of the plugins. Also fix several inconsistencies in the labels/doc, including: - using abbreviation

Re: [Freeipa-devel] [PATCH] 162 Fix coverity issues in client CLI tools

2011-11-11 Thread Rob Crittenden
Martin Kosek wrote: This patch fixes 2 coverity issues: * ipa-client/config.c: CID 11090: Resource leak * ipa-client/ipa-getkeytab.c: CID 11018: Unchecked return value https://fedorahosted.org/freeipa/ticket/2035 You don't need to test a variable before you free it, so you can just call

Re: [Freeipa-devel] [PATCH] 160 Hosts file not updated when IP is passed as option

2011-11-11 Thread Rob Crittenden
Martin Kosek wrote: When an IPA server with unresolvable hostname is being installed, a hostname record must be inserted to /etc/hosts or the installation will fail. However, it is not inserted when IP address is passed as an option (--ip-address) and not interactively. This patch fixes this so

Re: [Freeipa-devel] [PATCH] 55 Parse comma-separated lists of values in all parameter types

2011-11-11 Thread Rob Crittenden
Jan Cholasta wrote: Dne 4.11.2011 22:25, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 24.10.2011 17:42, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 20.10.2011 13:20, Jan Cholasta napsal(a): Parse comma-separated lists of values in all parameter types. This can enabled for a

Re: [Freeipa-devel] Ticket #1976 - Tab color groups

2011-11-11 Thread Endi Sukma Dewata
On 11/11/2011 6:23 AM, Petr Vobornik wrote: The problem might be changed into two separate questions: * How to order the facet groups? The order can be set in the entity definition using facet_groups(). It's been used in ACI, DNS, and automount because the default ordering doesn't produce