[Freeipa-devel] [PATCH] 0009 - Internationalize HBAC rule all category exceptions

2012-02-14 Thread Petr Viktorin
This patch wraps exception messages in _() https://fedorahosted.org/freeipa/ticket/2267 -- PetrĀ³ From ef61ff93af13e46400e9bff22586b6f9e0d0a63a Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 10 Feb 2012 05:27:24 -0500 Subject: [PATCH] Internationalize HBAC rule all

Re: [Freeipa-devel] [PATCH] 0009 - Internationalize HBAC rule all category exceptions

2012-02-14 Thread Alexander Bokovoy
On Tue, 14 Feb 2012, Petr Viktorin wrote: This patch wraps exception messages in _() https://fedorahosted.org/freeipa/ticket/2267 ACK. I was looking at hbactest and there are also some non-internationalized messages returned. Maybe you could combine them together with a slightly updated

Re: [Freeipa-devel] [PATCH] 195-199 New DNS features

2012-02-14 Thread Simo Sorce
On Tue, 2012-02-14 at 12:09 +0100, Martin Kosek wrote: A new version of bind-dyndb-ldap has been released, sending fixed patches with the following major changes: - Since bind-dyndb-ldap supports only idnsForwarders global option at this time, all other global options were removed from the

[Freeipa-devel] Fix build issues in master with krb5 1.10

2012-02-14 Thread Simo Sorce
The following 2 patches are need to have a functioning kdc. Without them building against krb5 1.10 produces a ipadb.so module that fails to load due to missing symbols leaving kadmin.local and krb5kdc without a database. The reason this happens is that during development of this code MIT had

[Freeipa-devel] Implement audit_as kdb layer function

2012-02-14 Thread Simo Sorce
Without this function the audit counters (krbLastFailedAuth, krbLastSuccessfulAuth, krbLoginFailedCount) are not updated causing a regression. This function updates the counters unconditionally upon successful/failed authentication (only if pre-auth is used which is the default in FreeIPA). A

[Freeipa-devel] [PATCH] 479 optimize modify principal operations

2012-02-14 Thread Simo Sorce
We were unconditionally searching the LDAP database to find the principal on modification. By using the stored entry_dn when available we avoid a costly round-trip to the LDAP server just to save back some modified attributes. This is an important performance improvement for the KDC given now we

Re: [Freeipa-devel] [PATCH] 077 Redirection to PTR records from A, AAAA records

2012-02-14 Thread Petr Vobornik
On 02/14/2012 08:11 AM, Endi Sukma Dewata wrote: On 2/9/2012 7:57 AM, Petr Vobornik wrote: Address column in A, DNS records was extended by redirection capabilities. Redirection dialog is shown after a click on a value. Dialog does following steps: 1) fetch all dns zones 2) find most

[Freeipa-devel] [PATCH] 480 Do not store LastPwdChange unless it really changed

2012-02-14 Thread Simo Sorce
Due to an idiosyncrasy of kadmin, the right flag to indicate krbLastPwdChange is changed is not set. The previous check ended up always saving the data in all cases because the data was always present. Restrict it to store a password change when there is actually new key material. This prevents

Re: [Freeipa-devel] [PATCH] 195-199 New DNS features

2012-02-14 Thread Rob Crittenden
Simo Sorce wrote: On Tue, 2012-02-14 at 12:09 +0100, Martin Kosek wrote: A new version of bind-dyndb-ldap has been released, sending fixed patches with the following major changes: - Since bind-dyndb-ldap supports only idnsForwarders global option at this time, all other global options were

Re: [Freeipa-devel] [PATCH] 195-199 New DNS features

2012-02-14 Thread Martin Kosek
On Tue, 2012-02-14 at 09:10 -0500, Rob Crittenden wrote: Simo Sorce wrote: On Tue, 2012-02-14 at 12:09 +0100, Martin Kosek wrote: A new version of bind-dyndb-ldap has been released, sending fixed patches with the following major changes: - Since bind-dyndb-ldap supports only

Re: [Freeipa-devel] [PATCH] 0009 - Internationalize HBAC rule all category exceptions

2012-02-14 Thread Petr Viktorin
On 02/14/2012 10:49 AM, Alexander Bokovoy wrote: On Tue, 14 Feb 2012, Petr Viktorin wrote: This patch wraps exception messages in _() https://fedorahosted.org/freeipa/ticket/2267 ACK. I was looking at hbactest and there are also some non-internationalized messages returned. Maybe you could

Re: [Freeipa-devel] [PATCH] 078 Fixed entity link disabling

2012-02-14 Thread Endi Sukma Dewata
On 2/9/2012 7:59 AM, Petr Vobornik wrote: Problem: Entity link (eg: to hosts in dns record or to dns record in host) is not changing its state when linked record doesn't exist. The link can remain wrongly enabled from previous state. Fixed: The link is disabled when target doesn't exist.

Re: [Freeipa-devel] [PATCH] 079 Removed question marks from field labels

2012-02-14 Thread Endi Sukma Dewata
On 2/10/2012 11:35 AM, Petr Vobornik wrote: In user group adder dialog, the Is this a POSIX group? was replaced with POSIX group. In host search facet, the Enrolled? was replaced with Enrolled. https://fedorahosted.org/freeipa/ticket/2353 ACK. Pushed to master and ipa-2-2. -- Endi S. Dewata

Re: [Freeipa-devel] Implement audit_as kdb layer function

2012-02-14 Thread Rob Crittenden
Simo Sorce wrote: Without this function the audit counters (krbLastFailedAuth, krbLastSuccessfulAuth, krbLoginFailedCount) are not updated causing a regression. This function updates the counters unconditionally upon successful/failed authentication (only if pre-auth is used which is the

Re: [Freeipa-devel] [PATCH] 077 Redirection to PTR records from A, AAAA records

2012-02-14 Thread Endi Sukma Dewata
On 2/14/2012 8:01 AM, Petr Vobornik wrote: 1. After redirection the breadcrumb doesn't link to the correct zone. Try this: a) Open the details page of an A record. b) Click the IP address (create the PTR record if necessary), it will show the PTR record. c) Click the reverse zone in the

Re: [Freeipa-devel] [PATCH] 0009 - Internationalize HBAC rule all category exceptions

2012-02-14 Thread Alexander Bokovoy
On Tue, 14 Feb 2012, Petr Viktorin wrote: On 02/14/2012 10:49 AM, Alexander Bokovoy wrote: On Tue, 14 Feb 2012, Petr Viktorin wrote: This patch wraps exception messages in _() https://fedorahosted.org/freeipa/ticket/2267 ACK. I was looking at hbactest and there are also some

Re: [Freeipa-devel] [PATCH] 940 apply some validation to some classes only

2012-02-14 Thread Jan Cholasta
On 7.2.2012 20:25, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: Dne 7.2.2012 09:27, Martin Kosek napsal(a): On Mon, 2012-02-06 at 11:52 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-02-03 at 16:58 -0500, Rob Crittenden wrote: There is some validation that

Re: [Freeipa-devel] [PATCH] 940 apply some validation to some classes only

2012-02-14 Thread Jan Cholasta
On 14.2.2012 16:44, Jan Cholasta wrote: On 7.2.2012 20:25, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: Dne 7.2.2012 09:27, Martin Kosek napsal(a): On Mon, 2012-02-06 at 11:52 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-02-03 at 16:58 -0500, Rob

Re: [Freeipa-devel] [PATCH] 202 Add reverse DNS record when forward is created

2012-02-14 Thread Jan Cholasta
On 10.2.2012 16:42, Martin Kosek wrote: On Tue, 2012-02-07 at 16:26 +0100, Martin Kosek wrote: On Mon, 2012-02-06 at 15:56 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-01-30 at 11:52 -0500, Rob Crittenden wrote: Martin Kosek wrote: Adding reverse DNS record may be a time

Re: [Freeipa-devel] Implement audit_as kdb layer function

2012-02-14 Thread Simo Sorce
On Tue, 2012-02-14 at 10:22 -0500, Rob Crittenden wrote: Simo Sorce wrote: Without this function the audit counters (krbLastFailedAuth, krbLastSuccessfulAuth, krbLoginFailedCount) are not updated causing a regression. This function updates the counters unconditionally upon

Re: [Freeipa-devel] [PATCH] 202 Add reverse DNS record when forward is created

2012-02-14 Thread Martin Kosek
On Tue, 2012-02-14 at 16:52 +0100, Jan Cholasta wrote: On 10.2.2012 16:42, Martin Kosek wrote: On Tue, 2012-02-07 at 16:26 +0100, Martin Kosek wrote: On Mon, 2012-02-06 at 15:56 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-01-30 at 11:52 -0500, Rob Crittenden wrote:

Re: [Freeipa-devel] [PATCH 61] Cache authentication in session

2012-02-14 Thread Endi Sukma Dewata
On 2/9/2012 8:32 AM, John Dennis wrote: Currently when the UI is loaded for the first time it will execute an ipa_init operation which consists of: 1. Loading I18 messages. 2. Getting user info (whoami). 3. Loading environment variables. 4. Checking whether DNS is enabled. 5. Loading objects

Re: [Freeipa-devel] [PATCH] 0009 - Internationalize HBAC rule all category exceptions

2012-02-14 Thread Martin Kosek
On Tue, 2012-02-14 at 17:37 +0200, Alexander Bokovoy wrote: On Tue, 14 Feb 2012, Petr Viktorin wrote: On 02/14/2012 10:49 AM, Alexander Bokovoy wrote: On Tue, 14 Feb 2012, Petr Viktorin wrote: This patch wraps exception messages in _() https://fedorahosted.org/freeipa/ticket/2267

Re: [Freeipa-devel] [PATCHES] 59-65 SSH public key management

2012-02-14 Thread Martin Kosek
On Thu, 2012-02-09 at 18:18 +0100, Jan Cholasta wrote: On 8.2.2012 16:35, Rob Crittenden wrote: Jan Cholasta wrote: Patch 62: need a failsafe to remove CCACHE_FILE in case something goes wrong. I should note too that this won't work on platforms prior to Python 2.6 (RHEL-5 is one). This

Re: [Freeipa-devel] [PATCH] 947 fix synxtax in 30-s4u2proxy.update

2012-02-14 Thread Martin Kosek
On Mon, 2012-02-13 at 11:43 -0500, Rob Crittenden wrote: Remove quotes around a value in 30-s4u2proxy.update. The update was failing to apply. I also noticed that FQDN wasn't being set properly in all cases in sub_dict. This should fix it. rob This patch did not apply for me. I guess

Re: [Freeipa-devel] Implement audit_as kdb layer function

2012-02-14 Thread Rob Crittenden
Simo Sorce wrote: On Tue, 2012-02-14 at 10:22 -0500, Rob Crittenden wrote: Simo Sorce wrote: Without this function the audit counters (krbLastFailedAuth, krbLastSuccessfulAuth, krbLoginFailedCount) are not updated causing a regression. This function updates the counters unconditionally upon

Re: [Freeipa-devel] [PATCHES] 59-65 SSH public key management

2012-02-14 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2012-02-09 at 18:18 +0100, Jan Cholasta wrote: On 8.2.2012 16:35, Rob Crittenden wrote: Jan Cholasta wrote: Patch 62: need a failsafe to remove CCACHE_FILE in case something goes wrong. I should note too that this won't work on platforms prior to Python 2.6 (RHEL-5

Re: [Freeipa-devel] [PATCH] 947 fix synxtax in 30-s4u2proxy.update

2012-02-14 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2012-02-13 at 11:43 -0500, Rob Crittenden wrote: Remove quotes around a value in 30-s4u2proxy.update. The update was failing to apply. I also noticed that FQDN wasn't being set properly in all cases in sub_dict. This should fix it. rob This patch did not apply

Re: [Freeipa-devel] [PATCH] 940 apply some validation to some classes only

2012-02-14 Thread Rob Crittenden
Jan Cholasta wrote: On 14.2.2012 16:44, Jan Cholasta wrote: On 7.2.2012 20:25, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: Dne 7.2.2012 09:27, Martin Kosek napsal(a): On Mon, 2012-02-06 at 11:52 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-02-03 at

Re: [Freeipa-devel] [PATCHES] 59-65 SSH public key management

2012-02-14 Thread Martin Kosek
On Tue, 2012-02-14 at 15:33 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-02-09 at 18:18 +0100, Jan Cholasta wrote: On 8.2.2012 16:35, Rob Crittenden wrote: Jan Cholasta wrote: Patch 62: need a failsafe to remove CCACHE_FILE in case something goes wrong. I should note

Re: [Freeipa-devel] [PATCH] 944 upgrade files for selinuxusermap

2012-02-14 Thread Rob Crittenden
Rob Crittenden wrote: The update files were missing for SELinuxUserMap support, this adds them. Rebased patch rob freeipa-rcrit-944-2.selinux.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 944 upgrade files for selinuxusermap

2012-02-14 Thread Rob Crittenden
Rob Crittenden wrote: Rob Crittenden wrote: The update files were missing for SELinuxUserMap support, this adds them. Rebased patch rob Sorry, sent the wrong patch. Here is the right one. rob ___ Freeipa-devel mailing list

Re: [Freeipa-devel] Implement audit_as kdb layer function

2012-02-14 Thread Simo Sorce
On Tue, 2012-02-14 at 14:31 -0500, Rob Crittenden wrote: Simo Sorce wrote: On Tue, 2012-02-14 at 10:22 -0500, Rob Crittenden wrote: Simo Sorce wrote: Without this function the audit counters (krbLastFailedAuth, krbLastSuccessfulAuth, krbLoginFailedCount) are not updated causing a