Re: [Freeipa-devel] [PATCH 0038] Fix two memory leaks in ldap_query()

2012-07-23 Thread Adam Tkac
On Fri, Jul 20, 2012 at 02:28:09PM +0200, Petr Spacek wrote: Hello, this patch fixes two memory leaks in ldap_query(). Both memory leaks occurs after non-success queries. It effectively re-implements fix for ldap_query can incorrectly return ISC_R_SUCCESS even when failed:

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-23 Thread Petr Viktorin
On 07/20/2012 07:14 PM, John Dennis wrote: On 07/20/2012 12:28 PM, Petr Viktorin wrote: On 07/20/2012 05:39 PM, John Dennis wrote: Great I agree with everything you said. I'm happy to have the file list be derived from the directory contents. Are you planning on doing that in another patch?

Re: [Freeipa-devel] [PATCH 0038] Fix two memory leaks in ldap_query()

2012-07-23 Thread Petr Spacek
On 07/23/2012 12:03 PM, Adam Tkac wrote: On Fri, Jul 20, 2012 at 02:28:09PM +0200, Petr Spacek wrote: Hello, this patch fixes two memory leaks in ldap_query(). Both memory leaks occurs after non-success queries. It effectively re-implements fix for ldap_query can incorrectly return

[Freeipa-devel] [PATCH] 174 Fix autoscroll to top in tables in IE

2012-07-23 Thread Petr Vobornik
In IE when a window is small (horizontal scrollbar is displayed) click or keyboard input on various parts of UI makes search tables scroll to top. It prevents from selecting items in a table. This issue happens when using absolute positioned element with overflow style. It's a bug in IE. Two

[Freeipa-devel] slow response (was: 2.20 dirsrv memory usage)

2012-07-23 Thread John Dennis
Stephen provided Alexander and myself with debug output. I quickly wrote a little script to parse the output looking for the session timestamps, what commands were executed for each RPC, and computed the duration of the RPC. Note the timestamps only have 1 second resolution, something which

Re: [Freeipa-devel] slow response

2012-07-23 Thread John Dennis
Darn it. I just realized I did something really dumb. I posted material to a public list that should have been kept private. I'm even the one who asked Stephen to keep the information private. I offer Stephen my sincerest apology for being a complete idiot and I hope I didn't create any

Re: [Freeipa-devel] slow response

2012-07-23 Thread John Dennis
On 07/23/2012 01:23 PM, Stephen Ingram wrote: On Mon, Jul 23, 2012 at 9:37 AM, John Dennis jden...@redhat.com wrote: Stephen provided Alexander and myself with debug output. I quickly wrote a little script to parse the output looking for the session timestamps, what commands were executed for

Re: [Freeipa-devel] slow response

2012-07-23 Thread John Dennis
On 07/23/2012 12:37 PM, John Dennis wrote: Note the timestamps only have 1 second resolution, something which would be easy to fix, so bear that in mind when looking at the output of the script. This is partially as a note to myself, but also to others who want to test. The following patch

Re: [Freeipa-devel] [PATCH] 1033 renew CA subsystem certificates

2012-07-23 Thread Rob Crittenden
Rob Crittenden wrote: Andrew Wnuk wrote: On 07/16/2012 01:35 PM, Rob Crittenden wrote: Nalin Dahyabhai wrote: On Mon, Jul 16, 2012 at 09:23:24AM -0400, Rob Crittenden wrote: Use the new certmonger capability to be able to renew the dogtag subsystem certificates (audit, OCSP, etc). Are the

Re: [Freeipa-devel] [PATCH] 0056 Framework for admin/install tools, with ipa-ldap-updater

2012-07-23 Thread Rob Crittenden
John Dennis wrote: On 07/20/2012 12:34 PM, Petr Viktorin wrote: On 07/20/2012 05:59 PM, John Dennis wrote: A fair amount of the code in the framework is doing this now, but the install code was never cleaned up. That was left for another day, I guess that day is here. Updated. I also added

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-23 Thread John Dennis
On 07/23/2012 06:27 AM, Petr Viktorin wrote: On 07/20/2012 07:14 PM, John Dennis wrote: On 07/20/2012 12:28 PM, Petr Viktorin wrote: On 07/20/2012 05:39 PM, John Dennis wrote: Great I agree with everything you said. I'm happy to have the file list be derived from the directory contents. Are

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-23 Thread John Dennis
On 07/23/2012 06:27 AM, Petr Viktorin wrote: As a translator (for another project), I don't like Transifex and prefer to send good old Git pull requests. I understand a traditional workflow is hard to coordinate with others that use Transifex, but still I'd hate it if we became dependent on Tx.

Re: [Freeipa-devel] [PATCH] 173 IDs and names for dialogs

2012-07-23 Thread Endi Sukma Dewata
On 7/19/2012 8:07 AM, Petr Vobornik wrote: It's hard to detect if or which type of dialog is displayed because not all dialogs have IDs. On dialog open, it's id or name (if id is not set) is used for containing element id. Many of dialog types were missing id or name so name was added to each

Re: [Freeipa-devel] [PATCH] 174 Fix autoscroll to top in tables in IE

2012-07-23 Thread Endi Sukma Dewata
On 7/23/2012 9:05 AM, Petr Vobornik wrote: In IE when a window is small (horizontal scrollbar is displayed) click or keyboard input on various parts of UI makes search tables scroll to top. It prevents from selecting items in a table. This issue happens when using absolute positioned element