Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

On 23.10.2015 14:01, Milan Kubík wrote: On 10/20/2015 02:19 PM, Martin Basti wrote: NACK 1) I still see many hardcoded passwords in the code with change_principal(smime_user, "Secret123"): For now changed to module variable. 2) Also the 'alice' username can be extracted to module

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

Hi Martin, The updated version of the patch is attached. Please, see my comments below On 10/26/2015 06:48 PM, Martin Basti wrote: On 26.10.2015 08:59, Oleg Fayans wrote: On 10/23/2015 03:10 PM, Martin Basti wrote: On 23.10.2015 15:00, Oleg Fayans wrote: Hi Martin, Here comes the

Re: [Freeipa-devel] [PATCH 0335] Freeipa domain levels naming

On 27.10.2015 10:12, Petr Spacek wrote: On 23.10.2015 14:07, Petr Spacek wrote: On 23.10.2015 13:53, Martin Basti wrote: On 23.10.2015 13:53, Tomas Babej wrote: On 10/23/2015 01:51 PM, Martin Basti wrote: On 23.10.2015 13:49, Tomas Babej wrote: On 10/23/2015 12:49 PM, Martin Basti wrote:

Re: [Freeipa-devel] [PATCH 0327] KRA: fix check if CA is installed on replica

On 26.10.2015 10:35, Martin Babinsky wrote: On 10/23/2015 05:18 PM, Martin Basti wrote: On 23.10.2015 15:15, Martin Babinsky wrote: On 10/23/2015 03:12 PM, Martin Babinsky wrote: On 10/16/2015 12:41 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5345 Patch attached.

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached. Please, see my comments below My comments inline, I may be completely wrong in how the test suite work, so feel free to correct me. Martin On

Re: [Freeipa-devel] [PATCH 0335] Freeipa domain levels naming

On 23.10.2015 14:07, Petr Spacek wrote: > On 23.10.2015 13:53, Martin Basti wrote: >> >> >> On 23.10.2015 13:53, Tomas Babej wrote: >>> >>> On 10/23/2015 01:51 PM, Martin Basti wrote: On 23.10.2015 13:49, Tomas Babej wrote: > On 10/23/2015 12:49 PM, Martin Basti wrote: >> On

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached. Please, see my comments below My comments inline, I may be completely wrong in how the test suite work, so feel free to correct me. Martin On 10/26/2015 06:48 PM, Martin Basti wrote: On

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 27.10.2015 13:56, Oleg Fayans wrote: On 10/27/2015 01:22 PM, Martin Basti wrote: On 27.10.2015 12:06, Oleg Fayans wrote: Hi Martin, On 10/27/2015 10:50 AM, Martin Basti wrote: On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 10/27/2015 01:22 PM, Martin Basti wrote: On 27.10.2015 12:06, Oleg Fayans wrote: Hi Martin, On 10/27/2015 10:50 AM, Martin Basti wrote: On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached.

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

Hi Martin, On 10/27/2015 10:50 AM, Martin Basti wrote: On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached. Please, see my comments below My comments inline, I may be completely wrong in how the test

[Freeipa-devel] [PATCH] DNSZone command with user friendly message

Hi All, This patch fixes bug - https://fedorahosted.org/freeipa/ticket/4811 Thanks, Abhijeet Kasurde From a333e7ddb830e5ff10d2602b12669b767b870dbb Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Tue, 27 Oct 2015 17:21:17 +0530 Subject: [PATCH] Added user friendly

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 27.10.2015 12:06, Oleg Fayans wrote: Hi Martin, On 10/27/2015 10:50 AM, Martin Basti wrote: On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached. Please, see my comments below My comments inline, I

Re: [Freeipa-devel] [PATCHES] 0743-0747 Python 3 porting

On 10/23/2015 08:21 PM, Petr Viktorin wrote: > Hello, > Another batch of py3 porting patches. > > With these, the only thing to fix to get ipapython tests passing will be > handling encoding/decoding for stdin/stdout/stderr for ipautil.run(). ACK, it's nice to see some of that old code go.

Re: [Freeipa-devel] [PATCH] enable pem=True in export_pem_cert function

On 10/26/2015 08:59 PM, Niranjan wrote: > Greetings, > > export_pem_cert function from ipapython/certdb should export the certificate > in pem format but instead exports the cert in der format as it doesn't enable > pem=True. > > This patch specifies pem=True for export_pem_cert function > >

Re: [Freeipa-devel] [PATCH] Fix ipa-ca-install bug #5397

On 23.10.2015 17:26, Simo Sorce wrote: This patch moves the check to see if a CA is already installed locally early. Simo. ACK Pushed to master: 53294aa7a7db7eff527455fc35283306b37fc777 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [draft] Fate of ipa-replica-manage and ipa-csreplica-manage tools

Both tools serve primarily for managing replication agreements and replicas. ipa-replica-manage also manages winsync agreements and DNA ranges. FreeIPA 4.3 will introduce managed topology which affects these tools. Let's go trough all sub-commands of both tools and decide what is the fate of

Re: [Freeipa-devel] [PATCH] DNSZone command with user friendly message

On 27.10.2015 14:46, Martin Basti wrote: On 27.10.2015 13:00, Abhijeet Kasurde wrote: Hi All, This patch fixes bug - https://fedorahosted.org/freeipa/ticket/4811 Thanks, Abhijeet Kasurde [Tue Oct 27 14:44:51.328615 2015] [wsgi:error] [pid 5556] ipa: ERROR: non-public: AttributeError:

Re: [Freeipa-devel] [draft] Fate of ipa-replica-manage and ipa-csreplica-manage tools

On 10/27/2015 03:54 PM, Petr Vobornik wrote: Both tools serve primarily for managing replication agreements and replicas. ipa-replica-manage also manages winsync agreements and DNA ranges. FreeIPA 4.3 will introduce managed topology which affects these tools. Let's go trough all

Re: [Freeipa-devel] [PATCHES] 0743-0747 Python 3 porting

On 10/27/2015 05:22 PM, Tomas Babej wrote: > > > On 10/23/2015 08:21 PM, Petr Viktorin wrote: >> Hello, >> Another batch of py3 porting patches. >> >> With these, the only thing to fix to get ipapython tests passing will be >> handling encoding/decoding for stdin/stdout/stderr for

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

On 10/27/2015 04:23 PM, Martin Babinsky wrote: On 10/22/2015 01:06 PM, Petr Vobornik wrote: On 10/16/2015 06:41 PM, Endi Sukma Dewata wrote: On 10/15/2015 9:54 AM, Simo Sorce wrote: 3) ipa-ca-install fails with: Traceback (most recent call last): File

Re: [Freeipa-devel] [PATCH 0091] Silence of the linters

On 10/27/2015 06:21 PM, Martin Babinsky wrote: this patch silences a false-positive pylint error introduced by recent python 3 porting patches (commit c38516eab7b82f3ba7334cdea7a422a070048b59) pep8 fail. Attaching updated patch. -- Martin^3 Babinsky From

Re: [Freeipa-devel] [PATCH 0327] KRA: fix check if CA is installed on replica

On 10/27/2015 10:43 AM, Martin Basti wrote: On 26.10.2015 10:35, Martin Babinsky wrote: On 10/23/2015 05:18 PM, Martin Basti wrote: On 23.10.2015 15:15, Martin Babinsky wrote: On 10/23/2015 03:12 PM, Martin Babinsky wrote: On 10/16/2015 12:41 PM, Martin Basti wrote:

[Freeipa-devel] [PATCH 0091] Silence of the linters

this patch silences a false-positive pylint error introduced by recent python 3 porting patches (commit c38516eab7b82f3ba7334cdea7a422a070048b59) -- Martin^3 Babinsky From abd6194bb432acbab910c2de1430ce333411ea2a Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Tue, 27

Re: [Freeipa-devel] [PATCH 0091] Silence of the linters

On 10/27/2015 06:25 PM, Martin Babinsky wrote: > On 10/27/2015 06:21 PM, Martin Babinsky wrote: >> this patch silences a false-positive pylint error introduced by recent >> python 3 porting patches (commit >> c38516eab7b82f3ba7334cdea7a422a070048b59) >> >> >> > pep8 fail. > > Attaching updated

Re: [Freeipa-devel] [PATCH 0091] Silence of the linters

On 10/27/2015 06:26 PM, Tomas Babej wrote: > > > On 10/27/2015 06:25 PM, Martin Babinsky wrote: >> On 10/27/2015 06:21 PM, Martin Babinsky wrote: >>> this patch silences a false-positive pylint error introduced by recent >>> python 3 porting patches (commit >>>

Re: [Freeipa-devel] [PATCH] enable pem=True in export_pem_cert function

Tomas Babej wrote: > On 10/26/2015 08:59 PM, Niranjan wrote: > > Greetings, > > > > export_pem_cert function from ipapython/certdb should export the > > certificate > > in pem format but instead exports the cert in der format as it doesn't > > enable pem=True. > > > > This patch specifies

[Freeipa-devel] [PATCH 0058] interactive installer does not ignore leading/trailing whitespace

Hello, Fix for https://fedorahosted.org/freeipa/ticket/5355 Thanks, Gabe From 02434fc8467bbc81313d4bda0cf0e9644c151f00 Mon Sep 17 00:00:00 2001 From: Gabe Date: Tue, 27 Oct 2015 19:17:43 -0600 Subject: [PATCH] interactive installer does not ignore leading/trailing

Re: [Freeipa-devel] [PATCH] DNSZone command with user friendly message

On 27.10.2015 13:00, Abhijeet Kasurde wrote: Hi All, This patch fixes bug - https://fedorahosted.org/freeipa/ticket/4811 Thanks, Abhijeet Kasurde [Tue Oct 27 14:44:51.328615 2015] [wsgi:error] [pid 5556] ipa: ERROR: non-public: AttributeError: 'dnszone' object has no attribute

Re: [Freeipa-devel] [PATCH] DNSZone command with user friendly message

On 10/27/2015 07:16 PM, Martin Basti wrote: On 27.10.2015 13:00, Abhijeet Kasurde wrote: Hi All, This patch fixes bug - https://fedorahosted.org/freeipa/ticket/4811 Thanks, Abhijeet Kasurde Sorry, my bad. Please find the new patch. [Tue Oct 27 14:44:51.328615 2015] [wsgi:error] [pid

Re: [Freeipa-devel] [PATCH 0331, 0337] User plugin: allow multiple managers per user - CLI part

On 20.10.2015 18:46, Martin Basti wrote: On 20.10.2015 16:07, Martin Basti wrote: On 20.10.2015 15:57, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5344 Patch attached. Test are failing, a fix in UserTracker has to be done (partially in my patch 329) SelfNACK, I