Re: [Freeipa-devel] [PATCH 0397] ipapython: Use custom datetime to LDAP generalized time

On 18.1.2016 08:06, Christian Heimes wrote: > On 2016-01-15 13:44, Tomas Babej wrote: >> Hi, >> >> For the dates older than 1900, Python is unable to convert the datetime >> representation to string using strftime: >> >> https://bugs.python.org/issue1777412 >> >> Work around the issue adding a

Re: [Freeipa-devel] [PATCH 0029] Move user/group constants for PKI and DS into ipaplatform

On Tue, Jan 19, 2016 at 02:20:27PM +0100, Christian Heimes wrote: > ipaplatform.constants has platform specific names for a couple of system > users like Apache HTTPD. The user names for PKI_USER, PKI_GROUP, DS_USER > and DS_GROUP are defined in other modules. Similar to #5587 the patch my > patch

Re: [Freeipa-devel] [PATCH] 945 webui: dislay server suffixes in server search page

On 01/19/2016 06:32 PM, Petr Vobornik wrote: [PATCH] webui: dislay server suffixes in server search page There was a change where suffixes in server are not longer returned as DNs but rather a cn of related topology suffix. I.e. they share "memberof" logic. This caused that search page doesn't

Re: [Freeipa-devel] [PATCH] Fixed login error message box in LoginScreen page

Ping for review request. On 12/28/2015 12:36 PM, Abhijeet Kasurde wrote: Hi All, Please review patches attached. Thanks, Abhijeet Kasurde -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH] Added kpasswd_server directive in client krb5.conf

Ping for review request. On 01/06/2016 10:37 AM, Abhijeet Kasurde wrote: Hi All, On 01/05/2016 04:52 PM, Christian Heimes wrote: On 2016-01-04 23:38, Nalin Dahyabhai wrote: On Mon, Dec 21, 2015 at 12:17:08PM +0530, Abhijeet Kasurde wrote: Hi All, Please review patches attached. The port

[Freeipa-devel] [PATCH] 0049 Remove workaround for CA running check

The attached patch removes a workaround introduced as part of https://fedorahosted.org/freeipa/ticket/4676. Alternatively, if we want to keep the "workaround" I will submit a different patch that removes unused code and FIXME comments :) Cheers, Fraser From

[Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

New pylint version will broke our custom make-lint script again, attached patch migrates make-lint to: * config file * pylint plugin which are supported by pylint and should not have regular compatibility issues to test new approach run ./make-lint2 Advantages: * compatibility with pylint *

Re: [Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

On 01/19/2016 01:47 PM, David Kupka wrote: > I've polished the patch attached to #5586 by Timo Aaltonen. > > Thanks for the patch. I've fixed the path in specfile and removed unused > import > but otherwise it works, ACK. > > https://fedorahosted.org/freeipa/ticket/5586 Won't this break

[Freeipa-devel] [PATCH 0029] Move user/group constants for PKI and DS into ipaplatform

ipaplatform.constants has platform specific names for a couple of system users like Apache HTTPD. The user names for PKI_USER, PKI_GROUP, DS_USER and DS_GROUP are defined in other modules. Similar to #5587 the patch my patch moves the constants into the platform module.

[Freeipa-devel] [PATCH 0012] Use HTTPD_USER in dogtaginstance.py

I've converted the diff attached to #5587 by Timo Aaltonen. Works for me, ACK. https://fedorahosted.org/freeipa/ticket/5587 -- David Kupka From 38e1128f5037d5019384197eccd6bcbb8bf5e7d1 Mon Sep 17 00:00:00 2001 From: Timo Aaltonen Date: Tue, 19 Jan 2016 12:43:18 +0100

[Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

I've polished the patch attached to #5586 by Timo Aaltonen. Thanks for the patch. I've fixed the path in specfile and removed unused import but otherwise it works, ACK. https://fedorahosted.org/freeipa/ticket/5586 -- David Kupka From 8344b67c2cec25f0fb458a9bd1826a5e06c88aab Mon Sep 17

Re: [Freeipa-devel] [PATCH 0398] logger: Use warning instead of warn

On 18.01.2016 17:50, Martin Basti wrote: On 18.01.2016 17:49, Martin Basti wrote: On 15.01.2016 17:15, Tomas Babej wrote: On 01/15/2016 05:12 PM, Martin Basti wrote: On 15.01.2016 16:27, Tomas Babej wrote: Hi, this should build up to another pylint-related patch Martin^2 has in

Re: [Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

On 19.1.2016 14:26, Martin Kosek wrote: On 01/19/2016 01:47 PM, David Kupka wrote: I've polished the patch attached to #5586 by Timo Aaltonen. Thanks for the patch. I've fixed the path in specfile and removed unused import but otherwise it works, ACK.

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

On 01/15/2016 03:41 PM, Filip Skola wrote: Hi, sending rebased patch on top of 58c42ddac0964a8cce7c1e1faa7516da53f028ad. Includes a "fix" for the rename-to-invalid-username issue for the new version. F. - Original Message - Hi, I don't know what is causing the \r\n issue. I use vim

Re: [Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

On 2016-01-19 13:43, Martin Basti wrote: > + > +def fake_class(name_or_class_obj, members=[]): Please use a non-mutable argument here. members=() will do the job just fine. > +if isinstance(name_or_class_obj, scoped_nodes.Class): > +cl = name_or_class_obj > +else: > +cl =

Re: [Freeipa-devel] [PATCH 0011] Move freeipa certmonger helpers to libexecdir.

On 19/01/16 14:38, Jan Cholasta wrote: On 19.1.2016 14:26, Martin Kosek wrote: On 01/19/2016 01:47 PM, David Kupka wrote: I've polished the patch attached to #5586 by Timo Aaltonen. Thanks for the patch. I've fixed the path in specfile and removed unused import but otherwise it works, ACK.

Re: [Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

On 19.01.2016 16:34, Christian Heimes wrote: On 2016-01-19 13:43, Martin Basti wrote: + +def fake_class(name_or_class_obj, members=[]): Please use a non-mutable argument here. members=() will do the job just fine. Fixed. +if isinstance(name_or_class_obj, scoped_nodes.Class): +

Re: [Freeipa-devel] [PATCH 536] ipapython: remove default_encoding_utf8

On 15.1.2016 13:43, Tomas Babej wrote: On 01/12/2016 10:24 AM, Jan Cholasta wrote: On 6.1.2016 12:33, Christian Heimes wrote: On 2016-01-05 11:30, Tomas Babej wrote: On 01/05/2016 08:54 AM, Jan Cholasta wrote: Hi, the attached patch replaces the default_encoding_utf8 binary module with

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

On 19.1.2016 13:45, Petr Viktorin wrote: On 01/19/2016 08:45 AM, Jan Cholasta wrote: On 14.1.2016 18:29, Petr Viktorin wrote: On 01/12/2016 03:44 PM, Petr Viktorin wrote: Hello I tried --py3k option and it doesn't print any error, can we enable that check by default to prevent python3

Re: [Freeipa-devel] [TEST][PATCH 0019] A proper fix for reverse-zone creation in integration tests

On 18.01.2016 12:51, Oleg Fayans wrote: On 01/18/2016 10:30 AM, Petr Spacek wrote: On 14.1.2016 15:05, Oleg Fayans wrote: Date: Thu, 14 Jan 2016 14:59:37 +0100 Subject: [PATCH] fixed an issue with master installation not creating reverse zone When resolv.conf is set to point to the

[Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

Patch attached. -- Milan Kubik From 8f343a755dfdf9feb1ab9a3b7c91797f80b0261e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Tue, 19 Jan 2016 15:06:38 +0100 Subject: [PATCH] ipatests: fix the install of external ca Fixes the install invocation in the

Re: [Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

On 01/19/2016 05:31 PM, Milan Kubík wrote: Patch attached. This actually has a ticket opened. Patch with fixed commit message. ;) -- Milan Kubik From d3e43f982d246a9d82807aeff1320e8c1af58e0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Tue, 19 Jan

[Freeipa-devel] [PATCH 0129] correctly set LDAP bind related attributes when setting up replication

Fixes https://fedorahosted.org/freeipa/ticket/5412 -- Martin^3 Babinsky From def242b8bee504c8e7bc0acadfdbf179936ba9e2 Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Tue, 19 Jan 2016 17:46:57 +0100 Subject: [PATCH] correctly set LDAP bind related attributes when

[Freeipa-devel] [PATCH] 945 webui: dislay server suffixes in server search page

[PATCH] webui: dislay server suffixes in server search page There was a change where suffixes in server are not longer returned as DNs but rather a cn of related topology suffix. I.e. they share "memberof" logic. This caused that search page doesn't get the data because it uses "no_member: