On 19.1.2016 13:45, Petr Viktorin wrote:
On 01/19/2016 08:45 AM, Jan Cholasta wrote:
On 14.1.2016 18:29, Petr Viktorin wrote:
On 01/12/2016 03:44 PM, Petr Viktorin wrote:


Hello I tried --py3k option and it doesn't print any error, can we
enable that check by default to prevent python3 regressions?

# ./make-lint --py3k
No config file found, using default configuration

Squash in the other attached patch to enable it by default.

Sorry, please ignore the squash patch -- if --py3k is to be on by
default, I'll also need to add all needed packages to BuildRequires.

Actually, after all, that's not true -- the py3 libraries aren't needed
for pylint --py3k.
So, patches are ready for review as they are (with your choice of what
the default should be).

Patch 759:

1) Typo: 'Skil the main lint check'.

Will fix in the next patches.

2) Why the indentation change in output?

Fixed. I'm attaching the changed patch only.

Regarding --(no-)py3k, do we even need the option? I would just enable
the checks and not add the option unless someone specifically asked for it.

Several times I was annoyed how hard it is to use IPA's make-lint if you
need to do something other than lint the whole codebase with the default
options. (Usually what I end up doing is copying make-lint and patching
the copy to do what I want.)

I don't want to add to the annoyance by making it impossible to run just
one of the checks. So consider me asking for this :)

Works for me.


Otherwise LGTM, including patch 758.

Attaching updated patches, with py3k check as as default squashed in.
I also added a pylint exception for a new use of reload() in 0756.
One more thing I did was disable pylint's long and uninteresting report,
so now only the messages are shown.

Thanks, ACK.

Could you please rebase the patches on top of ipa-4-3 so I can push them?

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to