[Freeipa-devel] [freeipa PR#83] Added a fix for setting Priority as required field (opened)

2016-09-14 Thread Akasurde
Akasurde's pull request #83: "Added a fix for setting Priority as required field " was opened PR body: """ Fixes: https://fedorahosted.org/freeipa/ticket/5553 Signed-off-by: Abhijeet Kasurde """ See the full pull-request at https://github.com/freeipa/freeipa/pull/83 ... or pull the PR as Git b

[Freeipa-devel] [freeipa PR#10] Client-side CSR autogeneration (comment)

2016-09-14 Thread jcholast
jcholast commented on a pull request """ In addition to my inline comments above: 1. "Certificate mapping" does not really evoke "certificate request templating" to me, and is also used in the context of mapping identities to certificates. Could we use a more suitable name to avoid confusion? 2

[Freeipa-devel] [freeipa PR#10] Client-side CSR autogeneration (comment)

2016-09-14 Thread LiptonB
LiptonB commented on a pull request """ Some tests for the CSR generation functionality have been added to the pull request. """ See the full comment at https://github.com/freeipa/freeipa/pull/10#issuecomment-247174035 -- Manage your subscription for the Freeipa-devel mailing list: https://www

[Freeipa-devel] [freeipa PR#10] Client-side CSR autogeneration (synchronize)

2016-09-14 Thread LiptonB
LiptonB's pull request #10: "Client-side CSR autogeneration" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/10 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/10/head:pr10 git checkout pr10

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Alexander Bokovoy
On Wed, 14 Sep 2016, Martin Basti wrote: On 14.09.2016 17:53, Alexander Bokovoy wrote: On Wed, 14 Sep 2016, Martin Basti wrote: On 14.09.2016 17:41, Alexander Bokovoy wrote: On Wed, 14 Sep 2016, Martin Basti wrote: 1) I still don't see the reason why AD trust is needed. Default trust ID

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Sumit Bose
On Wed, Sep 14, 2016 at 06:03:37PM +0200, Martin Basti wrote: > > > On 14.09.2016 17:53, Alexander Bokovoy wrote: > > On Wed, 14 Sep 2016, Martin Basti wrote: > > > > > > > > > On 14.09.2016 17:41, Alexander Bokovoy wrote: > > > > On Wed, 14 Sep 2016, Martin Basti wrote: > > > > > 1) > > > > >

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Martin Basti
On 14.09.2016 17:53, Alexander Bokovoy wrote: On Wed, 14 Sep 2016, Martin Basti wrote: On 14.09.2016 17:41, Alexander Bokovoy wrote: On Wed, 14 Sep 2016, Martin Basti wrote: 1) I still don't see the reason why AD trust is needed. Default trust ID view is added just by ipa-adtrust-install,

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Alexander Bokovoy
On Wed, 14 Sep 2016, Martin Basti wrote: On 14.09.2016 17:41, Alexander Bokovoy wrote: On Wed, 14 Sep 2016, Martin Basti wrote: 1) I still don't see the reason why AD trust is needed. Default trust ID view is added just by ipa-adtrust-install, adding trust is not needed for current implemen

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Martin Basti
On 14.09.2016 17:41, Alexander Bokovoy wrote: On Wed, 14 Sep 2016, Martin Basti wrote: 1) I still don't see the reason why AD trust is needed. Default trust ID view is added just by ipa-adtrust-install, adding trust is not needed for current implementation. You don't need AD for this, IDview

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Alexander Bokovoy
On Wed, 14 Sep 2016, Martin Basti wrote: 1) I still don't see the reason why AD trust is needed. Default trust ID view is added just by ipa-adtrust-install, adding trust is not needed for current implementation. You don't need AD for this, IDviews is generic feature not just for AD. Is that us

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Martin Basti
On 06.09.2016 13:57, Oleg Fayans wrote: The test is updated to clean up after itself On 09/06/2016 12:57 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. The updated patches are attached. Please, see my comments below On 08/30/2016 01:58 PM, Martin Basti wrote: On 22.08.2016 13:1

[Freeipa-devel] [freeipa PR#78] Fix Ip-addr validation (comment)

2016-09-14 Thread dkupka
dkupka commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/1c96ff7a6c7e1733a6492f9b3c93265f5bc8ff5b https://fedorahosted.org/freeipa/changeset/cd2c10d7ca97ffc76682159ad58161eab413532d https://fedorahosted.org/freeipa/changeset/d13a4c2f395c08b514a51a19e

[Freeipa-devel] [freeipa PR#78] Fix Ip-addr validation (closed)

2016-09-14 Thread dkupka
mbasti-rh's pull request #78: "Fix Ip-addr validation" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/78 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/78/head:pr78 git checkout pr78 -- Manage

[Freeipa-devel] [freeipa PR#78] Fix Ip-addr validation (+pushed)

2016-09-14 Thread dkupka
mbasti-rh's pull request #78: "Fix Ip-addr validation" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/78 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA

[Freeipa-devel] [freeipa PR#78] Fix Ip-addr validation (+ack)

2016-09-14 Thread dkupka
mbasti-rh's pull request #78: "Fix Ip-addr validation" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/78 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: h

[Freeipa-devel] [freeipa PR#81] Fix emptyzones dns upgrade (+ack)

2016-09-14 Thread martbab
mbasti-rh's pull request #81: "Fix emptyzones dns upgrade" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/81 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIP

[Freeipa-devel] [freeipa PR#81] Fix emptyzones dns upgrade (closed)

2016-09-14 Thread martbab
mbasti-rh's pull request #81: "Fix emptyzones dns upgrade" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/81 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/81/head:pr81 git checkout pr81 -- Ma

[Freeipa-devel] [freeipa PR#81] Fix emptyzones dns upgrade (comment)

2016-09-14 Thread martbab
martbab commented on a pull request """ Fixed upstream ipa-4-3: https://fedorahosted.org/freeipa/changeset/2d011b97c8a56d9eabae2ca3d88c30314e0adb58 https://fedorahosted.org/freeipa/changeset/93756dc719723bbec93497ecd6e06e325e6eecbd ipa-4-4: https://fedorahosted.org/freeipa/changeset/afeb4bd8a60391

[Freeipa-devel] [freeipa PR#81] Fix emptyzones dns upgrade (+pushed)

2016-09-14 Thread martbab
mbasti-rh's pull request #81: "Fix emptyzones dns upgrade" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/81 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to Fre

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (closed)

2016-09-14 Thread mbasti-rh
ofayans's pull request #52: "Removed incorrect check for returncode" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/52 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/52/head:pr52 git checkout p

[Freeipa-devel] [freeipa PR#80] ipa passwd: use correct normalizer for user principals (+pushed)

2016-09-14 Thread martbab
martbab's pull request #80: "ipa passwd: use correct normalizer for user principals" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/80 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freei

[Freeipa-devel] [freeipa PR#80] ipa passwd: use correct normalizer for user principals (comment)

2016-09-14 Thread martbab
martbab commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/f3f9087ee8d1b1531730cf1e91fe404092e8c81d ipa-4-4: https://fedorahosted.org/freeipa/changeset/0fe08fdce78b8a26cae1ad238cfea20fe86b8332 """ See the full comment at https://github.com/freeipa/f

[Freeipa-devel] [freeipa PR#80] ipa passwd: use correct normalizer for user principals (closed)

2016-09-14 Thread martbab
martbab's pull request #80: "ipa passwd: use correct normalizer for user principals" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/80 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/80/head:pr

[Freeipa-devel] [freeipa PR#82] Fix regexp in user/group name (opened)

2016-09-14 Thread mbasti-rh
mbasti-rh's pull request #82: "Fix regexp in user/group name" was opened PR body: """ Regexp should not enforce lenght of string, we have different checks for that. Secondly regexp with length specified produces an incorrect error message. https://fedorahosted.org/freeipa/ticket/5822 """ See the

[Freeipa-devel] [freeipa PR#27] [master, ipa-4-3] Tests: Fix integration sudo tests setup and checks (comment)

2016-09-14 Thread mbasti-rh
mbasti-rh commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/7cac8392036bf6d6bbd74f5a781986dec21149d6 ipa-4-3: https://fedorahosted.org/freeipa/changeset/6d04220dc3071782cf303b2e94e06da4ee26e512 ipa-4-4: https://fedorahosted.org/freeipa/changeset/32a6

[Freeipa-devel] [freeipa PR#27] [master, ipa-4-3] Tests: Fix integration sudo tests setup and checks (+pushed)

2016-09-14 Thread mbasti-rh
mirielka's pull request #27: "[master, ipa-4-3] Tests: Fix integration sudo tests setup and checks" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/27 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman

[Freeipa-devel] [freeipa PR#27] [master, ipa-4-3] Tests: Fix integration sudo tests setup and checks (closed)

2016-09-14 Thread mbasti-rh
mirielka's pull request #27: "[master, ipa-4-3] Tests: Fix integration sudo tests setup and checks" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/27 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#27] [master, ipa-4-3] Tests: Fix integration sudo tests setup and checks (+ack)

2016-09-14 Thread mbasti-rh
mirielka's pull request #27: "[master, ipa-4-3] Tests: Fix integration sudo tests setup and checks" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/27 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/li

[Freeipa-devel] [freeipa PR#27] [master, ipa-4-3] Tests: Fix integration sudo tests setup and checks (comment)

2016-09-14 Thread lslebodn
lslebodn commented on a pull request """ Test passed on fedora 24 + freeipa-4_4. ACK """ See the full comment at https://github.com/freeipa/freeipa/pull/27#issuecomment-246969936 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-deve

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-09-14 Thread Oleg Fayans
Ping for review. On 09/06/2016 01:57 PM, Oleg Fayans wrote: The test is updated to clean up after itself On 09/06/2016 12:57 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. The updated patches are attached. Please, see my comments below On 08/30/2016 01:58 PM, Martin Basti wrote:

Re: [Freeipa-devel] [Test][patch-0058] Fixed topology tests failures in CI

2016-09-14 Thread Oleg Fayans
Again ping for review, please it completely blocks the whole job. On 09/07/2016 03:27 PM, Oleg Fayans wrote: ping for review On 08/24/2016 01:58 PM, Oleg Fayans wrote: And here is how the run looks like: $ ipa-run-tests test_integration/test_topology.py WARNING: Couldn't write lextab module '

[Freeipa-devel] [freeipa PR#79] trust-fetch-domains: contact forest DCs when fetching trust domain info (+pushed)

2016-09-14 Thread martbab
martbab's pull request #79: "trust-fetch-domains: contact forest DCs when fetching trust domain info" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/79 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailm

[Freeipa-devel] [freeipa PR#79] trust-fetch-domains: contact forest DCs when fetching trust domain info (comment)

2016-09-14 Thread martbab
martbab commented on a pull request """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/b0d40b80e8d9a4960296ce70d843ad987657696b ipa-4-4: https://fedorahosted.org/freeipa/changeset/6755cbbc3346910bcd4be1577351cc15ab7d3140 """ See the full comment at https://github.com/freeipa/f

[Freeipa-devel] [freeipa PR#79] trust-fetch-domains: contact forest DCs when fetching trust domain info (closed)

2016-09-14 Thread martbab
martbab's pull request #79: "trust-fetch-domains: contact forest DCs when fetching trust domain info" was closed See the full pull-request at https://github.com/freeipa/freeipa/pull/79 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeip

[Freeipa-devel] [freeipa PR#79] trust-fetch-domains: contact forest DCs when fetching trust domain info (+ack)

2016-09-14 Thread abbra
martbab's pull request #79: "trust-fetch-domains: contact forest DCs when fetching trust domain info" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/79 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/

[Freeipa-devel] [freeipa PR#79] trust-fetch-domains: contact forest DCs when fetching trust domain info (comment)

2016-09-14 Thread abbra
abbra commented on a pull request """ LGTM. We discussed the placement of populate_remote_domain() but decided to keep it there. """ See the full comment at https://github.com/freeipa/freeipa/pull/79#issuecomment-246935619 -- Manage your subscription for the Freeipa-devel mailing list: https:/

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (+pushed)

2016-09-14 Thread mbasti-rh
ofayans's pull request #52: "Removed incorrect check for returncode" label *pushed* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/52 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contrib

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

2016-09-14 Thread mbasti-rh
mbasti-rh commented on a pull request """ **Xfailed the tests due to a known bug with replica preparation** Fixed upstream master: https://fedorahosted.org/freeipa/changeset/1e484d010b653b8ac06425ca602ba5c9e950ed89 """ See the full comment at https://github.com/freeipa/freeipa/pull/52#issuecom

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

2016-09-14 Thread mbasti-rh
mbasti-rh commented on a pull request """ **Changed addressing to the client hosts to be replicas** Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ac78d191ded6721cf1051413cdd6862c0362e66b ipa-4-4: https://fedorahosted.org/freeipa/changeset/de4a1fc0df5474f268c7ed08ffb802110631c1

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

2016-09-14 Thread mbasti-rh
mbasti-rh commented on a pull request """ **Several fixes in replica_promotion tests** Fixed upstream master: https://fedorahosted.org/freeipa/changeset/39c15ecdcdcbc2a0b651b0f89080789dd806e998 ipa-4-4: https://fedorahosted.org/freeipa/changeset/cd6adafbf699da48ab877e77ac9c1cc1dd26bf61 """ See

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

2016-09-14 Thread mbasti-rh
mbasti-rh commented on a pull request """ **Removed incorrect check for returncode** Fixed upstream master: https://fedorahosted.org/freeipa/changeset/22b0e8a9eb9eb3d47131c6784d70dd409d5b889b ipa-4-4: https://fedorahosted.org/freeipa/changeset/e265853d055caf7e3d17316eee6e25aa26bbf2a9 """ See th

[Freeipa-devel] [freeipa PR#80] ipa passwd: use correct normalizer for user principals (+ack)

2016-09-14 Thread abbra
martbab's pull request #80: "ipa passwd: use correct normalizer for user principals" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/80 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-

[Freeipa-devel] [freeipa PR#80] ipa passwd: use correct normalizer for user principals (comment)

2016-09-14 Thread abbra
abbra commented on a pull request """ Looks good, thanks! """ See the full comment at https://github.com/freeipa/freeipa/pull/80#issuecomment-246931189 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: ht

[Freeipa-devel] [freeipa PR#81] Fix emptyzones dns upgrade (synchronize)

2016-09-14 Thread mbasti-rh
mbasti-rh's pull request #81: "Fix emptyzones dns upgrade" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/81 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/81/head:pr81 git checkout pr81 F

[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (+ack)

2016-09-14 Thread mbasti-rh
ofayans's pull request #52: "Removed incorrect check for returncode" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/52 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute