On 22.9.2016 16:39, Martin Basti wrote:
Hello all,
In 4.5, I would like to remove all unused variables from code and enable
pylint check. Due to big amount of unused variables in the code this
will be longterm effort.
Why this?:
* better code readability
* removing dead code
* unused
Bump for review.
On Wed, Sep 07, 2016 at 04:06:25PM +0700, Fraser Tweedale wrote:
> Attached patch fixes https://fedorahosted.org/freeipa/ticket/6305
>
> Thanks,
> Fraser
> From d4d7e77795f96a4970058e61d99c70522689b22d Mon Sep 17 00:00:00 2001
> From: Fraser Tweedale
>
Bump for review.
Rebased patches attached (there was a trivial conflict in imports).
Thanks,
Fraser
On Tue, Sep 06, 2016 at 02:05:06AM +1000, Fraser Tweedale wrote:
> On Fri, Aug 26, 2016 at 10:28:58AM +0200, Jan Cholasta wrote:
> > On 19.8.2016 13:11, Fraser Tweedale wrote:
> > > Bump for
On 22.09.2016 18:05, Tomas Krizek wrote:
On 09/22/2016 06:00 PM, Martin Basti wrote:
On 22.09.2016 17:59, Tomas Krizek wrote:
On 09/22/2016 04:39 PM, Martin Basti wrote:
Hello all,
In 4.5, I would like to remove all unused variables from code and
enable pylint check. Due to big amount
Hi all,
As you know, FedoraHosted.org will be decommissioned.
https://communityblog.fedoraproject.org/fedorahosted-sunset-2017-02-28/
We use Trac instance there. Let's discuss where we should migrate and
what are our requirements. Then put results on one place. For that I've
created:
On 09/22/2016 06:00 PM, Martin Basti wrote:
On 22.09.2016 17:59, Tomas Krizek wrote:
On 09/22/2016 04:39 PM, Martin Basti wrote:
Hello all,
In 4.5, I would like to remove all unused variables from code and
enable pylint check. Due to big amount of unused variables in the
code this will be
On 22.09.2016 17:59, Tomas Krizek wrote:
On 09/22/2016 04:39 PM, Martin Basti wrote:
Hello all,
In 4.5, I would like to remove all unused variables from code and
enable pylint check. Due to big amount of unused variables in the
code this will be longterm effort.
Why this?:
* better code
On 09/22/2016 04:39 PM, Martin Basti wrote:
Hello all,
In 4.5, I would like to remove all unused variables from code and
enable pylint check. Due to big amount of unused variables in the code
this will be longterm effort.
Why this?:
* better code readability
* removing dead code
* unused
URL: https://github.com/freeipa/freeipa/pull/107
Author: tomaskrizek
Title: #107: Update man/help for --server option
Action: opened
PR body:
"""
The --server option now specifically mentions that
it expects the FQDN of the IPA server.
https://fedorahosted.org/freeipa/ticket/6202
"""
To
URL: https://github.com/freeipa/freeipa/pull/97
Title: #97: Pylint fixes
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/36484e8672f5ee1fdc2bd57622e330ab8dbb7671
https://fedorahosted.org/freeipa/changeset/275e85d076607ce317b3aeca467167fac55bf396
URL: https://github.com/freeipa/freeipa/pull/97
Title: #97: Pylint fixes
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/106
Author: mbasti-rh
Title: #106: Pylint: enable additional checks
Action: opened
PR body:
"""
Enabling:
* cyclic-imports
* global-variable-not-assigned
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
URL: https://github.com/freeipa/freeipa/pull/97
Author: mbasti-rh
Title: #97: Pylint fixes
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/97/head:pr97
git checkout pr97
--
Manage your subscription for the
Hello all,
In 4.5, I would like to remove all unused variables from code and enable
pylint check. Due to big amount of unused variables in the code this
will be longterm effort.
Why this?:
* better code readability
* removing dead code
* unused variable may uncover potential bug
It is
URL: https://github.com/freeipa/freeipa/pull/97
Title: #97: Pylint fixes
mbasti-rh commented:
"""
I had to rebase, there were conflicts due the latest pushed patches
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/97#issuecomment-248913108
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/97
Author: mbasti-rh
Title: #97: Pylint fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/97/head:pr97
git checkout pr97
From
URL: https://github.com/freeipa/freeipa/pull/97
Title: #97: Pylint fixes
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/105
Title: #105: Test: dont use global variable for iteration in test_cert_plugin
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/929086e0992cc32a654b4dfa435f536ecb0c665b
"""
See the full comment at
Hi Oleg!
As we discussed this morning there're still some issues [1][2] but I
think the patch set is in reasonably good state and I'm not sure that
the issues are bugs in IPA or in tests. This can be investigated and
fixed later.
ACK.
Pushed to master:
*
URL: https://github.com/freeipa/freeipa/pull/105
Author: mbasti-rh
Title: #105: Test: dont use global variable for iteration in test_cert_plugin
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/105/head:pr105
git
URL: https://github.com/freeipa/freeipa/pull/105
Title: #105: Test: dont use global variable for iteration in test_cert_plugin
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/105
Title: #105: Test: dont use global variable for iteration in test_cert_plugin
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/97
Author: mbasti-rh
Title: #97: Pylint fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/97/head:pr97
git checkout pr97
From
URL: https://github.com/freeipa/freeipa/pull/97
Author: mbasti-rh
Title: #97: Pylint fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/97/head:pr97
git checkout pr97
From
URL: https://github.com/freeipa/freeipa/pull/105
Author: mbasti-rh
Title: #105: Test: dont use global variable for iteration in test_cert_plugin
Action: opened
PR body:
"""
Iteration over global variable causes unwanted value changes outside
method
URL: https://github.com/freeipa/freeipa/pull/97
Title: #97: Pylint fixes
tomaskrizek commented:
"""
Please fix the typo.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/97#issuecomment-248884825
--
Manage your subscription for the Freeipa-devel mailing list:
On 22.09.2016 13:56, Martin Babinsky wrote:
On 09/22/2016 01:41 PM, Martin Basti wrote:
Hello all,
Following test is failing:
test_cert_find.test_0007_find_revocation_reason_0
On 09/22/2016 01:41 PM, Martin Basti wrote:
Hello all,
Following test is failing:
test_cert_find.test_0007_find_revocation_reason_0
Hello all,
Following test is failing:
test_cert_find.test_0007_find_revocation_reason_0
self = 0x7f1bf4532f90>
def
On 21.09.2016 12:01, Jan Pazdziora wrote:
Hello,
I've recently hit again the situation of IPA installer not happy
about the provided IP address not being local to it, this time in
containerized environment:
https://bugzilla.redhat.com/show_bug.cgi?id=1377973
During the discussion,
URL: https://github.com/freeipa/freeipa/pull/97
Author: mbasti-rh
Title: #97: Pylint fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/97/head:pr97
git checkout pr97
From
URL: https://github.com/freeipa/freeipa/pull/104
Author: martbab
Title: #104: Backport XMLRPC test fixes to ipa-4-3 branch
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/104/head:pr104
git checkout pr104
URL: https://github.com/freeipa/freeipa/pull/84
Title: #84: Removed update_from_dict function from ldapupdate
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/84
Author: stlaz
Title: #84: Removed update_from_dict function from ldapupdate
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/84/head:pr84
git checkout pr84
--
URL: https://github.com/freeipa/freeipa/pull/84
Title: #84: Removed update_from_dict function from ldapupdate
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/330a3ca93101bcec82ec5d3add14586871864bdd
ipa-4-4:
URL: https://github.com/freeipa/freeipa/pull/84
Title: #84: Removed update_from_dict function from ldapupdate
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/84
Title: #84: Removed update_from_dict function from ldapupdate
abbra commented:
"""
LGTM. Thanks.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/84#issuecomment-248869910
--
Manage your subscription for the Freeipa-devel
Fixed patch N 41
On 09/21/2016 04:21 PM, Oleg Fayans wrote:
Patch-0076 rebased to current master
On 09/21/2016 02:41 PM, Oleg Fayans wrote:
Hi David,
As per your comments the patches were once again refactored. I am
attaching the full set of them, please ignore any previous versions
The
URL: https://github.com/freeipa/freeipa/pull/97
Title: #97: Pylint fixes
tomaskrizek commented:
"""
NACK, please see inline comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/97#issuecomment-248867576
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/102
Title: #102: Updated ipa-client-install info about hostname
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/2e0afab5f2a47149580b4bc79093cdbb77f489c3
ipa-4-4:
URL: https://github.com/freeipa/freeipa/pull/102
Author: stlaz
Title: #102: Updated ipa-client-install info about hostname
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/102/head:pr102
git checkout pr102
--
URL: https://github.com/freeipa/freeipa/pull/102
Title: #102: Updated ipa-client-install info about hostname
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/84
Author: stlaz
Title: #84: Removed update_from_dict function from ldapupdate
Action: edited
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/84/head:pr84
git checkout pr84
--
URL: https://github.com/freeipa/freeipa/pull/84
Title: #84: Fix update_from_dict function testing
stlaz commented:
"""
Removed the method and its respective test again.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/84#issuecomment-248832033
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/84
Author: stlaz
Title: #84: Fix update_from_dict function testing
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/84/head:pr84
git checkout pr84
From
URL: https://github.com/freeipa/freeipa/pull/102
Title: #102: Updated ipa-client-install info about hostname
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/100
Title: #100: Ipa 4 4
dkupka commented:
"""
> hi, my issue is not in deployment my issue is a bug in the software itself i
> have already submitted a ticket with redhat support which is taking too much
> time so i hoped you guys can see this
47 matches
Mail list logo