[Freeipa-devel] [freeipa PR#237][opened] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-13 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Author: pspacek Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option Action: opened PR body: """ https://bugzilla.redhat.com/show_bug.cgi?id=1392778 """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#210][comment] Tests: Stage User Tracker implementation

2016-11-13 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation mirielka commented: """ Review notes: same as in https://github.com/freeipa/freeipa/pull/181 """ See the full comment at https://github.com/freeipa/freeipa/pull/210#issuecomment-260255679 --

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2016-11-13 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mirielka commented: """ Having "None" default values for obligatory arguments does not seem to be a good idea. If the method was called with default values, it would fail. It

[Freeipa-devel] [freeipa PR#227][edited] cert-request: match names against principal aliases

2016-11-13 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/227 Author: frasertweedale Title: #227: cert-request: match names against principal aliases Action: edited Changed field: title Original value: """ cert-request: match names against principal alises """ -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-11-13 Thread shanyin
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module shanyin commented: """ @mbasti-rh I've already finished my translation basically On Zanata. The URL is https://fedora.zanata.org/webtrans/translate?project=freeipa=master=zh-CN=en-US=9896#view:doc;doc:po/ipa """ See

[Freeipa-devel] [freeipa PR#227][synchronized] cert-request: match names against principal alises

2016-11-13 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/227 Author: frasertweedale Title: #227: cert-request: match names against principal alises Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/227/head:pr227 git

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-11-13 Thread shanyin
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module shanyin commented: """ I tried to use the centralized logging, but My system is Ubuntu, and the ipa-log-config tool is only supported by RHEL 7 / CentOS 7 currently. So, the centralized logging is not configured

[Freeipa-devel] [freeipa PR#235][comment] Remove unused Knob function

2016-11-13 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/235 Title: #235: Remove unused Knob function stlaz commented: """ From our offline discussion I got the impression the Knob function was still used somewhere, therefore the ACK. I'm not sure what was the reason of keeping Knob there even if unused,