URL: https://github.com/freeipa/freeipa/pull/602
Title: #602: configure: Use ODS_USER and NAMED_GROUP in
daemons/dnssec/*.service.in
martbab commented:
"""
master:
* 44a3e0fe1d168ad87182654976a26e352287b1e0 configure: Use ODS_USER and
NAMED_GROUP in daemons/dnssec/*.ser
URL: https://github.com/freeipa/freeipa/pull/602
Author: tjaalton
Title: #602: configure: Use ODS_USER and NAMED_GROUP in
daemons/dnssec/*.service.in
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/637
Title: #637: ldap2: use LDAP whoami operation to retrieve bind DN for current
connection
martbab commented:
"""
LGTM but lint has some complains probably related to my in-line comment.
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/631
Author: martbab
Title: #631: Upgrade: configure PKINIT after adding anonymous principal
Action: opened
PR body:
"""
In order to set up PKINIT, the anonymous principal must already be
created, otherwise the upgrade with fail
URL: https://github.com/freeipa/freeipa/pull/608
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
martbab commented:
"""
If you need the fix in ipa-4-4 you need to file a rebased PR against that
branch.
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/608
Author: HonzaCholasta
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
URL: https://github.com/freeipa/freeipa/pull/608
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
martbab commented:
"""
master:
* 3de09709cc33f1d26f2d605bac82110fe73dde03 tasks: run `systemctl daemon-reload`
after httpd.service.d
URL: https://github.com/freeipa/freeipa/pull/608
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/608
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/608
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
martbab commented:
"""
@HonzaCholasta I was not able to reproduce it any more so I guess that it was
transient error. If I encounter it again I will
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
master:
* fd1b4f6ec9a349196d5df510008c4745f0b1fb84 Add options to run only ipaclient
unittests
ipa-4-5:
* 29b885a8fac82e963f5ab98d178e818540569
URL: https://github.com/freeipa/freeipa/pull/475
Author: tiran
Title: #475: Add options to run only ipaclient unittests
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/475/head:pr475
git checkout pr475
--
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/608
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
martbab commented:
"""
Hmmm I just caught a following error during FreeIPA replica uninstall:
```console[root@replica1 ~]# ipa-server-install --uninst
URL: https://github.com/freeipa/freeipa/pull/608
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
Label: -ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/608
Title: #608: tasks: run `systemctl daemon-reload` after httpd.service.d updates
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: [WIP] Use Custodia 0.3 features
martbab commented:
"""
@MartinBasti ok there should be no problems with that (built it on F25 VM but
threw it away afterwards, oh well)
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
I have one small question and am going to try out some integration tests to see
if we did not break something in them as Travis won't catch that.
&q
URL: https://github.com/freeipa/freeipa/pull/606
Title: #606: [ipa-4-4] ipa-kdb: support KDB DAL version 6.1
martbab commented:
"""
Since the original ticket is in already closed milestone open a separate one
for backport to 4-4 branch please.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/517
Title: #517: [WIP] Use Custodia 0.3 features
martbab commented:
"""
@tiran we first need a copr build on F25 to unblock Travis CI. Can you provide
a copr repo and modify test runner config to add it during builddep phase?
&q
URL: https://github.com/freeipa/freeipa/pull/543
Title: #543: Add options to allow ticket caching
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/543
Title: #543: Add options to allow ticket caching
martbab commented:
"""
master:
* 4ee7e4ee6d6500d8b8935c9033388adc4cdbe672 Add options to allow ticket caching
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/543
Author: simo5
Title: #543: Add options to allow ticket caching
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/543/head:pr543
git checkout pr543
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/543
Title: #543: Add options to allow ticket caching
martbab commented:
"""
I think that we have all dependencies in spec already so I do not see a reason
not to.
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/543
Title: #543: Add options to allow ticket caching
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/567
Author: simo5
Title: #567: Configure KDC to use certs after they are deployed
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/567/head:pr567
git checkout pr567
--
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
martbab commented:
"""
Superseded by https://github.com/freeipa/freeipa/pull/584
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/584
Title: #584: Improve the implementation of PKINIT certificate retrieval
martbab commented:
"""
I have reworked the PR quite a bit and added/changed a few checks due to
replication race conditions affecting PKINIT requests from re
URL: https://github.com/freeipa/freeipa/pull/584
Author: martbab
Title: #584: Improve the implementation of PKINIT certificate retrieval
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/584/head:pr584
git
URL: https://github.com/freeipa/freeipa/pull/595
Author: martbab
Title: #595: idviews: correctly handle modification of non-existent view
Action: opened
PR body:
"""
the pre-callback in `idview-mod` did not correctly handle non-existent
object during objectclass check. It wil
URL: https://github.com/freeipa/freeipa/pull/584
Title: #584: Improve the implementation of PKINIT certificate retrieval
martbab commented:
"""
@simo5 are you OK with @abbra's inline suggestions (it is your commit after all
:))?
@MartinBasti hmmm I will try to reproduce the i
URL: https://github.com/freeipa/freeipa/pull/573
Title: #573: Provide centralized management of user short name resolution
martbab commented:
"""
Ok thanks for explanation.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/573#issuecom
URL: https://github.com/freeipa/freeipa/pull/584
Author: martbab
Title: #584: Improve the implementation of PKINIT certificate retrieval
Action: opened
PR body:
"""
The original PKINIT cert request code contained numerous defects, namely:
* nearly absent handling of re
URL: https://github.com/freeipa/freeipa/pull/573
Title: #573: Provide centralized management of user short name resolution
martbab commented:
"""
PR rebased, I have fixed bugs in ID view objectclass handling and re-used the
trusted domain retrieval code in certmap plugin. Thi
URL: https://github.com/freeipa/freeipa/pull/573
Author: martbab
Title: #573: Provide centralized management of user short name resolution
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/573/head:pr573
git
URL: https://github.com/freeipa/freeipa/pull/573
Author: martbab
Title: #573: Provide centralized management of user short name resolution
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/573/head:pr573
git
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
martbab commented:
"""
@simo5 thank you
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/567#issuecomment-286392161
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
martbab commented:
"""
@simo5 yes the whole PKINIT setup logic on replica is flawed and will probably
need to be moved into a later point in master/replica instal
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
martbab commented:
"""
@simo5 actually I found multiple issues during review and concluded that
setting up PKINIT on DL1 replica never worked correctly actu
URL: https://github.com/freeipa/freeipa/pull/573
Title: #573: Provide centralized management of user short name resolution
martbab commented:
"""
@HonzaCholasta I agree, I have removed the commit which introduces special
param handling and resorted to simple splitting in validat
URL: https://github.com/freeipa/freeipa/pull/573
Author: martbab
Title: #573: Provide centralized management of user short name resolution
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/573/head:pr573
git
URL: https://github.com/freeipa/freeipa/pull/570
Title: #570: ipaserver/dcerpc.py: use arcfour_encrypt from samba
martbab commented:
"""
master:
* 7657754e02a5fa62265327937a6c7fd19b381610 ipaserver/dcerpc.py: use
arcfour_encrypt from samba
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/570
Title: #570: ipaserver/dcerpc.py: use arcfour_encrypt from samba
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/573
Title: #573: Provide centralized management of user short name resolution
martbab commented:
"""
Updated PR, added ACIs and fixed Py2/Py3 compatibility of doctests.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/573
Author: martbab
Title: #573: Provide centralized management of user short name resolution
Action: opened
PR body:
"""
This PR implement an initial version of AD user short name resolution
infrastructure consumable by SSSD.[1]
Mo
URL: https://github.com/freeipa/freeipa/pull/414
Title: #414: SPEC: Update SELinux file context of ipa-otpd
martbab commented:
"""
I agree with closing this, we will need more substantial policy update
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/414
Title: #414: SPEC: Update SELinux file context of ipa-otpd
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/266
Title: #266: ipapython: simplify Env object initialization
martbab commented:
"""
@stlaz @HonzaCholasta any progress on this PR or should we mark it as postponed
and return to it later?
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/414
Title: #414: SPEC: Update SELinux file context of ipa-otpd
martbab commented:
"""
@lslebodn CI complains that your changes produce an invalid specfile. Can you
please fix this. A better question, is there a demand to have
URL: https://github.com/freeipa/freeipa/pull/561
Title: #561: ldap2: fix crash in development mode
martbab commented:
"""
Yes but please split it into a separate patch so that CI-related changes are
tracked separately and do not pollute the changes in the code.
"&quo
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy
martbab commented:
"""
master:
* 9f13b330aaec468a018472dce5fc77131277de94 Add code to retrieve results from
multiple bases
* 2e5cc369fd8b9d780697a9a286429cc2ca0f448a Add support for searching
URL: https://github.com/freeipa/freeipa/pull/353
Author: simo5
Title: #353: [RFE] Pwdpolicy
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/353/head:pr353
git checkout pr353
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy
martbab commented:
"""
test_kadmin and all other tests also passed. I do not see reason for not
pushing. Sorry for the dealy in reviewing.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy
martbab commented:
"""
test_kadmin and all other tests also passed. I do not see reason for not
pushing. Sorry for the dealy in reviewing.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/353
Title: #353: [RFE] Pwdpolicy
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
martbab commented:
"""
@MartinBasti any progress in reviewing this PR?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/463#issuecom
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
martbab commented:
"""
I think we can avoid the copy-pasta by actually moving PKINIT requesting code
into `__common_post_setup` like this:
```diff
--- a/ip
URL: https://github.com/freeipa/freeipa/pull/567
Title: #567: Configure KDC to use certs after they are deployed
martbab commented:
"""
I think we can avoid the copy-pasta by actually moving PKINIT requesting code
into `__common_post_setup` like this:
```diff
--- a/ip
URL: https://github.com/freeipa/freeipa/pull/564
Author: martbab
Title: #564: Reconfigure Kerberos library config as the last step of KDC
install
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/564/head:pr564
URL: https://github.com/freeipa/freeipa/pull/564
Title: #564: Reconfigure Kerberos library config as the last step of KDC install
martbab commented:
"""
Ah right this won't work because on master there would be no library
configuration for KDC deployment (realm, etc) that's why
URL: https://github.com/freeipa/freeipa/pull/564
Title: #564: Reconfigure Kerberos library config as the last step of KDC install
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/564
Title: #564: Reconfigure Kerberos library config as the last step of KDC install
martbab commented:
"""
But the certs are requested by certmonger on replica which tries to kinit
against *the very same KDC that is b
URL: https://github.com/freeipa/freeipa/pull/563
Title: #563: backup: backup anonymous keytab
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/563
Title: #563: backup: backup anonymous keytab
martbab commented:
"""
master:
* 8fb61a55fe32438752567bde8af73d6b8230a386 backup: backup anonymous keytab
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/563
Author: MartinBasti
Title: #563: backup: backup anonymous keytab
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/563/head:pr563
git checkout pr563
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/563
Title: #563: backup: backup anonymous keytab
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/564
Author: martbab
Title: #564: Reconfigure Kerberos library config as the last step of KDC
install
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/564
URL: https://github.com/freeipa/freeipa/pull/564
Author: martbab
Title: #564: Reconfigure Kerberos library config as the last step of KDC
install
Action: opened
PR body:
"""
During KDC installation, we overwrite the existing `/etc/krb5.conf` file
from client version to use
URL: https://github.com/freeipa/freeipa/pull/555
Author: martbab
Title: #555: ipa-managed-entries: use server-mode API
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/555/head:pr555
git checkout pr555
From
URL: https://github.com/freeipa/freeipa/pull/555
Author: martbab
Title: #555: ipa-managed-entries: use server-mode API
Action: opened
PR body:
"""
During LDAP connection management refactoring the ad-hoc ldap connection
in `ipa-managed-entries` was replaced by calls to ldap2
URL: https://github.com/freeipa/freeipa/pull/300
Author: pvomacka
Title: #300: WebUI: Add support for custom table pagination size
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/300/head:pr300
git checkout
URL: https://github.com/freeipa/freeipa/pull/300
Title: #300: WebUI: Add support for custom table pagination size
martbab commented:
"""
master:
* 7b699105a52d4d8c26a73044ba182d752b4a9833 Add javascript integer validator
* f78cc8932626de667c6e3a4461141a10a5d9c2e6 Make single
URL: https://github.com/freeipa/freeipa/pull/300
Title: #300: WebUI: Add support for custom table pagination size
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/552
Author: MartinBasti
Title: #552: man: add missing --setup-adtrust option to manpage
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/552/head:pr552
git checkout
URL: https://github.com/freeipa/freeipa/pull/552
Title: #552: man: add missing --setup-adtrust option to manpage
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/552
Title: #552: man: add missing --setup-adtrust option to manpage
martbab commented:
"""
master:
* 6c95f33d37a2c346fc56d9890d594f1e40029c77 man: add missing --setup-adtrust
option to manpage
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/552
Title: #552: man: add missing --setup-adtrust option to manpage
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/420
Author: martbab
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/420
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals
martbab commented:
"""
@abbra I have a question regarding one of your comments, please review.
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/537
Author: Rezney
Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/537/head:pr537
git
URL: https://github.com/freeipa/freeipa/pull/537
Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/537
Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator
martbab commented:
"""
master:
* 83e2c2b65eeb5a3aa4a59c0535e9177aac5e4637 test_csrgen: adjusted comparison
test scripts for CSRGenerator
"&quo
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals
martbab commented:
"""
@abbra can you also have a quick look at this PR if it is OK from the trusted
user login perspective?
"""
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
I like the second approach better. If you squash the commits I will Ack the PR.
I still think we need a substantial reorganization of the test suites
URL: https://github.com/freeipa/freeipa/pull/479
Author: martbab
Title: #479: Merge AD trust installer into composite ones
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/479/head:pr479
git checkout pr479
URL: https://github.com/freeipa/freeipa/pull/448
Title: #448: Tests: Basic coverage with tree root domain
martbab commented:
"""
master:
* 10494b1bb34b6ff9c1b810cc0739c761b017202c Tests: Basic coverage with tree root
domain
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/448
Title: #448: Tests: Basic coverage with tree root domain
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/448
Author: gkaihorodova
Title: #448: Tests: Basic coverage with tree root domain
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/448/head:pr448
git checkout pr448
--
URL: https://github.com/freeipa/freeipa/pull/525
Title: #525: Remove import nss from test_ldap
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/525
Title: #525: Remove import nss from test_ldap
martbab commented:
"""
looks like Travis did not mind at all
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/525#issuecomment-28331325
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
Oh my, every time I think about something nice that should work there is some
corner case that ruins it.
I guess that one way to work around it w
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
I am not a big fan of mixing filename matching and markers in this PR. I feel
that using only one of those approaches is a more cleaner soluti
URL: https://github.com/freeipa/freeipa/pull/448
Title: #448: Tests: Basic coverage with tree root domain
martbab commented:
"""
The patch looks ok, let's hope that our CI will play nice with it.
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
martbab commented:
"""
I have added a commit that fixes the choeck for missing dependencies in
composite installers.
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/479
Author: martbab
Title: #479: Merge AD trust installer into composite ones
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/479/head:pr479
git checkout pr479
URL: https://github.com/freeipa/freeipa/pull/420
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals
martbab commented:
"""
Now that privilege separation was implemented I have rebased the PR and request
a proper review of this patch.
"&quo
URL: https://github.com/freeipa/freeipa/pull/420
Author: martbab
Title: #420: Allow login to WebUI using Kerberos aliases/enterprise principals
Action: edited
Changed field: title
Original value:
"""
WIP: Allow login to WebUI using Kerberos aliases/enterprise principals
"
101 - 200 of 752 matches
Mail list logo
