Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-06-07 Thread Simo Sorce
On Thu, 2012-06-07 at 10:56 +0300, Alexander Bokovoy wrote: On Thu, 07 Jun 2012, Martin Kosek wrote: It may have been an issue on my side. I will open a ticket if I hit a unit test error again. I did a next round of review for your patches, I did not find any show-stopper why not to push

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-06-05 Thread Sumit Bose
On Mon, Jun 04, 2012 at 03:32:36PM +0300, Alexander Bokovoy wrote: On Mon, 04 Jun 2012, Martin Kosek wrote: I did another round of testing and this is what I found so far: 1) freeipa.spec.in was missing python-crypto BuildRequires (you fixed that) 2) Unit tests need to be updated,

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-06-05 Thread Richard Megginson
- Original Message - On Mon, Jun 04, 2012 at 03:32:36PM +0300, Alexander Bokovoy wrote: On Mon, 04 Jun 2012, Martin Kosek wrote: I did another round of testing and this is what I found so far: 1) freeipa.spec.in was missing python-crypto BuildRequires (you fixed that) 2)

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-06-04 Thread Martin Kosek
On Thu, 2012-04-12 at 17:16 +0200, Martin Kosek wrote: On Thu, 2012-04-12 at 18:08 +0300, Alexander Bokovoy wrote: Hi Martin! On Thu, 12 Apr 2012, Martin Kosek wrote: ... 3) I would not try to import ipaserver.dcerpc every time the command is executed: +try: +

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-05-04 Thread Martin Kosek
On Thu, 2012-05-03 at 08:31 -0700, Nathan Kinder wrote: On 05/03/2012 08:18 AM, Martin Kosek wrote: On Thu, 2012-04-26 at 15:18 +0200, Martin Kosek wrote: On Fri, 2012-04-20 at 08:39 +0200, Martin Kosek wrote: On Thu, 2012-04-12 at 17:16 +0200, Martin Kosek wrote: On Thu, 2012-04-12 at

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-05-03 Thread Martin Kosek
On Thu, 2012-04-26 at 15:18 +0200, Martin Kosek wrote: On Fri, 2012-04-20 at 08:39 +0200, Martin Kosek wrote: On Thu, 2012-04-12 at 17:16 +0200, Martin Kosek wrote: On Thu, 2012-04-12 at 18:08 +0300, Alexander Bokovoy wrote: Hi Martin! On Thu, 12 Apr 2012, Martin Kosek wrote:

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-04-20 Thread Martin Kosek
On Thu, 2012-04-12 at 17:16 +0200, Martin Kosek wrote: On Thu, 2012-04-12 at 18:08 +0300, Alexander Bokovoy wrote: Hi Martin! On Thu, 12 Apr 2012, Martin Kosek wrote: ... 3) I would not try to import ipaserver.dcerpc every time the command is executed: +try: +

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-04-12 Thread Martin Kosek
On Tue, 2012-04-03 at 16:57 +0200, Sumit Bose wrote: On Tue, Apr 03, 2012 at 01:41:35PM +0300, Alexander Bokovoy wrote: Hi! Attached are the current patches for adding support for Active Directory trusts for FreeIPA v3 (master). These are tested and working with samba4 build

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-04-12 Thread Alexander Bokovoy
Hi Martin! On Thu, 12 Apr 2012, Martin Kosek wrote: Hello Alexander, I read the patches with focus on Python parts, please check my comments. freeipa-abbra-0042-ticket-2192.patch: 1) s4u2proxy records that you add for new replicas should also be removed during replica uninstall. Otherwise you

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-04-12 Thread Martin Kosek
On Thu, 2012-04-12 at 18:08 +0300, Alexander Bokovoy wrote: Hi Martin! On Thu, 12 Apr 2012, Martin Kosek wrote: ... 3) I would not try to import ipaserver.dcerpc every time the command is executed: +try: +import ipaserver.dcerpc +except Exception, e: +

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-04-03 Thread Sumit Bose
On Tue, Apr 03, 2012 at 01:41:35PM +0300, Alexander Bokovoy wrote: Hi! Attached are the current patches for adding support for Active Directory trusts for FreeIPA v3 (master). These are tested and working with samba4 build available in ipa-devel@ repo. You have to use --delegate until