Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-12-07 Thread Petr Vobornik
Summary to maintain order in the list: This effort was split into patches: freeipa-pvoborni-0030-Extending-facet-s-mechanism-of-gathering-changes freeipa-pvoborni-0045-Code-cleanup-of-HBAC-Sudo-rules.patch - a part of greater UI refactoring effort ticket #2040 (patches 32-49). Patches

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-28 Thread Adam Young
On 10/27/2011 08:55 PM, Endi Sukma Dewata wrote: On 10/27/2011 6:39 PM, Adam Young wrote: We might need to distinguish 2 different usages of 'entity'. The first one represents a collection of entries: Call that an instance. Entity is the term that is the analogue of Class Not sure I

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-27 Thread Petr Vobornik
I'll rebase this patch on recent patches (which will be soon pushed). This effort is doing too many things, I'll split the patch into several. On 10/25/2011 07:57 PM, Endi Sukma Dewata wrote: On 10/25/2011 7:49 AM, Petr Vobornik wrote: 2. The set_facet() is added to widget. I don't think we

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 8:39 AM, Petr Vobornik wrote: But still I think it would be better to be able to get container (facet/dialog) for a widget. As you wrote, that.entity.get_facet() may not always be what we want. One possibility is to convert the facet dialog into subclasses of an abstract

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-27 Thread Adam Young
On 10/27/2011 05:51 PM, Endi Sukma Dewata wrote: On 10/27/2011 8:39 AM, Petr Vobornik wrote: But still I think it would be better to be able to get container (facet/dialog) for a widget. As you wrote, that.entity.get_facet() may not always be what we want. One possibility is to convert the

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-25 Thread Petr Vobornik
Comments in text. New patch not supplied yet - some topics may require further discussion. Most of the comments should be part of the 'Nesting widgets' thread. On 10/24/2011 06:29 PM, Endi Sukma Dewata wrote: On 10/24/2011 3:29 AM, Petr Vobornik wrote:

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-25 Thread Endi Sukma Dewata
On 10/25/2011 7:49 AM, Petr Vobornik wrote: 2. The set_facet() is added to widget. I don't think we want to make widget dependent on facet. The facet so far is only used by IPA.sudo.enable_widget. In IPA.sudo.options_section the facet object is passed as a parameter in spec. Are you saying

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-24 Thread Endi Sukma Dewata
On 10/24/2011 3:29 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1515 Changes: * Added functionality for widget composition. This allows to gather update information from nested widgets and gradually combine it to the facet level. * Details' facet update method was split to