Re: [Freeipa-devel] [PATCH] 240-252 AMD modules and Web UI build

2013-02-21 Thread Petr Vobornik
On 01/18/2013 03:16 PM, Petr Vobornik wrote: On 01/18/2013 03:11 AM, Endi Sukma Dewata wrote: On 1/17/2013 8:01 PM, Petr Vobornik wrote: On 01/17/2013 04:24 AM, Endi Sukma Dewata wrote: Nice work! They seem to be working fine so it's ACKed. I found a little error - there is a jsl problem in

Re: [Freeipa-devel] [PATCH] 240-252 AMD modules and Web UI build

2013-01-18 Thread Petr Vobornik
On 01/18/2013 03:11 AM, Endi Sukma Dewata wrote: On 1/17/2013 8:01 PM, Petr Vobornik wrote: On 01/17/2013 04:24 AM, Endi Sukma Dewata wrote: Nice work! They seem to be working fine so it's ACKed. I found a little error - there is a jsl problem in dojo.profile:86 - comma at the end of a list.

Re: [Freeipa-devel] [PATCH] 240-252 AMD modules and Web UI build

2013-01-17 Thread Endi Sukma Dewata
On 1/17/2013 8:01 PM, Petr Vobornik wrote: On 01/17/2013 04:24 AM, Endi Sukma Dewata wrote: Nice work! They seem to be working fine so it's ACKed. I found a little error - there is a jsl problem in dojo.profile:86 - comma at the end of a list. Updated patch 243 attached. ACK. I have some

Re: [Freeipa-devel] [PATCH] 240-252 AMD modules and Web UI build

2013-01-16 Thread Endi Sukma Dewata
On 1/8/2013 11:46 PM, Petr Vobornik wrote: This patchset does following things: * integrates Dojo library into FreeIPA Web UI * encapsulates UI parts by AMD definition so they can be used in build process and by AMD loader * introduces Dojo builder for building Web UI and UglifyJS for