Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-10-16 Thread Petr Vobornik
On 10/15/2013 01:51 PM, Ana Krivokapic wrote: On 10/02/2013 12:45 PM, Petr Vobornik wrote: On 09/27/2013 09:16 AM, Ana Krivokapic wrote: On 08/30/2013 05:21 PM, Petr Vobornik wrote: snip https://fedorahosted.org/freeipa/ticket/3798 I tested the patch and it seems to work fine. Code-wise

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-10-15 Thread Ana Krivokapic
On 10/02/2013 12:45 PM, Petr Vobornik wrote: > On 09/27/2013 09:16 AM, Ana Krivokapic wrote: >> On 08/30/2013 05:21 PM, Petr Vobornik wrote: > > snip > >>> >>> https://fedorahosted.org/freeipa/ticket/3798 >>> >> >> I tested the patch and it seems to work fine. Code-wise it looks good as >> well. >

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-10-02 Thread Petr Vobornik
On 09/27/2013 09:16 AM, Ana Krivokapic wrote: On 08/30/2013 05:21 PM, Petr Vobornik wrote: snip https://fedorahosted.org/freeipa/ticket/3798 I tested the patch and it seems to work fine. Code-wise it looks good as well. Nitpick: There is an unused function 'updated()' in the new loader.j

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-09-27 Thread Ana Krivokapic
On 08/30/2013 05:21 PM, Petr Vobornik wrote: > Issue: > * There was no caching policy specified. > * -> Browsers use their own default policy. > * -> After upgrade, some Web UI files might have been actualized some not. > * -> With schema change may result into weird bugs in Web UI > > Solution con

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-09-02 Thread Jan Pazdziora
On Mon, Sep 02, 2013 at 10:57:14AM +0200, Petr Vobornik wrote: > > > >Couldn't you make this a build time thing, marking the links with the > >version with make? > > Would it bring us any benefit at this moment? Less logic in runtime. > >Alternatively, you could mark them with the hash of > >the

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-09-02 Thread Petr Vobornik
On 09/02/2013 09:42 AM, Jan Pazdziora wrote: On Fri, Aug 30, 2013 at 05:21:36PM +0200, Petr Vobornik wrote: Solution: * Implemented a mini loader which loads basic resources. Dojo loader takes action after Dojo is loaded. * The loader adds a version parameter (?v=__NUM_VERSION__) to all request

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-09-02 Thread Jan Pazdziora
On Fri, Aug 30, 2013 at 05:21:36PM +0200, Petr Vobornik wrote: > > Solution: > * Implemented a mini loader which loads basic resources. Dojo loader > takes action after Dojo is loaded. > * The loader adds a version parameter (?v=__NUM_VERSION__) to all requests. > * Version is defined in the loade

[Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-08-30 Thread Petr Vobornik
Issue: * There was no caching policy specified. * -> Browsers use their own default policy. * -> After upgrade, some Web UI files might have been actualized some not. * -> With schema change may result into weird bugs in Web UI Solution considerations: 1. Detect server version change and hard-re