On Tue, 29 Nov 2011, Simo Sorce wrote:
Found a couple of memleaks while reviewing code.
Attached.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
From 70840691e48e1ac89002499c08a9dd4fdcae7c50 Mon Sep 17 00:00:00 2001
From: Simo Sorce sso...@redhat.com
Date: Sun, 20 Nov 2011 20:50:11
On Fri, 2011-12-02 at 16:04 +0200, Alexander Bokovoy wrote:
On Tue, 29 Nov 2011, Simo Sorce wrote:
Found a couple of memleaks while reviewing code.
Attached.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
From 70840691e48e1ac89002499c08a9dd4fdcae7c50 Mon Sep 17 00:00:00
On Fri, 02 Dec 2011, Simo Sorce wrote:
memset(pac_info, 0, sizeof(pac_info));
pac_info.logon_info.info = talloc_zero(tmpctx, struct
PAC_LOGON_INFO);
if (!tmpctx) {
Here is an issue -- you are allocating off tmpctx which is not empty
here (we checked it right above)
Simo Sorce wrote:
I lost count of how many patches I handled, and to be honest I think
this naming convention sucks a bit.
I would be ok changing the number to match a ticket number perhaps, when
there is a ticket attached to it, but for patches like this one all you
really-need it to append a
On Fri, 2011-12-02 at 16:39 +0200, Alexander Bokovoy wrote:
On Fri, 02 Dec 2011, Simo Sorce wrote:
memset(pac_info, 0, sizeof(pac_info));
pac_info.logon_info.info = talloc_zero(tmpctx, struct
PAC_LOGON_INFO);
if (!tmpctx) {
Here is an issue -- you are allocating
Found a couple of memleaks while reviewing code.
Attached.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
From 70840691e48e1ac89002499c08a9dd4fdcae7c50 Mon Sep 17 00:00:00 2001
From: Simo Sorce sso...@redhat.com
Date: Sun, 20 Nov 2011 20:50:11 -0500
Subject: [PATCH] ipa-kdb: fix memleaks in
