Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-31 Thread Martin Kosek
On 05/30/2013 04:35 PM, Tomas Babej wrote: On 05/29/2013 12:25 PM, Martin Kosek wrote: On 05/28/2013 03:48 PM, Alexander Bokovoy wrote: On Tue, 28 May 2013, Tomas Babej wrote: On 05/28/2013 02:35 PM, Alexander Bokovoy wrote: On Mon, 27 May 2013, Tomas Babej wrote: We got rid of openldap

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-30 Thread Tomas Babej
On 05/29/2013 12:25 PM, Martin Kosek wrote: On 05/28/2013 03:48 PM, Alexander Bokovoy wrote: On Tue, 28 May 2013, Tomas Babej wrote: On 05/28/2013 02:35 PM, Alexander Bokovoy wrote: On Mon, 27 May 2013, Tomas Babej wrote: We got rid of openldap utilities now. While using python.ldap module,

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-29 Thread Martin Kosek
On 05/28/2013 03:48 PM, Alexander Bokovoy wrote: On Tue, 28 May 2013, Tomas Babej wrote: On 05/28/2013 02:35 PM, Alexander Bokovoy wrote: On Mon, 27 May 2013, Tomas Babej wrote: We got rid of openldap utilities now. While using python.ldap module, I also made the tests much more robust and

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-28 Thread Alexander Bokovoy
On Mon, 27 May 2013, Tomas Babej wrote: We got rid of openldap utilities now. While using python.ldap module, I also made the tests much more robust and added a new test case. In general patches look fine, there is one small nitpick. I'll run tests on Monday and then will provide final ACK.

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-28 Thread Tomas Babej
On 05/28/2013 02:35 PM, Alexander Bokovoy wrote: On Mon, 27 May 2013, Tomas Babej wrote: We got rid of openldap utilities now. While using python.ldap module, I also made the tests much more robust and added a new test case. In general patches look fine, there is one small nitpick. I'll run

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-28 Thread Alexander Bokovoy
On Tue, 28 May 2013, Tomas Babej wrote: On 05/28/2013 02:35 PM, Alexander Bokovoy wrote: On Mon, 27 May 2013, Tomas Babej wrote: We got rid of openldap utilities now. While using python.ldap module, I also made the tests much more robust and added a new test case. In general patches look

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-27 Thread Tomas Babej
On 05/26/2013 08:56 PM, Alexander Bokovoy wrote: On Fri, 24 May 2013, Tomas Babej wrote: On 05/20/2013 04:29 PM, Alexander Bokovoy wrote: On Mon, 20 May 2013, Tomas Babej wrote: On 05/16/2013 11:16 AM, Ana Krivokapic wrote: On 05/15/2013 03:41 PM, Tomas Babej wrote: Hi, When removing an ID

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-24 Thread Tomas Babej
On 05/20/2013 04:29 PM, Alexander Bokovoy wrote: On Mon, 20 May 2013, Tomas Babej wrote: On 05/16/2013 11:16 AM, Ana Krivokapic wrote: On 05/15/2013 03:41 PM, Tomas Babej wrote: Hi, When removing an ID range using idrange-del command, validation in pre_callback ensures that the range does

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-20 Thread Tomas Babej
On 05/16/2013 11:16 AM, Ana Krivokapic wrote: On 05/15/2013 03:41 PM, Tomas Babej wrote: Hi, When removing an ID range using idrange-del command, validation in pre_callback ensures that the range does not belong to any active trust. In such case, ValidationError is raised.

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-20 Thread Alexander Bokovoy
On Mon, 20 May 2013, Tomas Babej wrote: On 05/16/2013 11:16 AM, Ana Krivokapic wrote: On 05/15/2013 03:41 PM, Tomas Babej wrote: Hi, When removing an ID range using idrange-del command, validation in pre_callback ensures that the range does not belong to any active trust. In such case,

Re: [Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-16 Thread Ana Krivokapic
On 05/15/2013 03:41 PM, Tomas Babej wrote: Hi, When removing an ID range using idrange-del command, validation in pre_callback ensures that the range does not belong to any active trust. In such case, ValidationError is raised. https://fedorahosted.org/freeipa/ticket/3615 Tomas

[Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

2013-05-15 Thread Tomas Babej
Hi, When removing an ID range using idrange-del command, validation in pre_callback ensures that the range does not belong to any active trust. In such case, ValidationError is raised. https://fedorahosted.org/freeipa/ticket/3615 Tomas From 72a55d498602b5c6cc912eb9585dc860b7fee591 Mon Sep 17