Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

ACK Pushed to master: 12e7f71600e62eab9d48a13fba37d2f182c8bdee On 09.12.2015 14:44, Gabe Alford wrote: Fixed. Updated patch attached. On Wed, Dec 9, 2015 at 2:37 AM, Martin Basti > wrote: NACK Patch contains syntax error, missing brace ipaserver/instal

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

Fixed. Updated patch attached. On Wed, Dec 9, 2015 at 2:37 AM, Martin Basti wrote: > NACK > > Patch contains syntax error, missing brace > > ipaserver/install/server/replicainstall.py:850: [E0001(syntax-error), ] > invalid syntax) > > Martin > > > On 09.12.2015 07:08, Jan Cholasta wrote: > >> LG

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

NACK Patch contains syntax error, missing brace ipaserver/install/server/replicainstall.py:850: [E0001(syntax-error), ] invalid syntax) Martin On 09.12.2015 07:08, Jan Cholasta wrote: LGTM On 8.12.2015 17:04, Gabe Alford wrote: Updated patch attached. On Tue, Dec 8, 2015 at 8:27 AM, Mart

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

LGTM On 8.12.2015 17:04, Gabe Alford wrote: Updated patch attached. On Tue, Dec 8, 2015 at 8:27 AM, Martin Basti mailto:mba...@redhat.com>> wrote: On 08.12.2015 16:26, Gabe Alford wrote: Just to confirm: if server is installed: Let's stop here and not do anything else

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

Updated patch attached. On Tue, Dec 8, 2015 at 8:27 AM, Martin Basti wrote: > > > On 08.12.2015 16:26, Gabe Alford wrote: > > Just to confirm: > > if server is installed: > Let's stop here and not do anything else > > if domain level 0: > check if client installed and stop here > > Rig

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

Just to confirm: if server is installed: Let's stop here and not do anything else if domain level 0: check if client installed and stop here Right? On Tue, Dec 8, 2015 at 8:20 AM, Jan Cholasta wrote: > On 8.12.2015 16:17, Martin Basti wrote: > >> >> >> On 08.12.2015 16:14, Jan Chol

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

On 08.12.2015 16:26, Gabe Alford wrote: Just to confirm: if server is installed: Let's stop here and not do anything else if domain level 0: check if client installed and stop here Right? yes On Tue, Dec 8, 2015 at 8:20 AM, Jan Cholasta > wrote:

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

On 08.12.2015 16:14, Jan Cholasta wrote: On 8.12.2015 16:09, Martin Basti wrote: On 01.12.2015 14:57, Gabe Alford wrote: Sorry guys, I forgot to add a meaningful subject to this message. Ignore the previous thread start. -- Forwarded message -- From: *Gabe Alford*

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

On 8.12.2015 16:17, Martin Basti wrote: On 08.12.2015 16:14, Jan Cholasta wrote: On 8.12.2015 16:09, Martin Basti wrote: On 01.12.2015 14:57, Gabe Alford wrote: Sorry guys, I forgot to add a meaningful subject to this message. Ignore the previous thread start. -- Forwarded message

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

On 8.12.2015 16:09, Martin Basti wrote: On 01.12.2015 14:57, Gabe Alford wrote: Sorry guys, I forgot to add a meaningful subject to this message. Ignore the previous thread start. -- Forwarded message -- From: *Gabe Alford* mailto:redhatri...@gmail.com>> Date: Mon, Nov 30, 201

Re: [Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

On 01.12.2015 14:57, Gabe Alford wrote: Sorry guys, I forgot to add a meaningful subject to this message. Ignore the previous thread start. -- Forwarded message -- From: *Gabe Alford* mailto:redhatri...@gmail.com>> Date: Mon, Nov 30, 2015 at 7:31 PM Subject: [PATCH 0065] To: f

[Freeipa-devel] [PATCH 0065] ipa-replica-install prints incorrect error message when replica is already installed

Sorry guys, I forgot to add a meaningful subject to this message. Ignore the previous thread start. -- Forwarded message -- From: Gabe Alford Date: Mon, Nov 30, 2015 at 7:31 PM Subject: [PATCH 0065] To: freeipa-devel Hello, Patch fix for the following tickets: https://fedorah