Re: [Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

2016-01-20 Thread Jan Cholasta
Hi, On 19.1.2016 13:43, Martin Basti wrote: New pylint version will broke our custom make-lint script again, attached patch migrates make-lint to: * config file * pylint plugin which are supported by pylint and should not have regular compatibility issues to test new approach run ./make-lint2

[Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

2016-01-19 Thread Martin Basti
New pylint version will broke our custom make-lint script again, attached patch migrates make-lint to: * config file * pylint plugin which are supported by pylint and should not have regular compatibility issues to test new approach run ./make-lint2 Advantages: * compatibility with pylint *

Re: [Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

2016-01-19 Thread Christian Heimes
On 2016-01-19 13:43, Martin Basti wrote: > + > +def fake_class(name_or_class_obj, members=[]): Please use a non-mutable argument here. members=() will do the job just fine. > +if isinstance(name_or_class_obj, scoped_nodes.Class): > +cl = name_or_class_obj > +else: > +cl =

Re: [Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

2016-01-19 Thread Martin Basti
On 19.01.2016 16:34, Christian Heimes wrote: On 2016-01-19 13:43, Martin Basti wrote: + +def fake_class(name_or_class_obj, members=[]): Please use a non-mutable argument here. members=() will do the job just fine. Fixed. +if isinstance(name_or_class_obj, scoped_nodes.Class): +