Re: [Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

Hello, few issues found: 1) There is a change that should not be there: managedby_host=[fqdn1], -ipakrbauthzdata=[u'MS-PAC'], ipauniqueid=[fuzzy_uuid], 2) When raising SkipTest it would be better to pass a reason why we are skipping

[Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

Hi, this patch simply checks if ipa-join exists in ipa-client folder, if not, skips tests relying on it. Uses nose.plugin.skip. https://fedorahosted.org/freeipa/ticket/2905 Tomas BabejFrom 2f7cb184619fddd40c7d141b42d35892b6cd5aff Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com

Re: [Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

On 07/27/2012 01:13 PM, Tomas Babej wrote: Hi, this patch simply checks if ipa-join exists in ipa-client folder, if not, skips tests relying on it. Uses nose.plugin.skip. https://fedorahosted.org/freeipa/ticket/2905 Tomas Babej Hello, This would be better done in class setup, so you