[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-11-28 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message stlaz commented: """ WONTFIX then. There's no winning here. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-263265074 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-11-28 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message mbasti-rh commented: """ I had discussion with @jcholast and he disagrees. This weird handling of DN should stay isolated in vault code and shouldn't be spreaded across the framework. I'm starting

[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-11-25 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message stlaz commented: """ Seems like nobody objected so far. """ See the full comment at https://github.com/freeipa/freeipa/pull/101#issuecomment-262971504 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-09-21 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message mbasti-rh commented: """ Oh realized that is not possible to create DN inside handle_not_found, because it does not take **kwargs Probably we can extend handle_not_found with kwargs, but this

[Freeipa-devel] [freeipa PR#101][comment] Improved vault-show error message

2016-09-21 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message mbasti-rh commented: """ NACK: you fixed only vault-show not other vault-* commands NACK: I don't like the override of execute method (it should work for all vault-* commands automatically) Is