URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
martbab commented:
"""
@jcholast @frasertweedale I hope you did notice those failures in Travis CI
before acking/pushing...
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/c7ea56c049ec8ab1a5500852eca6faf750b1479f
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast right you are. PR updated with conditional import.
Thanks.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
@frasertweedale, I'm afraid we can't do that. As I said in the comment, you
cannot unconditionally import from `ipaplatform` to `ipalib` anymore, so
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
On Sun, Dec 11, 2016 at 10:36:27PM -0800, Jan Cholasta wrote:
> @frasertweedale, thanks. What about
>
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
@frasertweedale, thanks. What about
[this](https://github.com/freeipa/freeipa/pull/177/files#r91243228)?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast updated PR to include `certificate` and `certificate_chain` in
`ca_find` output when `--all` is specified.
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
@frasertweedale, yep, I'm aware of that - `cert-find` does the same. Not a big
deal IMO since it has to be explicitly requested by the user. But
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast returning cert and chain in `ca_find` when `--all` is given will
incur `n * 2` additional round-trips to Dogtag where `n` = number of
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast returning cert and chain in `ca_find` when `--all` is given will
incur `n * 2` additional round-trips to Dogtag. I am hesitant to do
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
Could you make `ca-find` return the cert/chain as well if (and only if) `--all`
is specified? Do not add the `--chain` and `--certificate-out` options
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
But could you make `ca-find` return the cert/chain as well if (and only if)
`--all` is specified? Do not add the `--chain` and `--certificate-out`
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast OK there we go. I'd forgotten to remove the `include='cli'` when
converting to server-side option.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast thanks for review. PR updated. No longer inheriting
`BaseCertObject`. `--chain` now defined
server-side and no longer implies
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@tomaskrizek thanks for reviewing. Updated tests and change the
`--certificate-out` metavar to `FILE`.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
tomaskrizek commented:
"""
Please update the xmlrpc tests to reflect the extra certificate attributes (~12
failed tests in `test_xmlrpc/test_ca_plugin.py`,
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
tiran commented:
"""
pylint fails:
```
Pylint is running, please wait ...
* Module ipalib.x509
ipalib/x509.py:161: [E0602(undefined-variable), pkcs7_to_pems]
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
Bump for review
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/177#issuecomment-259387372
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
jcholast commented:
"""
The original review thread is available at:
https://www.redhat.com/archives/freeipa-devel/2016-October/msg00578.html
"""
See the full comment at
19 matches
Mail list logo
