[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-22 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/68295bf8cfd57333deb50f58df1b336a4b48ffe7

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-21 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn mbasti-rh commented: """ LGTM and Works for me, but I have to make sure that things I wrote inline won''t happen """ See the full comment at

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-21 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn mbasti-rh commented: """ LGTM and Works for me, but I have to make sure that things I wrote inline didn't happen """ See the full comment at

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-21 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn tomaskrizek commented: """ Depends on #262 """ See the full comment at https://github.com/freeipa/freeipa/pull/223#issuecomment-261956124 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-16 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn tomaskrizek commented: """ Fixed the issue + rebased. Only the second commit has changed. """ See the full comment at https://github.com/freeipa/freeipa/pull/223#issuecomment-260995772 -- Manage

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn mbasti-rh commented: """ ACK: removing admin_conn connections - just for future, python doesn't like to have too many dereference from performance point fo view. So you should in future use ldap =

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn mbasti-rh commented: """ Works for me, I'll check code tomorrow """ See the full comment at https://github.com/freeipa/freeipa/pull/223#issuecomment-260710722 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-15 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn tomaskrizek commented: """ Bump for review. I forgot about this PR, it's a final change from the refactoring effort. """ See the full comment at