On 4/14/2011 12:17 AM, Endi Sukma Dewata wrote:
Attached is an updated version. There are a few more patches in the
pipeline. After that I'll address the I18n labels, integer validation
and builder cleanup.
ACKed on IRC. Replaced integer constants with string. Pushed to master.
--
Endi S.
On 04/12/2011 03:06 PM, Endi Sukma Dewata wrote:
The entitlement facet will show the appropriate buttons depending on
the entitlement status. If it's not registered, the facet will show
a Register button. If it's registered, the facet will show a Consume
button.
On 4/13/2011 9:12 AM, Adam Young wrote:
Please make sure all String literals come from the interal.py messages
plugin. New button labels are defined in entitle.js for Consume and
Register.
I'm thinking to do that once we have all the entitlement functionalities
implemented. There are also
On 04/13/2011 11:03 AM, Endi Sukma Dewata wrote:
On 4/13/2011 9:12 AM, Adam Young wrote:
Please make sure all String literals come from the interal.py messages
plugin. New button labels are defined in entitle.js for Consume and
Register.
I'm thinking to do that once we have all the
On 4/13/2011 10:13 AM, Adam Young wrote:
There's no pattern defined in the metadata for the quantity. There is
an 'int' type though. I think we can add a general purpose type
checking in addition to pattern validation. This can be done in a
separate patch.
We can add a validation rule
On 04/13/2011 11:30 AM, Endi Sukma Dewata wrote:
On 4/13/2011 10:13 AM, Adam Young wrote:
There's no pattern defined in the metadata for the quantity. There is
an 'int' type though. I think we can add a general purpose type
checking in addition to pattern validation. This can be done in a
On 04/13/2011 11:30 AM, Endi Sukma Dewata wrote:
On 4/13/2011 10:13 AM, Adam Young wrote:
There's no pattern defined in the metadata for the quantity. There is
an 'int' type though. I think we can add a general purpose type
checking in addition to pattern validation. This can be done in a
On 4/13/2011 10:33 PM, Adam Young wrote:
BTW, are you planning on updating this patch, or do the validation work
in a follow on patch?
Attached is an updated version. There are a few more patches in the
pipeline. After that I'll address the I18n labels, integer validation
and builder
