Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-07-18 Thread Martin Babinsky
On 07/18/2016 04:59 PM, Lenka Doudova wrote: On 07/18/2016 04:55 PM, Martin Babinsky wrote: On 07/14/2016 11:42 AM, Lenka Doudova wrote: On 07/13/2016 05:40 PM, Martin Babinsky wrote: On 07/01/2016 04:15 PM, Lenka Doudova wrote: On 07/01/2016 02:38 PM, Martin Babinsky wrote: On

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-07-18 Thread Lenka Doudova
On 07/18/2016 04:55 PM, Martin Babinsky wrote: On 07/14/2016 11:42 AM, Lenka Doudova wrote: On 07/13/2016 05:40 PM, Martin Babinsky wrote: On 07/01/2016 04:15 PM, Lenka Doudova wrote: On 07/01/2016 02:38 PM, Martin Babinsky wrote: On 07/01/2016 06:36 AM, Lenka Doudova wrote: On

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-07-14 Thread Lenka Doudova
On 07/13/2016 05:40 PM, Martin Babinsky wrote: On 07/01/2016 04:15 PM, Lenka Doudova wrote: On 07/01/2016 02:38 PM, Martin Babinsky wrote: On 07/01/2016 06:36 AM, Lenka Doudova wrote: On 06/30/2016 05:01 PM, Martin Babinsky wrote: On 06/30/2016 03:47 PM, Lenka Doudova wrote: Hi,

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-07-01 Thread Lenka Doudova
On 07/01/2016 02:38 PM, Martin Babinsky wrote: On 07/01/2016 06:36 AM, Lenka Doudova wrote: On 06/30/2016 05:01 PM, Martin Babinsky wrote: On 06/30/2016 03:47 PM, Lenka Doudova wrote: Hi, attaching patch with some basic coverage for external trust feature. Bit more detailed info in

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-07-01 Thread Martin Babinsky
On 07/01/2016 06:36 AM, Lenka Doudova wrote: On 06/30/2016 05:01 PM, Martin Babinsky wrote: On 06/30/2016 03:47 PM, Lenka Doudova wrote: Hi, attaching patch with some basic coverage for external trust feature. Bit more detailed info in commit message. Since the feature requires me to run

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-06-30 Thread Lenka Doudova
On 06/30/2016 05:01 PM, Martin Babinsky wrote: On 06/30/2016 03:47 PM, Lenka Doudova wrote: Hi, attaching patch with some basic coverage for external trust feature. Bit more detailed info in commit message. Since the feature requires me to run commands previously used only for forest root

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-06-30 Thread Martin Babinsky
On 06/30/2016 03:47 PM, Lenka Doudova wrote: Hi, attaching patch with some basic coverage for external trust feature. Bit more detailed info in commit message. Since the feature requires me to run commands previously used only for forest root domains even for subdomains, I made some changes in

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-06-30 Thread Lenka Doudova
On 06/30/2016 04:12 PM, Oleg Fayans wrote: Hi Lenka, The changes in test_trust.py are fine. As for tasks.py: 1. I'd rename sync_time_hostname to just sync_time and There's already one sync_time function with different contents, it seemed nicer to create a new function than adding some

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-06-30 Thread Oleg Fayans
Hi Lenka, The changes in test_trust.py are fine. As for tasks.py: 1. I'd rename sync_time_hostname to just sync_time and 2. I would start ntpd again in the same method: it's no good to keep this thing in mind each time you call it. Besides, I would split the changes into 2 patches: one for

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-06-30 Thread Martin Babinsky
On 06/30/2016 04:12 PM, Oleg Fayans wrote: Hi Lenka, The changes in test_trust.py are fine. As for tasks.py: 1. I'd rename sync_time_hostname to just sync_time and 2. I would start ntpd again in the same method: it's no good to keep this thing in mind each time you call it. If you start ntpd