Re: [Freeipa-devel] [PATCH] 714 fix dogtag installation

2011-02-11 Thread Jakub Hrozek
On Thu, Feb 10, 2011 at 10:17:18PM -0500, Rob Crittenden wrote: Reset file ownership after calling update_file() and set_preference() in installutils. Out of the blue these would change file ownership to root:root which was breaking a dogtag profile. This fixes the error from cert-request:

Re: [Freeipa-devel] [PATCH] 712 drop kw from JSON error

2011-02-11 Thread Jakub Hrozek
On Thu, Feb 10, 2011 at 01:39:40PM -0500, Rob Crittenden wrote: The kw could contain another exception which was blowing up the marshalling. It doesn't seem to be used anywhere and contains information we've already saved in error as far as I can tell. ticket 905 rob Ack

[Freeipa-devel] [PATCH] 051 Remove obsolete record types from DNS

2011-02-11 Thread Jakub Hrozek
https://fedorahosted.org/freeipa/ticket/923 From 5fdd046fb631a9c57cf6e9c6c98ee09e2cd77a6d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Thu, 10 Feb 2011 21:17:21 +0100 Subject: [PATCH] Remove obsolete record types from DNS https://fedorahosted.org/freeipa/ticket/923 ---

[Freeipa-devel] [PATCH] fix build

2011-02-11 Thread Rob Crittenden
We were missing a BuildRequires for pyOpenSSL that was causing the build to fail in mock. This fixes a build failure, pushed as a 1-liner. diff --git a/freeipa.spec.in b/freeipa.spec.in index 729c7a2..69945db 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -51,6 +51,7 @@ BuildRequires:

Re: [Freeipa-devel] [PATCH] 714 fix dogtag installation

2011-02-11 Thread Rob Crittenden
Jakub Hrozek wrote: On Thu, Feb 10, 2011 at 10:17:18PM -0500, Rob Crittenden wrote: Reset file ownership after calling update_file() and set_preference() in installutils. Out of the blue these would change file ownership to root:root which was breaking a dogtag profile. This fixes the error

Re: [Freeipa-devel] Help define the roles IPA has by default

2011-02-11 Thread Rob Crittenden
Dmitri Pal wrote: On 02/10/2011 07:25 PM, David O'Brien wrote: Dmitri Pal wrote: On 02/10/2011 03:05 PM, Jakub Hrozek wrote: On 02/10/2011 05:12 PM, Rob Crittenden wrote: But what other roles do we need? The mind boggles and rather than dictating what the initial ones will be I'm looking for

Re: [Freeipa-devel] [PATCH] 028 Extend API validator

2011-02-11 Thread Rob Crittenden
Martin Kosek wrote: makeapi script is used to check if ipalib API is consistent with the known state in API.txt. When the API is changed, major API version should be updated. However, when new options/arguments/outputs were added to an ipalib command, `makeapi --validate' call did not capture

Re: [Freeipa-devel] [PATCH] 029 ipa-dns-install does not exit on error

2011-02-11 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2011-02-10 at 13:58 -0500, Rob Crittenden wrote: Martin Kosek wrote: This patch fixes behavior of ipa-dns-install, which does not exit when an invalid configuration of /etc/hosts is detected. https://fedorahosted.org/freeipa/ticket/736 I'm not positive but was

Re: [Freeipa-devel] [PATCH] 708 move nscd disablement code

2011-02-11 Thread Rob Crittenden
Jakub Hrozek wrote: On Wed, Feb 09, 2011 at 01:57:46PM -0500, Rob Crittenden wrote: Disable nscd before starting sssd. We used to disable it after configuring sssd which would cause a warning message to appear in /var/log/messages from sssd. This was in effect bogus because we killed nscd as

Re: [Freeipa-devel] [PATCH] 709 set minimum version of sssd to 1.5.1.

2011-02-11 Thread Rob Crittenden
Jakub Hrozek wrote: On Wed, Feb 09, 2011 at 02:27:54PM -0500, Rob Crittenden wrote: Title says it all. ticket 926 rob Ack pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 712 drop kw from JSON error

2011-02-11 Thread Rob Crittenden
Jakub Hrozek wrote: On Thu, Feb 10, 2011 at 01:39:40PM -0500, Rob Crittenden wrote: The kw could contain another exception which was blowing up the marshalling. It doesn't seem to be used anywhere and contains information we've already saved in error as far as I can tell. ticket 905 rob Ack

[Freeipa-devel] [PATCH] 716 ignore case when removing members

2011-02-11 Thread Rob Crittenden
Ignore case when removing members from a group. ticket 944 rob freeipa-rcrit-716-member.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] Help define the roles IPA has by default

2011-02-11 Thread Dmitri Pal
On 02/11/2011 10:12 AM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/10/2011 07:25 PM, David O'Brien wrote: Dmitri Pal wrote: On 02/10/2011 03:05 PM, Jakub Hrozek wrote: On 02/10/2011 05:12 PM, Rob Crittenden wrote: But what other roles do we need? The mind boggles and rather than

Re: [Freeipa-devel] [PATCH] admiyo-0191-target-section-without-radio-buttons

2011-02-11 Thread Adam Young
On 02/10/2011 06:46 PM, Endi Sukma Dewata wrote: On 2/10/2011 5:02 PM, Adam Young wrote: On 02/10/2011 04:42 PM, Endi Sukma Dewata wrote: On 2/10/2011 3:27 PM, Adam Young wrote: NACK. As discussed over IRC, the is_dirty functionality is not working for permissions that have an object by

Re: [Freeipa-devel] [PATCH] admiyo-0192-column-formatting

2011-02-11 Thread Adam Young
On 02/10/2011 06:35 PM, Endi Sukma Dewata wrote: On 2/10/2011 5:00 PM, Adam Young wrote: Should we use one of these functions? http://www.w3schools.com/jsref/jsref_tostring_date.asp http://www.w3schools.com/jsref/jsref_tolocalestring.asp http://www.w3schools.com/jsref/jsref_toutcstring.asp

Re: [Freeipa-devel] [PATCH] 76 Fallback to default locale (en_US) if env. setting is corrupt.

2011-02-11 Thread Rob Crittenden
Pavel Zuna wrote: This is a follow-up to my patches 69 and 71 (70 is garbage). It prevents a crash when user misconfigures his locale settings. Pavel The trio of patches work great but some of the unit tests break, can you take a look at those? rob

Re: [Freeipa-devel] [PATCH] 050 Fix migration page

2011-02-11 Thread Rob Crittenden
Pavel Zuna wrote: On 02/09/2011 02:09 PM, Jakub Hrozek wrote: During some UI rewrite, the password migration form completely lost the action= field and defaulted to GET instead of POST. ACK. Pavel pushed to master ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] 717 Add replace to ipa-ldap-updater

2011-02-11 Thread Rob Crittenden
Add a replace verb to ipa-ldap-updater so an existing value can be replaced, but only if the value matches the old value in the update. This would be used for us to replace default values that the end-user hasn't already updated. The first one of these would be for the kerberos password

Re: [Freeipa-devel] [PATCH] 711 Convert json strings to unicode

2011-02-11 Thread Endi Sukma Dewata
On 2/10/2011 12:34 PM, Rob Crittenden wrote: Convert json strings to unicode when they are unmarshalled. This patch removes some individual work-arounds of converting strings to unicode, they only masked the problem. String values are not passed to the validator or normalizers so things like

[Freeipa-devel] [PATCH] 718 move files in packages

2011-02-11 Thread Rob Crittenden
Move a bunch of utilities that really only make sense to be run on the server from the admintools package to the server package. ticket 947 rob freeipa-rcrit-718-spec.patch Description: application/mbox ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] admiyo-0191-target-section-without-radio-buttons

2011-02-11 Thread Endi Sukma Dewata
On 2/11/2011 11:52 AM, Adam Young wrote: Filter not set was due to incomplete filter_text attribute-rights work around undo_span is now wrapped in jquery select, so that it there is no undo, it works correctly. ACK. The filter problem is fixed in 192. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] admiyo-0192-column-formatting

2011-02-11 Thread Endi Sukma Dewata
On 2/11/2011 11:50 AM, Adam Young wrote: Using Date format, but only for GMT ACK. There's one jslint warning. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] admiyo-0191-target-section-without-radio-buttons

2011-02-11 Thread Adam Young
On 02/11/2011 02:28 PM, Endi Sukma Dewata wrote: On 2/11/2011 11:52 AM, Adam Young wrote: Filter not set was due to incomplete filter_text attribute-rights work around undo_span is now wrapped in jquery select, so that it there is no undo, it works correctly. ACK. The filter problem is fixed

Re: [Freeipa-devel] [PATCH] admiyo-0192-column-formatting

2011-02-11 Thread Adam Young
On 02/11/2011 02:29 PM, Endi Sukma Dewata wrote: On 2/11/2011 11:50 AM, Adam Young wrote: Using Date format, but only for GMT ACK. There's one jslint warning. jslint warning fixed. Pushed to master ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] admiyo-0193- allow-null-keys-for-show

2011-02-11 Thread Adam Young
From 3ddcb0e3131f747d81b1a8dfda8078c9739c6f11 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 11 Feb 2011 15:36:29 -0500 Subject: [PATCH] allow null keys for show https://fedorahosted.org/freeipa/ticket/951 --- install/ui/details.js | 12 1 files changed,

Re: [Freeipa-devel] [PATCH] admiyo-0193- allow-null-keys-for-show

2011-02-11 Thread Endi Sukma Dewata
On 2/11/2011 2:38 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 195/195] remove deprecated record types

2011-02-11 Thread Adam Young
-- Adam Young ayo...@redhat.com www.redhat.com From 445e6b72441e7c39f9f6c2f91f46fd25c1633dc3 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 11 Feb 2011 15:50:24 -0500 Subject: [PATCH 195/195] remove deprecated record types --- install/ui/policy.js |6 +++--- 1

[Freeipa-devel] [PATCH] 0082 - fix per/post operation with krb password change

2011-02-11 Thread Simo Sorce
We weren't setting the kerberos metadata when modifying userPassword for a kerberos enabled record. Fixes #949 Simo. -- Simo Sorce * Red Hat, Inc * New York From dbcb72a091dae59adbb23f9df176fae4daef9cea Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 11 Feb 2011

Re: [Freeipa-devel] [PATCH 195/195] remove deprecated record types

2011-02-11 Thread Simo Sorce
On Fri, 11 Feb 2011 15:53:49 -0500 Adam Young ayo...@redhat.com wrote: ACK -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 195/195] remove deprecated record types

2011-02-11 Thread Adam Young
On 02/11/2011 04:10 PM, Simo Sorce wrote: On Fri, 11 Feb 2011 15:53:49 -0500 Adam Youngayo...@redhat.com wrote: ACK Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 052 Fine tuning DNS options

2011-02-11 Thread Jakub Hrozek
Simo did a nice writeup of the changes in https://fedorahosted.org/freeipa/ticket/931 From d27c228160b5bfc460055392389e2ba966263709 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Thu, 10 Feb 2011 21:47:45 +0100 Subject: [PATCH] Fine tuning DNS options Add pointer to self to

Re: [Freeipa-devel] [PATCH] Fixed add service dialog box.

2011-02-11 Thread Adam Young
On 02/10/2011 04:45 PM, Endi Sukma Dewata wrote: Previously the add service dialog box shows a 'Principal:' label with no text field next to it. It now has been removed. The dialog box has been widened to avoid line wrapping of the buttons. ___

[Freeipa-devel] [PATCH] 719 permission for cn=ipaconfig

2011-02-11 Thread Rob Crittenden
Add permission and privilege for updating the IPA configuration in cn=ipaconfig. ticket 950 rob freeipa-rcrit-719-permission.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 721 fix cert-show

2011-02-11 Thread Rob Crittenden
The --out option wasn't working at all with cert-show. Also fix some related problems in write_certificate(), handle either a DER or base64-formatted incoming certificate and don't explode if the filename is None. ticket 954 rob freeipa-rcrit-721-cert.patch Description: application/mbox

[Freeipa-devel] [PATCH] admiyo-0196-DNS-record-search.

2011-02-11 Thread Adam Young
From ccae52028bdea318229d343aed6c3b5bd14fb184 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 11 Feb 2011 20:40:01 -0500 Subject: [PATCH] DNS record search The current version of the DNS Plugin does not support searching by record, so that is commented out. The search

Re: [Freeipa-devel] [PATCH] 712 drop kw from JSON error

2011-02-11 Thread Adam Young
On 02/11/2011 10:37 AM, Rob Crittenden wrote: Jakub Hrozek wrote: On Thu, Feb 10, 2011 at 01:39:40PM -0500, Rob Crittenden wrote: The kw could contain another exception which was blowing up the marshalling. It doesn't seem to be used anywhere and contains information we've already saved in