Re: [Freeipa-devel] [PATCH] 165 Polish ipa config help

2011-11-14 Thread Martin Kosek
On Fri, 2011-11-11 at 13:29 -0500, Rob Crittenden wrote: Martin Kosek wrote: Remove config-mod options help from config module help to keep the option doc on one place and without unnecessary redundancy. The new format is more consistent with the rest of the plugins. Also fix several

[Freeipa-devel] [PATCH] 0032 Validate sudo RunAsUser/RunAsGroup arguments

2011-11-14 Thread Alexander Bokovoy
Hi, FreeIPA SUDO rules use --usercat/--groupcat to specify that rule applies to all users or groups. Thus, sudorule-add-runasuser and sudorule-add-runasgroup accept specific groups and users and do not accept ALL reserved word. The patch validates user and group passed to these commands and

Re: [Freeipa-devel] [PATCH] 166+167 Zonemgr improvements

2011-11-14 Thread Martin Kosek
On Fri, 2011-11-11 at 10:22 -0500, Rob Crittenden wrote: Martin Kosek wrote: There are 2 patches improving our zone zonemgr: 1) ipa-server-install --zonemgr option validation and normalization + the same thing in ipa dnszone-add/mod --admin-email. They now allow and correctly process

Re: [Freeipa-devel] [PATCH] 162 Fix coverity issues in client CLI tools

2011-11-14 Thread Martin Kosek
On Fri, 2011-11-11 at 13:41 -0500, Rob Crittenden wrote: Martin Kosek wrote: This patch fixes 2 coverity issues: * ipa-client/config.c: CID 11090: Resource leak * ipa-client/ipa-getkeytab.c: CID 11018: Unchecked return value https://fedorahosted.org/freeipa/ticket/2035 You don't

[Freeipa-devel] [PATCH] 0033 Check all LDAP servers during IPA discovery

2011-11-14 Thread Alexander Bokovoy
Hi, This is patch proposal, I haven't checked it with multiple servers setup yet. When discovering IPA LDAP servers through DNS records, look through all servers found until first success. A master might be not available or denied access due to anonymous binds disabled, for example, but

Re: [Freeipa-devel] [PATCH] ipa-client-install with --no-sssd option should check for nss_ldap

2011-11-14 Thread Ondrej Hamada
On 11/11/2011 02:55 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2063 In order to check presence of nss_ldap when installing client with '--no-sssd' option there was added code into ipa-client-install. Check is base on existence of nss_ldap configuration files. This

[Freeipa-devel] [PATCH] 169 Fix LDAP object parameter encoding

2011-11-14 Thread Martin Kosek
Tests are now OK, there were a lot of errors related to permissions and hosts (--random was always on). I was also thinking if the encoding step shouldn't be done as late as possible, i.e. after plugin's pre_callbacks, right before LDAP is called. Now, we do encoding right in the beginning of

[Freeipa-devel] [PATCH] 312 Refactored permission target section.

2011-11-14 Thread Endi Sukma Dewata
The permission target section has been modified to use widgets to create the target selection and handle multiple fields. Ticket #2098 -- Endi S. Dewata From 13696b14ea5b9369d7ee7f8b13647f4d3bacef34 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Fri, 11 Nov 2011 22:33:05

[Freeipa-devel] [PATCH] 313 Removed develop.js.

2011-11-14 Thread Endi Sukma Dewata
The develop.js is no longer necessary because the code in it has been merged into the main code. An empty extension.js has been added to provide a place for UI customization. Ticket #2099 -- Endi S. Dewata From ff67f3ceb8cb272220fb32841e8d1800439e309a Mon Sep 17 00:00:00 2001 From: Endi S.

Re: [Freeipa-devel] [PATCH] 169 Fix LDAP object parameter encoding

2011-11-14 Thread Alexander Bokovoy
On Mon, 14 Nov 2011, Martin Kosek wrote: Tests are now OK, there were a lot of errors related to permissions and hosts (--random was always on). I was also thinking if the encoding step shouldn't be done as late as possible, i.e. after plugin's pre_callbacks, right before LDAP is called.

Re: [Freeipa-devel] [PATCH] 313 Removed develop.js.

2011-11-14 Thread Endi Sukma Dewata
On 11/14/2011 10:37 AM, Endi Sukma Dewata wrote: The develop.js is no longer necessary because the code in it has been merged into the main code. An empty extension.js has been added to provide a place for UI customization. Ticket #2099 Replaced the regex with a variable IPA.url for

[Freeipa-devel] [PATCH] Another trivial doc fix

2011-11-14 Thread Jérôme Fenal
diff --git a/ipalib/plugins/group.py b/ipalib/plugins/group.py index cd4a054..4bf77f8 100644 --- a/ipalib/plugins/group.py +++ b/ipalib/plugins/group.py @@ -28,8 +28,8 @@ Groups of users Manage groups of users. By default, new groups are POSIX groups. You can add the --nonposix option to the

Re: [Freeipa-devel] [PATCH] 312 Refactored permission target section.

2011-11-14 Thread Adam Young
On 11/14/2011 11:27 AM, Endi Sukma Dewata wrote: The permission target section has been modified to use widgets to create the target selection and handle multiple fields. Ticket #2098 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 313 Removed develop.js.

2011-11-14 Thread Adam Young
On 11/14/2011 04:35 PM, Endi Sukma Dewata wrote: On 11/14/2011 10:37 AM, Endi Sukma Dewata wrote: The develop.js is no longer necessary because the code in it has been merged into the main code. An empty extension.js has been added to provide a place for UI customization. Ticket #2099

Re: [Freeipa-devel] [PATCH] 880 don't check for existing 389-ds instances

2011-11-14 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2011-10-21 at 15:29 -0400, Rob Crittenden wrote: Rob Crittenden wrote: We don't need to prohibit existing 389-ds instances when installing IPA, just that the ports we need are available. Remove this check. For master only. rob Re-based patch against master. rob

Re: [Freeipa-devel] [PATCH] #1794 - Speed up replica setup

2011-11-14 Thread Rob Crittenden
JR Aquino wrote: On Oct 7, 2011, at 11:14 AM, Simo Sorce wrote: On Mon, 2011-10-03 at 18:17 -0400, Simo Sorce wrote: On Mon, 2011-10-03 at 16:20 -0400, Simo Sorce wrote: Newer 389ds servers have a new option to have a different set of filtered attributes from normal replication. This has