Re: [Freeipa-devel] [PATCH] 69 Configure SSH features of SSSD in ipa-client-install

2012-03-02 Thread Jan Cholasta
On 2.3.2012 04:56, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:00, Martin Kosek wrote: On Wed, 2012-02-29 at 14:44 +0100, Jan Cholasta wrote: On 29.2.2012 14:24, Martin Kosek wrote: On Wed, 2012-02-29 at 10:52 +0100, Jan Cholasta wrote: On 28.2.2012 23:42, Rob Crittenden

Re: [Freeipa-devel] [PATCH] 918, 919 update sudo schema

2012-03-02 Thread Jan Cholasta
On 1.3.2012 20:57, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 17.1.2012 04:55, Rob Crittenden wrote: Jan Cholasta wrote: Dne 13.1.2012 17:39, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 14.12.2011 16:21, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne

Re: [Freeipa-devel] [PATCH] 956 user lockout status

2012-03-02 Thread Martin Kosek
On Thu, 2012-03-01 at 16:26 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-02-29 at 11:20 +0100, Petr Viktorin wrote: On 02/27/2012 06:31 PM, Martin Kosek wrote: 4) Minor change: -except Exception: +except: Don't do that. It would

Re: [Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-03-02 Thread Petr Viktorin
On 02/29/2012 04:09 PM, Petr Viktorin wrote: On 02/29/2012 03:53 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 11:14 AM, Jan Cholasta wrote: On 29.2.2012 11:09, Petr Viktorin wrote: On 02/28/2012 03:19 PM, Jan Cholasta wrote: On 28.2.2012 11:54, Petr Viktorin wrote: On

Re: [Freeipa-devel] [PATCH] 098 Forms based authentication UI

2012-03-02 Thread Petr Vobornik
On 03/02/2012 12:39 AM, Rob Crittenden wrote: Petr Vobornik wrote: Support for forms based authentication was added to UI. It consist of: 1) new login page Page url is [ipa server]/ipa/ui/login.html Page contains a login form. For authentication it sends ajax request at [ipa

Re: [Freeipa-devel] [PATCH] 0100 Improved usability of login dialog

2012-03-02 Thread Petr Vobornik
On 03/02/2012 12:39 AM, Rob Crittenden wrote: Petr Vobornik wrote: Usability was improved in Unauthorized/Login dialog. When the dialog is opened a link which switches to login form is focus so user can do following: 1) press enter (login form is displayed and username field is focused ) 2)

[Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Martin Kosek
When a replica is deleted, its memberPrincipal entries in cn=s4u2proxy,cn=etc,SUFFIX were not removed. Then, if the replica is reinstalled and connected again, the installer would report an error with duplicate value in LDAP. This patch extends replica cleanup procedure to remove replica

[Freeipa-devel] [PATCH] 0019 Use reboot from /sbin

2012-03-02 Thread Petr Viktorin
Commit message says it all. So does the ticket. https://fedorahosted.org/freeipa/ticket/2480 -- Petr³ From aad19e793e3ea882ef5069d678f9ba739b2e6eb4 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Fri, 2 Mar 2012 07:18:56 -0500 Subject: [PATCH] Use reboot from /sbin

Re: [Freeipa-devel] [PATCH] 0019 Use reboot from /sbin

2012-03-02 Thread Jakub Hrozek
On Fri, Mar 02, 2012 at 01:28:56PM +0100, Petr Viktorin wrote: Commit message says it all. So does the ticket. https://fedorahosted.org/freeipa/ticket/2480 -- Petr³ Does it matter? It the UsrMoved world, both are just symlinks to systemctl.. [root@vm-146 ~]# ll /sbin/reboot lrwxrwxrwx.

Re: [Freeipa-devel] [PATCH] 0019 Use reboot from /sbin

2012-03-02 Thread Petr Viktorin
On 03/02/2012 01:42 PM, Jakub Hrozek wrote: On Fri, Mar 02, 2012 at 01:28:56PM +0100, Petr Viktorin wrote: Commit message says it all. So does the ticket. https://fedorahosted.org/freeipa/ticket/2480 -- Petr³ Does it matter? It the UsrMoved world, both are just symlinks to systemctl..

Re: [Freeipa-devel] [PATCH] 217 Fix typos in ipa-replica-manage man page

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 14:40 +0100, Martin Kosek wrote: ACK for patch fixing typos in ipa-replica-manage. I just had to fix it a little bit. Pushed to master, ipa-2-2. Martin Just a clarification - the original patch was linked to the bug in Bugzilla.

Re: [Freeipa-devel] [PATCH] 956 user lockout status

2012-03-02 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2012-03-01 at 16:26 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-02-29 at 11:20 +0100, Petr Viktorin wrote: On 02/27/2012 06:31 PM, Martin Kosek wrote: 4) Minor change: -except Exception: +except: Don't do that.

Re: [Freeipa-devel] [PATCH] 0019 Use reboot from /sbin

2012-03-02 Thread Jakub Hrozek
On Fri, Mar 02, 2012 at 02:08:38PM +0100, Petr Viktorin wrote: On 03/02/2012 01:42 PM, Jakub Hrozek wrote: On Fri, Mar 02, 2012 at 01:28:56PM +0100, Petr Viktorin wrote: Commit message says it all. So does the ticket. https://fedorahosted.org/freeipa/ticket/2480 -- Petr³ Does it

Re: [Freeipa-devel] [PATCH] 956 user lockout status

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 08:46 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-03-01 at 16:26 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-02-29 at 11:20 +0100, Petr Viktorin wrote: On 02/27/2012 06:31 PM, Martin Kosek wrote: 4) Minor change: -

Re: [Freeipa-devel] [PATCH] 918, 919 update sudo schema

2012-03-02 Thread Rob Crittenden
Jan Cholasta wrote: On 1.3.2012 20:57, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 17.1.2012 04:55, Rob Crittenden wrote: Jan Cholasta wrote: Dne 13.1.2012 17:39, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 14.12.2011 16:21, Rob Crittenden napsal(a): Jan

Re: [Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Simo Sorce
On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote: +principals.remove(member_principal) +mod = [(ldap.MOD_REPLACE, 'memberPrincipal', principals)] Any special reason why you use a search and then a replace instead of a delete by value ? A delete by value

Re: [Freeipa-devel] [PATCH] 956 user lockout status

2012-03-02 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2012-03-02 at 08:46 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-03-01 at 16:26 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-02-29 at 11:20 +0100, Petr Viktorin wrote: On 02/27/2012 06:31 PM, Martin Kosek wrote: 4) Minor

Re: [Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 09:39 -0500, Simo Sorce wrote: On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote: +principals.remove(member_principal) +mod = [(ldap.MOD_REPLACE, 'memberPrincipal', principals)] Any special reason why you use a search and then a

Re: [Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Simo Sorce
On Fri, 2012-03-02 at 16:22 +0100, Martin Kosek wrote: On Fri, 2012-03-02 at 09:39 -0500, Simo Sorce wrote: On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote: +principals.remove(member_principal) +mod = [(ldap.MOD_REPLACE, 'memberPrincipal',

Re: [Freeipa-devel] [PATCH] 956 user lockout status

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 09:48 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-03-02 at 08:46 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-03-01 at 16:26 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-02-29 at 11:20 +0100, Petr Viktorin wrote:

Re: [Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 10:30 -0500, Simo Sorce wrote: On Fri, 2012-03-02 at 16:22 +0100, Martin Kosek wrote: On Fri, 2012-03-02 at 09:39 -0500, Simo Sorce wrote: On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote: +principals.remove(member_principal) +

Re: [Freeipa-devel] [PATCH] 0019 Use reboot from /sbin

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 14:59 +0100, Jakub Hrozek wrote: On Fri, Mar 02, 2012 at 02:08:38PM +0100, Petr Viktorin wrote: On 03/02/2012 01:42 PM, Jakub Hrozek wrote: On Fri, Mar 02, 2012 at 01:28:56PM +0100, Petr Viktorin wrote: Commit message says it all. So does the ticket.

Re: [Freeipa-devel] [PATCH] 918, 919 update sudo schema

2012-03-02 Thread Rob Crittenden
Jan Cholasta wrote: On 1.3.2012 20:57, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 17.1.2012 04:55, Rob Crittenden wrote: Jan Cholasta wrote: Dne 13.1.2012 17:39, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 14.12.2011 16:21, Rob Crittenden napsal(a): Jan

Re: [Freeipa-devel] [PATCH] 69 Configure SSH features of SSSD in ipa-client-install

2012-03-02 Thread Rob Crittenden
Jan Cholasta wrote: On 2.3.2012 04:56, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:00, Martin Kosek wrote: On Wed, 2012-02-29 at 14:44 +0100, Jan Cholasta wrote: On 29.2.2012 14:24, Martin Kosek wrote: On Wed, 2012-02-29 at 10:52 +0100, Jan Cholasta wrote: On 28.2.2012 23:42,

Re: [Freeipa-devel] [PATCH] 099 Removed CSV creation from UI

2012-03-02 Thread Endi Sukma Dewata
On 2/29/2012 12:08 PM, Petr Vobornik wrote: Creating CSV values in UI is unnecessary and error-prone because server converts them back to list. Possible problems with values containing commas may occur. All occurrences of CSV joining were therefore removed.

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once (updated)

2012-03-02 Thread Petr Viktorin
On 02/29/2012 07:13 PM, Petr Vobornik wrote: On 02/27/2012 02:01 PM, Petr Viktorin wrote: It seems I didn't communicate the problem and my solution clearly enough, so let me try again. (Also, I learned from the discussions!) Currently, both the client and the server parse CSV options. The

Re: [Freeipa-devel] [PATCH] 918, 919 update sudo schema

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 11:40 -0500, Rob Crittenden wrote: Jan Cholasta wrote: On 1.3.2012 20:57, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 17.1.2012 04:55, Rob Crittenden wrote: Jan Cholasta wrote: Dne 13.1.2012 17:39, Rob Crittenden napsal(a): Jan Cholasta

Re: [Freeipa-devel] [PATCH] 918, 919 update sudo schema

2012-03-02 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2012-03-02 at 11:40 -0500, Rob Crittenden wrote: Jan Cholasta wrote: On 1.3.2012 20:57, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 17.1.2012 04:55, Rob Crittenden wrote: Jan Cholasta wrote: Dne 13.1.2012 17:39, Rob Crittenden napsal(a):

Re: [Freeipa-devel] [PATCH] 918, 919 update sudo schema

2012-03-02 Thread Jan Cholasta
On 2.3.2012 19:43, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-03-02 at 11:40 -0500, Rob Crittenden wrote: Jan Cholasta wrote: On 1.3.2012 20:57, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta wrote: On 17.1.2012 04:55, Rob Crittenden wrote: Jan Cholasta wrote: Dne

[Freeipa-devel] Rebélate by self-management, first project of free software by which we bet all / Rebélate por la autogestión, primer proyecto de software libre por el que apostamos todas

2012-03-02 Thread Orquidea Salt mas
Inglés : Many already we have contributed to the first project of free software dedicated to self-management in this campaign of collective financing, it collaborates and it spreads!/ Beginning campaign collective financing

Re: [Freeipa-devel] [PATCH] 918, 919 update sudo schema

2012-03-02 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2012-03-02 at 20:01 +0100, Jan Cholasta wrote: On 2.3.2012 19:43, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-03-02 at 11:40 -0500, Rob Crittenden wrote: Jan Cholasta wrote: On 1.3.2012 20:57, Rob Crittenden wrote: Rob Crittenden wrote: Jan Cholasta

Re: [Freeipa-devel] [PATCH] 221 Fix encoding for setattr/addattr/delattr

2012-03-02 Thread Rob Crittenden
Martin Kosek wrote: Attribute values passed by --{set,add,del}attr parameters were normalized and validated using appropriate parameter, but were never encoded for the backend. This make prevents manipulation with dirsvr BOOL attributes where framework tries to pass boolean value instead of

[Freeipa-devel] [PATCH] fix hbactest failures

2012-03-02 Thread Rob Crittenden
Another module with some now invalid domain names caught by new validator. Pushed under one-liner rule. rob From 7c454fcefa9bbfe092cb99826863bbc27f5fb01e Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Fri, 2 Mar 2012 14:53:22 -0500 Subject: [PATCH] Make hostnames adhere

Re: [Freeipa-devel] [PATCH] 229 Add help for new structured DNS framework

2012-03-02 Thread Rob Crittenden
Martin Kosek wrote: DNS Test Day shown that the new RR specific DNS options and the concepts behind them may not be easily understood. This patch adds an explanation of the new DNS framework for structured options to make it easier for the user to understand and use the new options.

Re: [Freeipa-devel] [PATCH] 225 Improve dnsrecord interactive help

2012-03-02 Thread Rob Crittenden
Martin Kosek wrote: This patch is build on top of my DNS patches 218-220 Add 2 new features to DNS record interactive help to increase its usability and also make its behavior more consistent with standard parameter interactive help: 1) Ask for missing DNS parts When a required part of a

[Freeipa-devel] [PATCH] fix API for suduOrder

2012-03-02 Thread Rob Crittenden
I modified minvalue of sudoOrder without updating API.txt. I bumped VERSION to reflect the new option as well. Pushed to ipa-2-2 and master as a one liner. rob From 71d745f921b9e3d39fbdf800e79f2d90a90cd6ba Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Fri, 2 Mar 2012

Re: [Freeipa-devel] [PATCH] 41-2 During ipa-client-install verify forward and reverse dns lookup of server

2012-03-02 Thread JR Aquino
On Feb 28, 2012, at 10:43 AM, JR Aquino wrote: On Feb 23, 2012, at 3:56 PM, JR Aquino wrote: ipa-server-install has a method for validating forward and reverse via ipaserver/install/installutils.py ipa-client-install does not currently have an equivalent This patch adds valid_dns to