Re: [Freeipa-devel] [PATCH] 0060 Ensure ipa-adtrust-install is run as admin user

2012-07-18 Thread Alexander Bokovoy
On Tue, 17 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Fri, 13 Jul 2012, Alexander Bokovoy wrote: Hi, when adding AD trusts support, we need to ensure we have valid kerberos ticket of the user from 'admins' group or otherwise appropriate ACIs will not be granted. This patch

[Freeipa-devel] [PATCH 0032-0035]

2012-07-18 Thread Petr Spacek
Hello, attached patch 0032 adds support for MODDN operation to persistent search implementation. Related ticket: https://fedorahosted.org/bind-dyndb-ldap/ticket/72 Patches 0033-0035 does minor cleanup in old persistent search code. Petr^2 Spacek From 79769c5ad71a10540cdd9b571eed9407e31da9e6

Re: [Freeipa-devel] DN patch and documentation

2012-07-18 Thread Petr Viktorin
On 07/18/2012 12:47 AM, John Dennis wrote: On 07/10/2012 04:23 AM, Petr Viktorin wrote: I've read your summary (which you should summarize into a commit message before this is pushed), and gone through the patch. Here is what I found doing that; I didn't get to actual testing yet. I also didn't

Re: [Freeipa-devel] [PATCH 0032-0035] Add support for MODDN operation to persistent search implementation

2012-07-18 Thread Petr Spacek
Sorry for the missing subject! Petr^2 Spacek On 07/18/2012 01:32 PM, Petr Spacek wrote: adds support for MODDN operation to persistent search implementation ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 0056 Framework for admin/install tools, with ipa-ldap-updater

2012-07-18 Thread Petr Viktorin
On 07/17/2012 10:41 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 06/29/2012 11:28 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 06/25/2012 03:00 PM, Petr Viktorin wrote: On 06/20/2012 06:15 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 06/04/2012 04:56 PM, Petr Viktorin wrote:

[Freeipa-devel] [PATCH 0036] Raise connection count automatically if serial_autoincrement is enabled

2012-07-18 Thread Petr Spacek
Hello, this patch reflects new demand from serial_autoincrement feature. Generally, change in configuration file should by IPA install/upgrade scripts. This patch prevents deadlock in situation where scripts failed in their job (as you can see right now). Will be obsoleted by

[Freeipa-devel] [PATCH 0037] Add missing return value check to new_ldap_instance()

2012-07-18 Thread Petr Spacek
Hello, this patch adds missing return value check to new_ldap_instance(). https://fedorahosted.org/bind-dyndb-ldap/ticket/85 Bug was reported by Coverity. Petr^2 Spacek From 85574b9ffe4757b93b6eb9b99ceb1172a5c37002 Mon Sep 17 00:00:00 2001 From: Petr Spacek pspa...@redhat.com Date: Wed, 18

Re: [Freeipa-devel] [PATCH] 0060 Ensure ipa-adtrust-install is run as admin user

2012-07-18 Thread Alexander Bokovoy
On Wed, 18 Jul 2012, Alexander Bokovoy wrote: On Tue, 17 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Fri, 13 Jul 2012, Alexander Bokovoy wrote: Hi, when adding AD trusts support, we need to ensure we have valid kerberos ticket of the user from 'admins' group or otherwise

[Freeipa-devel] [PATCH] 0063 change sid_check_is_domain() to sid_check_is_our_sam()

2012-07-18 Thread Alexander Bokovoy
Hi, due to API change in Samba4 between beta3 and beta4, following small patch is needed for ipasam. I've also added forward declaration for the function. https://fedorahosted.org/freeipa/ticket/2929 -- / Alexander Bokovoy From d58b997587551744515c50e019148adf005f5c3f Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 0060 Ensure ipa-adtrust-install is run as admin user

2012-07-18 Thread Rob Crittenden
Alexander Bokovoy wrote: On Tue, 17 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Fri, 13 Jul 2012, Alexander Bokovoy wrote: Hi, when adding AD trusts support, we need to ensure we have valid kerberos ticket of the user from 'admins' group or otherwise appropriate ACIs will not

Re: [Freeipa-devel] [PATCH] 0063 change sid_check_is_domain() to sid_check_is_our_sam()

2012-07-18 Thread Simo Sorce
On Wed, 2012-07-18 at 15:58 +0300, Alexander Bokovoy wrote: Hi, due to API change in Samba4 between beta3 and beta4, following small patch is needed for ipasam. I've also added forward declaration for the function. https://fedorahosted.org/freeipa/ticket/2929 Nack, please add build

Re: [Freeipa-devel] [PATCH] 0060 Ensure ipa-adtrust-install is run as admin user

2012-07-18 Thread Alexander Bokovoy
On Wed, 18 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Tue, 17 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Fri, 13 Jul 2012, Alexander Bokovoy wrote: Hi, when adding AD trusts support, we need to ensure we have valid kerberos ticket of the user from 'admins'

Re: [Freeipa-devel] [PATCH] 0060 Ensure ipa-adtrust-install is run as admin user

2012-07-18 Thread Simo Sorce
On Wed, 2012-07-18 at 16:19 +0300, Alexander Bokovoy wrote: On Wed, 18 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Tue, 17 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Fri, 13 Jul 2012, Alexander Bokovoy wrote: Hi, when adding AD trusts support, we need to

Re: [Freeipa-devel] [PATCH] 0060 Ensure ipa-adtrust-install is run as admin user

2012-07-18 Thread Alexander Bokovoy
On Wed, 18 Jul 2012, Simo Sorce wrote: On Wed, 2012-07-18 at 16:19 +0300, Alexander Bokovoy wrote: On Wed, 18 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Tue, 17 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: On Fri, 13 Jul 2012, Alexander Bokovoy wrote: Hi, when

Re: [Freeipa-devel] [PATCH] 0061 ValidationError takes 'error' named argument, not 'reason'

2012-07-18 Thread Alexander Bokovoy
On Tue, 17 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: Hi, https://fedorahosted.org/freeipa/ticket/2865 ACK Pushed to master -- / Alexander Bokovoy ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 0062 support various forms of user account when establishing trusts

2012-07-18 Thread Alexander Bokovoy
On Tue, 17 Jul 2012, Rob Crittenden wrote: Alexander Bokovoy wrote: Hi, Realm administrator account may be specified using different form: Administrator, DOM\Administrator, Administrator@DOMAIN This patch introduces handling of the second two forms: - In DOM\Administrator only user name is

Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

2012-07-18 Thread Petr Vobornik
On 07/17/2012 04:57 PM, Endi Sukma Dewata wrote: On 7/17/2012 9:25 AM, Petr Vobornik wrote: Possible improvement, instead of using a fixed column size the text area also could be made to occupy 100% of available width. Ideally it should have the same width as the text field or drop down list in

Re: [Freeipa-devel] [PATCH] 0063 change sid_check_is_domain() to sid_check_is_our_sam()

2012-07-18 Thread Alexander Bokovoy
On Wed, 18 Jul 2012, Simo Sorce wrote: On Wed, 2012-07-18 at 15:58 +0300, Alexander Bokovoy wrote: Hi, due to API change in Samba4 between beta3 and beta4, following small patch is needed for ipasam. I've also added forward declaration for the function.

[Freeipa-devel] [PATCH] one-liner, don't hardcode serial_autoincrement

2012-07-18 Thread Rob Crittenden
The bind option serial_autoincrement was being hardcoded to True so passing in an install option to not enable it was not working. Pushed as a one-liner. rob From 77b854fbf3f0e0d0c9780db997500a2982889107 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Wed, 18 Jul 2012

Re: [Freeipa-devel] [PATCHES] 495 Fix ipa-replica-manage issues

2012-07-18 Thread Rob Crittenden
Simo Sorce wrote: These 2 patches fix issues found with ipa-replica-manage and connect/disconnect commands. Fixes ticket #2925 Simo. ACK, pushed both to master. I slightly reformatted the commit messages. rob ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 0070 Fix updating minimum_connections in ipa-upgradeconfig

2012-07-18 Thread Rob Crittenden
Petr Viktorin wrote: minimum_connections was sometimes not updated properly on install because the script set psearch on but assumed it was still off. Also, the number of connections was not set if the directive was missing. Fix of the patch for https://fedorahosted.org/freeipa/ticket/2554