[Freeipa-devel] [PATCH] 0083 Always handle NotFound error in dnsrecord-mod

2012-09-24 Thread Petr Viktorin
When there were no updated attrs when modifying a nonexistent DNS record, the error was not handled and caused an internal server error later (old_entry was used uninitialized). https://fedorahosted.org/freeipa/ticket/3055 -- PetrĀ³ From 04d5e239b7bdcff65185ed8d127dfdeba5caded5 Mon Sep 17

[Freeipa-devel] [PATCH 0068] Fix unable to concatenate DNS names during zone_refresh error

2012-09-24 Thread Petr Spacek
Hello, Fix unable to concatenate DNS names during zone_refresh error. This fixes zone refresh for cases where concatenation of all zone names is longer than 255 characters. -- Petr^2 Spacek From e9764d49e8c3ecd6985cd35d7ef1991ee569a98a Mon Sep 17 00:00:00 2001 From: Petr Spacek

Re: [Freeipa-devel] [PATCH] 0083 Always handle NotFound error in dnsrecord-mod

2012-09-24 Thread Martin Kosek
On 09/24/2012 01:03 PM, Petr Viktorin wrote: When there were no updated attrs when modifying a nonexistent DNS record, the error was not handled and caused an internal server error later (old_entry was used uninitialized). https://fedorahosted.org/freeipa/ticket/3055 ACK. Pushed to

Re: [Freeipa-devel] [PATCH 0062] Prevent memory read outside allocated space in str_alloc()

2012-09-24 Thread Adam Tkac
On Fri, Sep 14, 2012 at 10:50:56AM +0200, Petr Spacek wrote: Hello, Prevent memory read outside allocated space in str_alloc(). Found by Valgrind during nsupdate stress test. Ack From c53ec9cf2cc22e29630767b6b2259d145192ff62 Mon Sep 17 00:00:00 2001 From: Petr Spacek pspa...@redhat.com

Re: [Freeipa-devel] [PATCH 0054] Allow BIND to start if LDAP connection times out

2012-09-24 Thread Adam Tkac
On Tue, Aug 28, 2012 at 02:00:57PM +0200, Petr Spacek wrote: Hello, this patch allows BIND to start if LDAP connection times out. BIND will reconnect in same way as after connection refused errors. The patch closes https://fedorahosted.org/bind-dyndb-ldap/ticket/84 . Ack From

Re: [Freeipa-devel] [PATCH 0060] Fix zone delete in ldap_zone_delete2()

2012-09-24 Thread Adam Tkac
On Thu, Sep 13, 2012 at 01:36:32PM +0200, Petr Spacek wrote: Hello, Fix zone delete in ldap_zone_delete2(). This fixes two race conditions during BIND reload: - failing assert in destroy_ldap_connection() DESTROYLOCK: ((pthread_mutex_destroy(ldap_conn-lock) == 0) ? 0 : 34)

Re: [Freeipa-devel] [PATCH 0063] Notify DNS slaves if zone serial number modification was detected.

2012-09-24 Thread Adam Tkac
On Mon, Sep 17, 2012 at 02:55:06PM +0200, Petr Spacek wrote: Hello, this patch adds missing notification to DNS slaves if zone serial number modification was detected. Hi, please check my comment below. From eb8d7fc0c02e03b9c7c90e497225536c449fab1c Mon Sep 17 00:00:00 2001 From: Petr

Re: [Freeipa-devel] [PATCH 0064] Improve log message about improperly formated Resource Records

2012-09-24 Thread Adam Tkac
On Mon, Sep 17, 2012 at 05:07:44PM +0200, Petr Spacek wrote: Hello, this patch adds DN to log message about improperly formated Resource Records. Hi, please check my comment below, otherwise ack. Regards, Adam From d36ae54c593c33a45ef9936720357ff7de30c8b5 Mon Sep 17 00:00:00 2001 From:

Re: [Freeipa-devel] [PATCH 0063] Notify DNS slaves if zone serial number modification was detected.

2012-09-24 Thread Petr Spacek
On 09/24/2012 03:09 PM, Adam Tkac wrote: On Mon, Sep 17, 2012 at 02:55:06PM +0200, Petr Spacek wrote: Hello, this patch adds missing notification to DNS slaves if zone serial number modification was detected. Hi, please check my comment below. From

Re: [Freeipa-devel] [PATCH 0064] Improve log message about improperly formated Resource Records

2012-09-24 Thread Petr Spacek
On 09/24/2012 03:15 PM, Adam Tkac wrote: On Mon, Sep 17, 2012 at 05:07:44PM +0200, Petr Spacek wrote: Hello, this patch adds DN to log message about improperly formated Resource Records. Hi, please check my comment below, otherwise ack. Regards, Adam From

Re: [Freeipa-devel] [PATCH 0063] Notify DNS slaves if zone serial number modification was detected.

2012-09-24 Thread Adam Tkac
On Mon, Sep 24, 2012 at 03:21:23PM +0200, Petr Spacek wrote: On 09/24/2012 03:09 PM, Adam Tkac wrote: On Mon, Sep 17, 2012 at 02:55:06PM +0200, Petr Spacek wrote: Hello, this patch adds missing notification to DNS slaves if zone serial number modification was detected. Hi, please

Re: [Freeipa-devel] [PATCH 0064] Improve log message about improperly formated Resource Records

2012-09-24 Thread Adam Tkac
On Mon, Sep 24, 2012 at 03:27:13PM +0200, Petr Spacek wrote: On 09/24/2012 03:15 PM, Adam Tkac wrote: On Mon, Sep 17, 2012 at 05:07:44PM +0200, Petr Spacek wrote: Hello, this patch adds DN to log message about improperly formated Resource Records. Hi, please check my comment below,

[Freeipa-devel] [PATCH 0069] Fix crash caused by empty zone renaming

2012-09-24 Thread Petr Spacek
Hello, Fix crash caused by empty zone renaming. LDAP query uses LDAP_SCOPE_ONELEVEL scope so original condition in INSIST is incorrect, because zone is not required to have child names (i.e. names other than zone itself). -- Petr^2 Spacek From

Re: [Freeipa-devel] [PATCH 0068] Fix unable to concatenate DNS names during zone_refresh error

2012-09-24 Thread Adam Tkac
On Mon, Sep 24, 2012 at 01:22:32PM +0200, Petr Spacek wrote: Hello, Fix unable to concatenate DNS names during zone_refresh error. This fixes zone refresh for cases where concatenation of all zone names is longer than 255 characters. Ack From

Re: [Freeipa-devel] [PATCH 0069] Fix crash caused by empty zone renaming

2012-09-24 Thread Adam Tkac
On Mon, Sep 24, 2012 at 03:45:25PM +0200, Petr Spacek wrote: Hello, Fix crash caused by empty zone renaming. LDAP query uses LDAP_SCOPE_ONELEVEL scope so original condition in INSIST is incorrect, because zone is not required to have child names (i.e. names other than zone

[Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Alexander Bokovoy
Hi, small patch, to make sure external members are listed when 'ipa group-show' is called. https://fedorahosted.org/freeipa/ticket/2975 -- / Alexander Bokovoy From 98a34772855d79cbaf8555809975453fd112b4cf Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy aboko...@redhat.com Date: Mon, 24 Sep

Re: [Freeipa-devel] [PATCH 0061] Add missing DNS view attach/detach to LDAP instance management code

2012-09-24 Thread Adam Tkac
On Thu, Sep 13, 2012 at 01:37:37PM +0200, Petr Spacek wrote: Hello, Add missing DNS view attach/detach to LDAP instance management code. This fixes race condition in BIND shutdown after SIGINT: - failing assert caused by use-after-free in dns_zt_find(): (((zt) != ((void

Re: [Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Sumit Bose
On Mon, Sep 24, 2012 at 05:01:25PM +0300, Alexander Bokovoy wrote: Hi, small patch, to make sure external members are listed when 'ipa group-show' is called. https://fedorahosted.org/freeipa/ticket/2975 ACK bye, Sumit -- / Alexander Bokovoy

Re: [Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Petr Viktorin
On 09/24/2012 04:01 PM, Alexander Bokovoy wrote: Hi, small patch, to make sure external members are listed when 'ipa group-show' is called. https://fedorahosted.org/freeipa/ticket/2975 This looks good, but it could use some tests. -- PetrĀ³ ___

Re: [Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Alexander Bokovoy
On Mon, 24 Sep 2012, Petr Viktorin wrote: On 09/24/2012 04:01 PM, Alexander Bokovoy wrote: Hi, small patch, to make sure external members are listed when 'ipa group-show' is called. https://fedorahosted.org/freeipa/ticket/2975 This looks good, but it could use some tests. For external

Re: [Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Petr Viktorin
On 09/24/2012 04:57 PM, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Petr Viktorin wrote: On 09/24/2012 04:01 PM, Alexander Bokovoy wrote: Hi, small patch, to make sure external members are listed when 'ipa group-show' is called. https://fedorahosted.org/freeipa/ticket/2975 This looks

Re: [Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Alexander Bokovoy
On Mon, 24 Sep 2012, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Petr Viktorin wrote: On 09/24/2012 04:01 PM, Alexander Bokovoy wrote: Hi, small patch, to make sure external members are listed when 'ipa group-show' is called. https://fedorahosted.org/freeipa/ticket/2975 This looks good,

[Freeipa-devel] [PATCH] 1057 fix syntax error

2012-09-24 Thread Rob Crittenden
Fix syntax error in exception handling in ipa-client-automount. rob From 3025faf70da09a036b6a16589bd3bb3418bfd9cd Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Mon, 24 Sep 2012 10:53:09 -0400 Subject: [PATCH] Fix python syntax in ipa-client-automount

Re: [Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Petr Viktorin
On 09/24/2012 05:11 PM, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Petr Viktorin wrote: On 09/24/2012 04:01 PM, Alexander Bokovoy wrote: Hi, small patch, to make sure external members are listed when 'ipa group-show' is called.

Re: [Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Alexander Bokovoy
On Mon, 24 Sep 2012, Petr Viktorin wrote: On 09/24/2012 05:11 PM, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Petr Viktorin wrote: On 09/24/2012 04:01 PM, Alexander Bokovoy wrote: Hi, small patch, to make sure external members are listed when

Re: [Freeipa-devel] [PATCH] 0078 ipa group-show external group does not list its members

2012-09-24 Thread Petr Viktorin
On 09/24/2012 05:35 PM, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Petr Viktorin wrote: On 09/24/2012 05:11 PM, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Alexander Bokovoy wrote: On Mon, 24 Sep 2012, Petr Viktorin wrote: On 09/24/2012 04:01 PM, Alexander Bokovoy wrote: Hi, small

Re: [Freeipa-devel] [PATCH 0060] Fix zone delete in ldap_zone_delete2()

2012-09-24 Thread Petr Spacek
On 09/24/2012 03:00 PM, Adam Tkac wrote: On Thu, Sep 13, 2012 at 01:36:32PM +0200, Petr Spacek wrote: Hello, Fix zone delete in ldap_zone_delete2(). This fixes two race conditions during BIND reload: - failing assert in destroy_ldap_connection() DESTROYLOCK:

Re: [Freeipa-devel] [PATCH 0054] Allow BIND to start if LDAP connection times out

2012-09-24 Thread Petr Spacek
On 09/24/2012 02:19 PM, Adam Tkac wrote: On Tue, Aug 28, 2012 at 02:00:57PM +0200, Petr Spacek wrote: Hello, this patch allows BIND to start if LDAP connection times out. BIND will reconnect in same way as after connection refused errors. The patch closes

Re: [Freeipa-devel] [PATCH 0062] Prevent memory read outside allocated space in str_alloc()

2012-09-24 Thread Petr Spacek
On 09/24/2012 02:08 PM, Adam Tkac wrote: On Fri, Sep 14, 2012 at 10:50:56AM +0200, Petr Spacek wrote: Hello, Prevent memory read outside allocated space in str_alloc(). Found by Valgrind during nsupdate stress test. Ack Pushed to master: a12a5308d1cccd8bd225036f620f0e049a0fc5f5 Petr^2

Re: [Freeipa-devel] [PATCH 0063] Notify DNS slaves if zone serial number modification was detected.

2012-09-24 Thread Petr Spacek
On 09/24/2012 03:41 PM, Adam Tkac wrote: On Mon, Sep 24, 2012 at 03:21:23PM +0200, Petr Spacek wrote: On 09/24/2012 03:09 PM, Adam Tkac wrote: On Mon, Sep 17, 2012 at 02:55:06PM +0200, Petr Spacek wrote: Hello, this patch adds missing notification to DNS slaves if zone serial number

Re: [Freeipa-devel] [PATCH 0064] Improve log message about improperly formated Resource Records

2012-09-24 Thread Petr Spacek
On 09/24/2012 03:42 PM, Adam Tkac wrote: On Mon, Sep 24, 2012 at 03:27:13PM +0200, Petr Spacek wrote: On 09/24/2012 03:15 PM, Adam Tkac wrote: On Mon, Sep 17, 2012 at 05:07:44PM +0200, Petr Spacek wrote: Hello, this patch adds DN to log message about improperly formated Resource Records.

Re: [Freeipa-devel] [PATCH 0067] Fix error handling in ldap_get_zone_serial()

2012-09-24 Thread Petr Spacek
On 09/24/2012 03:16 PM, Adam Tkac wrote: On Fri, Sep 21, 2012 at 03:26:27PM +0200, Petr Spacek wrote: Hello, Fix error handling in ldap_get_zone_serial(). Successful call of zr_get_zone_ptr() attaches zone. Zone has to be detached regardless of dns_zone_getserial2() return

Re: [Freeipa-devel] [PATCH 0061] Add missing DNS view attach/detach to LDAP instance management code

2012-09-24 Thread Petr Spacek
On 09/24/2012 04:20 PM, Adam Tkac wrote: On Thu, Sep 13, 2012 at 01:37:37PM +0200, Petr Spacek wrote: Hello, Add missing DNS view attach/detach to LDAP instance management code. This fixes race condition in BIND shutdown after SIGINT: - failing assert caused by use-after-free in

Re: [Freeipa-devel] [PATCH 0069] Fix crash caused by empty zone renaming

2012-09-24 Thread Petr Spacek
On 09/24/2012 03:46 PM, Adam Tkac wrote: On Mon, Sep 24, 2012 at 03:45:25PM +0200, Petr Spacek wrote: Hello, Fix crash caused by empty zone renaming. LDAP query uses LDAP_SCOPE_ONELEVEL scope so original condition in INSIST is incorrect, because zone is not required to have

Re: [Freeipa-devel] [PATCH] 1057 fix syntax error

2012-09-24 Thread Martin Kosek
On 09/24/2012 05:20 PM, Rob Crittenden wrote: Fix syntax error in exception handling in ipa-client-automount. rob Obvious ACK. Pushed to master, ipa-3-0. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH 0068] Fix unable to concatenate DNS names during zone_refresh error

2012-09-24 Thread Petr Spacek
On 09/24/2012 03:45 PM, Adam Tkac wrote: On Mon, Sep 24, 2012 at 01:22:32PM +0200, Petr Spacek wrote: Hello, Fix unable to concatenate DNS names during zone_refresh error. This fixes zone refresh for cases where concatenation of all zone names is longer than 255 characters.

[Freeipa-devel] [PATCH] Simplify get_group_sids

2012-09-24 Thread Simo Sorce
This should also give us a slight performance boost as we do not convert the whole SID to a string many times over. Simo. -- Simo Sorce * Red Hat, Inc. * New York From f35d58981f46e5d4dba6688ee0334ca6cea90898 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Mon, 24 Sep 2012

Re: [Freeipa-devel] [PATCH] Simplify get_group_sids

2012-09-24 Thread Sumit Bose
On Mon, Sep 24, 2012 at 02:40:45PM -0400, Simo Sorce wrote: This should also give us a slight performance boost as we do not convert the whole SID to a string many times over. I was digging up the archive URL of my patch related to this posted to the list on July

Re: [Freeipa-devel] [PATCH] Simplify get_group_sids

2012-09-24 Thread Simo Sorce
- Original Message - On Mon, Sep 24, 2012 at 02:40:45PM -0400, Simo Sorce wrote: This should also give us a slight performance boost as we do not convert the whole SID to a string many times over. I was digging up the archive URL of my patch related to this posted to the