Re: [Freeipa-devel] Final OTP Review

2013-05-03 Thread Nathan Kinder
On 05/02/2013 10:27 PM, Nathaniel McCallum wrote: All issues fixed unless noted below... The attached patches are tested to work. On Thu, 2013-05-02 at 17:39 -0400, Simo Sorce wrote: - (nit) slapi_ch_malloc/slapi_ch_strdup are not checked for failure (although I know slapi_ch_malloc()

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Ana Krivokapic
On 04/26/2013 12:51 PM, Petr Vobornik wrote: On 04/25/2013 06:37 PM, Ana Krivokapic wrote: 1) When in self service mode, you are now allowed to go to pages of related objects. If you go to e.g. User Groups for your user, there are Add/Delete buttons and they are enabled, but if you try to

Re: [Freeipa-devel] Possible fix for CA install bug?

2013-05-03 Thread Martin Kosek
On 05/02/2013 07:51 PM, Rob Crittenden wrote: Rob Crittenden wrote: Nathaniel McCallum wrote: When installing beta1, I encountered a bug where the CA install would fail. This may have already been fixed in dogtag or elsewhere, but if not, this patch WorksForMe. I have no idea if it is the

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Petr Vobornik
On 05/03/2013 12:44 PM, Ana Krivokapic wrote: On 04/26/2013 12:51 PM, Petr Vobornik wrote: On 04/25/2013 06:37 PM, Ana Krivokapic wrote: 1) When in self service mode, you are now allowed to go to pages of related objects. If you go to e.g. User Groups for your user, there are Add/Delete

Re: [Freeipa-devel] [PATCH] 1098 catch cert-find errors on upgraded servers

2013-05-03 Thread Petr Viktorin
On 04/29/2013 10:52 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/26/2013 09:53 PM, Rob Crittenden wrote: A dogtag 9 - 10 upgraded server doesn't provide the RESTful API so therefore the cert-find command doesn't work. Starting with dogtag 10.0.2 it is going to send back a 501 (HTTP Not

Re: [Freeipa-devel] [PATCH 0152] Replace TTL values 2^31-1 with 0.

2013-05-03 Thread Tomas Babej
On 04/30/2013 03:45 PM, Petr Spacek wrote: Hello, Replace TTL values 2^31-1 with 0. The rule comes from RFC 2181 section 8. https://fedorahosted.org/bind-dyndb-ldap/ticket/117 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] Final OTP Review

2013-05-03 Thread Simo Sorce
On Thu, 2013-05-02 at 22:29 -0400, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2013-05-02 at 17:57 -0400, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2013-05-02 at 15:24 -0400, Nathaniel McCallum wrote: On Thu, 2013-05-02 at 12:18 -0400, Nathaniel McCallum wrote: Attached are

Re: [Freeipa-devel] Final OTP Review

2013-05-03 Thread Simo Sorce
On Fri, 2013-05-03 at 01:27 -0400, Nathaniel McCallum wrote: All issues fixed unless noted below... The attached patches are tested to work. On Thu, 2013-05-02 at 17:39 -0400, Simo Sorce wrote: - (nit) slapi_ch_malloc/slapi_ch_strdup are not checked for failure (although I know

[Freeipa-devel] [PATCH] 133 Fix creation of reverse records for IPA masters during install

2013-05-03 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/3600. Honza -- Jan Cholasta From 834f04380c3d53496ed6bd36d42bb486fa8db9c8 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Fri, 3 May 2013 15:00:24 +0200 Subject: [PATCH] Fix creation of reverse records

Re: [Freeipa-devel] [PATCH 0152] Replace TTL values 2^31-1 with 0.

2013-05-03 Thread Tomas Babej
On 05/03/2013 02:55 PM, Petr Spacek wrote: On 3.5.2013 14:35, Tomas Babej wrote: On 04/30/2013 03:45 PM, Petr Spacek wrote: Hello, Replace TTL values 2^31-1 with 0. The rule comes from RFC 2181 section 8. https://fedorahosted.org/bind-dyndb-ldap/ticket/117

Re: [Freeipa-devel] Final OTP Review

2013-05-03 Thread Simo Sorce
On Thu, 2013-05-02 at 23:39 -0700, Nathan Kinder wrote: On 05/02/2013 10:27 PM, Nathaniel McCallum wrote: All issues fixed unless noted below... The attached patches are tested to work. On Thu, 2013-05-02 at 17:39 -0400, Simo Sorce wrote: - (nit) slapi_ch_malloc/slapi_ch_strdup are

Re: [Freeipa-devel] [PATCH] 133 Fix creation of reverse records for IPA masters during install

2013-05-03 Thread Martin Kosek
On 05/03/2013 03:03 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/3600. Honza This would fix the behavior, yes. But I think that it would be even better to fix add_ptr_rr function to avoid unconditionally adding trailing dot to fqdn: def

Re: [Freeipa-devel] [PATCH] krb 1.12's OTP-Over-RADIUS

2013-05-03 Thread Nathaniel McCallum
Below is my first stab at ACLs. They don't actually work right, but I'm not sure what I've done wrong. The basic gist is that nobody gets any permissions by default. Admins get full permissions and users get limited permissions for their own tokens. Any help would be appreciated. Nathaniel

Re: [Freeipa-devel] [PATCH 0152] Replace TTL values 2^31-1 with 0.

2013-05-03 Thread Tomas Hozza
- Original Message - On 3.5.2013 14:35, Tomas Babej wrote: On 04/30/2013 03:45 PM, Petr Spacek wrote: Hello, Replace TTL values 2^31-1 with 0. The rule comes from RFC 2181 section 8. https://fedorahosted.org/bind-dyndb-ldap/ticket/117

Re: [Freeipa-devel] [PATCH] 133 Fix creation of reverse records for IPA masters during install

2013-05-03 Thread Petr Viktorin
On 05/03/2013 03:03 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/3600. Honza The patch fixes this particular problem, so ACK, but it'll be easy to make the mistake again. I think that add_ptr_rr should call normalize_zone instead of always

Re: [Freeipa-devel] [PATCH] 133 Fix creation of reverse records for IPA masters during install

2013-05-03 Thread Jan Cholasta
On 3.5.2013 15:23, Martin Kosek wrote: On 05/03/2013 03:03 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/3600. Honza This would fix the behavior, yes. But I think that it would be even better to fix add_ptr_rr function to avoid unconditionally

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Petr Vobornik
Update: * added ticket number to every commit, some commit messages improved * ~4 commits squashed * rebased on current master On 04/30/2013 07:19 PM, Petr Vobornik wrote: Update: * rebased on current master an force-pushed to private repo * fixed crash when IPA installed without CA * fixed

Re: [Freeipa-devel] [PATCH] 133 Fix creation of reverse records for IPA masters during install

2013-05-03 Thread Martin Kosek
On 05/03/2013 03:34 PM, Jan Cholasta wrote: On 3.5.2013 15:23, Martin Kosek wrote: On 05/03/2013 03:03 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/3600. Honza This would fix the behavior, yes. But I think that it would be even better to

Re: [Freeipa-devel] [Pki-announce] Announcing the release of Dogtag 10.0.2

2013-05-03 Thread John Dennis
On 05/02/2013 10:09 PM, Ade Lee wrote: The Dogtag team is proud to announce the second errata build for Dogtag v10.0.0. Just wanted to say the CS team is doing great work. Thanks for all these improvements! John -- John Dennis jden...@redhat.com Looking to carve out IT costs?

Re: [Freeipa-devel] [PATCH 0148] Explicitly return SERVFAIL if PTR synchronization is misconfigured.

2013-05-03 Thread Tomas Babej
On 04/16/2013 12:45 PM, Petr Spacek wrote: Hello, Explicitly return SERVFAIL if PTR synchronization is misconfigured. SERVFAIL will be returned if PTR synchronization is enabled in forward zone but reverse zone has dynamic updates disabled. ___

Re: [Freeipa-devel] [PATCH] krb 1.12's OTP-Over-RADIUS

2013-05-03 Thread Rob Crittenden
Martin Kosek wrote: On 05/01/2013 03:33 PM, Nathaniel McCallum wrote: Below is my first stab at ACLs. They don't actually work right, but I'm not sure what I've done wrong. The basic gist is that nobody gets any permissions by default. Admins get full permissions and users get limited

Re: [Freeipa-devel] [PATCH] krb 1.12's OTP-Over-RADIUS

2013-05-03 Thread Martin Kosek
On 05/03/2013 04:20 PM, Rob Crittenden wrote: Martin Kosek wrote: On 05/01/2013 03:33 PM, Nathaniel McCallum wrote: Below is my first stab at ACLs. They don't actually work right, but I'm not sure what I've done wrong. The basic gist is that nobody gets any permissions by default. Admins get

Re: [Freeipa-devel] [PATCH] 133 Fix creation of reverse records for IPA masters during install

2013-05-03 Thread Jan Cholasta
On 3.5.2013 15:38, Martin Kosek wrote: On 05/03/2013 03:34 PM, Jan Cholasta wrote: I don't see a point in doing this now. There are many occurences of uncoditional fqdn+'.' in the code and the proper fix would be to get rid of them all. I think this could be done in the scope of

Re: [Freeipa-devel] [PATCH] 133 Fix creation of reverse records for IPA masters during install

2013-05-03 Thread Martin Kosek
On 05/03/2013 05:13 PM, Jan Cholasta wrote: On 3.5.2013 15:38, Martin Kosek wrote: On 05/03/2013 03:34 PM, Jan Cholasta wrote: I don't see a point in doing this now. There are many occurences of uncoditional fqdn+'.' in the code and the proper fix would be to get rid of them all. I think this

Re: [Freeipa-devel] Final OTP Review

2013-05-03 Thread Simo Sorce
On Fri, 2013-05-03 at 12:00 -0400, Nathaniel McCallum wrote: On Fri, 2013-05-03 at 09:08 -0400, Simo Sorce wrote: On Thu, 2013-05-02 at 23:39 -0700, Nathan Kinder wrote: On 05/02/2013 10:27 PM, Nathaniel McCallum wrote: All issues fixed unless noted below... The attached patches are

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Endi Sukma Dewata
Hi, Sorry for the delay, I have some questions comments. Registry: In the simpleuser.js the new 'user' entity is registered first then the old 'user' entity is removed, which could be confusing because they are both identified using 'user'. Should register() automatically remove the old

[Freeipa-devel] [PATCH] Resolve SIDs in Web UI

2013-05-03 Thread Alexander Bokovoy
Hi! Attached are patches to allow resolving SIDs in Web UI in external membership panel for groups. Please see more detailed description in the main patch. I haven't rebased it yet on top of Petr's Web UI rework, hopefully it should be simple. https://fedorahosted.org/freeipa/ticket/3302

Re: [Freeipa-devel] Final OTP Review

2013-05-03 Thread Rob Crittenden
Simo Sorce wrote: On Fri, 2013-05-03 at 01:27 -0400, Nathaniel McCallum wrote: All issues fixed unless noted below... The attached patches are tested to work. On Thu, 2013-05-02 at 17:39 -0400, Simo Sorce wrote: - (nit) slapi_ch_malloc/slapi_ch_strdup are not checked for failure (although I

Re: [Freeipa-devel] [PATCH] 1098 catch cert-find errors on upgraded servers

2013-05-03 Thread Rob Crittenden
Petr Viktorin wrote: On 04/29/2013 10:52 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/26/2013 09:53 PM, Rob Crittenden wrote: A dogtag 9 - 10 upgraded server doesn't provide the RESTful API so therefore the cert-find command doesn't work. Starting with dogtag 10.0.2 it is going to

Re: [Freeipa-devel] [PATCH] Resolve SIDs in Web UI

2013-05-03 Thread Sumit Bose
On Fri, May 03, 2013 at 09:46:47PM +0300, Alexander Bokovoy wrote: Hi! Attached are patches to allow resolving SIDs in Web UI in external membership panel for groups. Please see more detailed description in the main patch. I haven't rebased it yet on top of Petr's Web UI rework, hopefully

Re: [Freeipa-devel] Final OTP Review

2013-05-03 Thread Rob Crittenden
Rob Crittenden wrote: Simo Sorce wrote: On Fri, 2013-05-03 at 01:27 -0400, Nathaniel McCallum wrote: All issues fixed unless noted below... The attached patches are tested to work. On Thu, 2013-05-02 at 17:39 -0400, Simo Sorce wrote: - (nit) slapi_ch_malloc/slapi_ch_strdup are not checked

Re: [Freeipa-devel] [PATCH] Resolve SIDs in Web UI

2013-05-03 Thread Alexander Bokovoy
On Fri, 03 May 2013, Sumit Bose wrote: On Fri, May 03, 2013 at 09:46:47PM +0300, Alexander Bokovoy wrote: Hi! Attached are patches to allow resolving SIDs in Web UI in external membership panel for groups. Please see more detailed description in the main patch. I haven't rebased it yet on top