Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-09-22 Thread Jan Cholasta
On 22.9.2015 17:23, Simo Sorce wrote: On Tue, 2015-09-22 at 10:45 +0200, Jan Cholasta wrote: 4) pylint fails with: daemons/ipa-custodia/ipakeys/kem.py:156: [E1002(super-on-old-class), IPAKEMKeys.__init__] Use of super on an old style class) daemons/ipa-custodia/ipakeys/kem.py:178:

Re: [Freeipa-devel] [PATCH 494] install: create kdcproxy user during server install

2015-09-22 Thread Simo Sorce
On Tue, 2015-09-22 at 16:35 +0200, Jan Cholasta wrote: > On 22.9.2015 15:11, Martin Babinsky wrote: > > On 09/22/2015 01:33 PM, Jan Cholasta wrote: > >> Hi, > >> > >> the attached patch fixes . > >> > >> Honza > >> > >> > >> > > ACK > > > > Thanks. >

Re: [Freeipa-devel] [PATCH 494] install: create kdcproxy user during server install

2015-09-22 Thread Simo Sorce
On Tue, 2015-09-22 at 20:09 -0400, Simo Sorce wrote: > On Tue, 2015-09-22 at 16:35 +0200, Jan Cholasta wrote: > > On 22.9.2015 15:11, Martin Babinsky wrote: > > > On 09/22/2015 01:33 PM, Jan Cholasta wrote: > > >> Hi, > > >> > > >> the attached patch fixes

Re: [Freeipa-devel] [PATCHES 466-468] install: Add common base class for server and replica install

2015-09-22 Thread Martin Babinsky
On 09/16/2015 10:44 AM, Jan Cholasta wrote: On 16.9.2015 08:11, Jan Cholasta wrote: On 15.9.2015 07:22, Jan Cholasta wrote: On 10.8.2015 16:58, Martin Babinsky wrote: On 08/06/2015 08:22 AM, Jan Cholasta wrote: Hi, the attached patch fixes part of

[Freeipa-devel] [PATCH] Proper fix for ticket 5306

2015-09-22 Thread Oleg Fayans
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 6650cc39b9704191d3099cf1780c477b2c0ef9af Mon Sep 17 00:00:00 2001 From: Oleg Fayans Date: Tue, 22 Sep 2015 10:38:08 +0200 Subject: [PATCH] Added a proper workaround for dnssec test failures in Beaker environment In

[Freeipa-devel] [PATCH] improved logging in dnssec tests

2015-09-22 Thread Oleg Fayans
Hi all, I've noticed that in some tests some low-level functions can return False in a number of different conditions, which severely complicates test debugging. This patch implements the approach widely used in the Go language (and maybe, some other): The function returns not only a boolean,

Re: [Freeipa-devel] [PATCH 0055] dnssec options missing in ipa-dns-install man page

2015-09-22 Thread Gabe Alford
Thanks! Added and attached updated patch. Gabe On Tue, Sep 22, 2015 at 1:17 AM, Martin Basti wrote: > > > On 09/21/2015 05:37 PM, Gabe Alford wrote: > > Hello, > > Fix for https://fedorahosted.org/freeipa/ticket/5300 > > Thanks, > > Gabe > > > Thank you! > > The option

Re: [Freeipa-devel] [PATCHES 466-468] install: Add common base class for server and replica install

2015-09-22 Thread Jan Cholasta
On 22.9.2015 10:29, Martin Babinsky wrote: On 09/16/2015 10:44 AM, Jan Cholasta wrote: On 16.9.2015 08:11, Jan Cholasta wrote: On 15.9.2015 07:22, Jan Cholasta wrote: On 10.8.2015 16:58, Martin Babinsky wrote: On 08/06/2015 08:22 AM, Jan Cholasta wrote: Hi, the attached patch fixes part of

Re: [Freeipa-devel] [PATCH 0368] ipa-backup: Add mechanism to store empty directory structure

2015-09-22 Thread Martin Basti
On 09/21/2015 04:31 PM, Tomas Babej wrote: On 09/21/2015 12:57 PM, Jan Cholasta wrote: Hi, On 21.9.2015 09:47, Tomas Babej wrote: On 09/17/2015 05:13 PM, Tomas Babej wrote: Hi, Certain subcomponents of IPA, such as Dogtag, cannot function if non-critical directories (such as log

Re: [Freeipa-devel] [PATCH 0004] Rewrap errors in get_principal to CCacheError

2015-09-22 Thread David Kupka
On 04/09/15 17:07, Michael Šimáček wrote: On 2015-09-03 14:32, Tomas Babej wrote: On 09/03/2015 12:54 PM, Michael Šimáček wrote: After porting to gssapi, the ipa command prints ugly traceback when kerberos credentials are not available. Rewrapping to CCacheError when getting the principal

[Freeipa-devel] [PATCH 494] install: create kdcproxy user during server install

2015-09-22 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta From 6853b55e7c072737c4e8e83a5dc1cca958ac08ae Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 21 Sep 2015 10:09:50 +0200 Subject: [PATCH] install: create kdcproxy

Re: [Freeipa-devel] [PATCH 0004] Rewrap errors in get_principal to CCacheError

2015-09-22 Thread Jan Cholasta
On 22.9.2015 13:20, David Kupka wrote: On 04/09/15 17:07, Michael Šimáček wrote: On 2015-09-03 14:32, Tomas Babej wrote: On 09/03/2015 12:54 PM, Michael Šimáček wrote: After porting to gssapi, the ipa command prints ugly traceback when kerberos credentials are not available. Rewrapping to

[Freeipa-devel] [PATCH 0064] destroy httpd ccache after stopping the service

2015-09-22 Thread Martin Babinsky
This patch fixes https://fedorahosted.org/freeipa/ticket/5296 and generally makes cleaning up of httpd ccache more thorough. -- Martin^3 Babinsky From 02ec4a4d080a1dab28d14fa46a037ef1731431fb Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Wed, 16 Sep 2015 18:35:21

Re: [Freeipa-devel] [PATCH 494] install: create kdcproxy user during server install

2015-09-22 Thread Jan Cholasta
On 22.9.2015 15:11, Martin Babinsky wrote: On 09/22/2015 01:33 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK Thanks. Pushed to: master: 0de860318332114ca739a8dd45902f7cc9a3c722 ipa-4-2:

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-09-22 Thread Simo Sorce
On Tue, 2015-09-22 at 10:45 +0200, Jan Cholasta wrote: > Hi, > > On 9.9.2015 20:25, Simo Sorce wrote: > > On Wed, 2015-08-26 at 17:27 -0400, Simo Sorce wrote: > >> This patchset implements https://fedorahosted.org/freeipa/ticket/2888 > >> and introduces a number of required changes and

Re: [Freeipa-devel] [PATCHES] More Python 3 porting

2015-09-22 Thread David Kupka
On 18/09/15 17:00, Petr Viktorin wrote: Hello, Here are more patches that bring IPA closer to Python 3 compatibility. Hi Petr, thanks for another batch of Python 3 compatibility patches. Unfortunately I hit a lot of pylint errors. Some of them are false positives for sure. Could you

Re: [Freeipa-devel] [PATCH 494] install: create kdcproxy user during server install

2015-09-22 Thread Martin Babinsky
On 09/22/2015 01:33 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

Re: [Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements

2015-09-22 Thread Tomas Babej
On 09/03/2015 04:34 PM, Alexander Bokovoy wrote: > On Thu, 03 Sep 2015, Tomas Babej wrote: >> Hi, >> >> this couple of patches fix https://fedorahosted.org/freeipa/ticket/5278 >> and improve our handling of realmdomains in general. > The code looks good to me. I haven't tested it yet, though. >

Re: [Freeipa-devel] [PATCHSET] Replica promotion patches

2015-09-22 Thread Simo Sorce
On Tue, 2015-09-22 at 10:45 +0200, Jan Cholasta wrote: > 4) pylint fails with: > > daemons/ipa-custodia/ipakeys/kem.py:156: [E1002(super-on-old-class), > IPAKEMKeys.__init__] Use of super on an old style class) > daemons/ipa-custodia/ipakeys/kem.py:178: [E1101(no-member), >