[Freeipa-devel] ipa-4-2 branch is broken !!!

2015-11-12 Thread Martin Basti
Lint failed in current ipa-4-2 branch. === Errors were found during the static code check. If you are certain that any of the reported errors are false positives, please mark them in the source code according to the

[Freeipa-devel] [patch 0024] Fix missed module import in ipaserver tests

2015-11-12 Thread Milan Kubík
-- Milan Kubik From 7dabe3f38005e1553b28b98a32578390f2bc629b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kub=C3=ADk?= Date: Thu, 12 Nov 2015 10:39:48 +0100 Subject: [PATCH] ipatests: Fix missed module import in ipaserver tests --- ipatests/test_ipaserver/test_ldap.py

Re: [Freeipa-devel] ipa-4-2 branch is broken !!!

2015-11-12 Thread Milan Kubík
On 11/12/2015 10:35 AM, Martin Basti wrote: Lint failed in current ipa-4-2 branch. === Errors were found during the static code check. If you are certain that any of the reported errors are false positives, please

Re: [Freeipa-devel] [PATCH 0380] spec: Add Provides directives to alternative package names

2015-11-12 Thread Jan Cholasta
On 9.11.2015 13:34, Tomas Babej wrote: On 11/09/2015 01:10 PM, Jan Cholasta wrote: Hi, On 9.11.2015 12:58, Tomas Babej wrote: Hi, this fixes: https://fedorahosted.org/freeipa/ticket/5408 a) Don't include %{release} in the Provides, release number is meaningless between distros. Good

Re: [Freeipa-devel] [PATCH 0095] remove an unneccesary check from IPA server uninstaller

2015-11-12 Thread Jan Cholasta
On 11.11.2015 16:32, Jan Cholasta wrote: On 11.11.2015 16:24, Martin Babinsky wrote: This check for a deprecated option added in https://fedorahosted.org/freeipa/ticket/4516 and somehow ended up in both install_check and uninstall_check during installer refactoring. The placement in the

Re: [Freeipa-devel] [PATCH 0093] perform connectivity checks for all topology suffixes during node deletion

2015-11-12 Thread Petr Vobornik
On 11/10/2015 05:43 PM, Martin Babinsky wrote: On 11/04/2015 06:50 PM, Petr Vobornik wrote: On 11/04/2015 01:30 PM, Martin Babinsky wrote: On 10/30/2015 05:06 PM, Martin Babinsky wrote: On 10/30/2015 03:38 PM, Petr Vobornik wrote: On 10/30/2015 03:26 PM, Martin Babinsky wrote: patch for

Re: [Freeipa-devel] [PATCH 0063] ipa-replica-manage del continues when host does not exist in domain level 1

2015-11-12 Thread Martin Basti
On 09.11.2015 14:37, Gabe Alford wrote: Hello, Fix for https://fedorahosted.org/freeipa/ticket/5424 thanks, Gabe Thank you for you patch, almost ACK, but I propose following changes (patch attached) in error message. Let me know if you agree with the change. Martin From

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

2015-11-12 Thread Milan Kubík
On 11/10/2015 12:13 PM, Filip Škola wrote: Hi, fixed. F. On Tue, 10 Nov 2015 10:52:45 +0100 Milan Kubík wrote: On 11/09/2015 04:35 PM, Filip Škola wrote: Another patch was applied in the meantime. Attaching an updated version. F. On Mon, 9 Nov 2015 13:35:02 +0100

Re: [Freeipa-devel] [patch 0024] Fix missed module import in ipaserver tests

2015-11-12 Thread Martin Basti
On 12.11.2015 10:55, Milan Kubík wrote: ACK Pushed to ipa-4-2: af076525ccc26abd7f957d801b26bfb83718b5d7 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0331, 0337] User plugin: allow multiple managers per user - CLI part

2015-11-12 Thread Martin Basti
On 27.10.2015 14:59, Martin Basti wrote: On 20.10.2015 18:46, Martin Basti wrote: On 20.10.2015 16:07, Martin Basti wrote: On 20.10.2015 15:57, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5344 Patch attached. Test are failing, a fix in UserTracker has to be done

Re: [Freeipa-devel] [PATCH 0344] Use absolute domain name in detection of A/AAAA records

2015-11-12 Thread Martin Basti
On 09.11.2015 08:47, Petr Spacek wrote: On 4.11.2015 16:16, Martin Basti wrote: Patch attached. https://fedorahosted.org/freeipa/ticket/5421 I'm not entirely sure how this patch will interact with magic included in ipalib/plugins/dns.py:class dns_resolve(Command). I would like to delete

Re: [Freeipa-devel] [PATCH 0338] Drop configure.jar file

2015-11-12 Thread Martin Basti
On 05.11.2015 18:27, Petr Vobornik wrote: On 10/30/2015 09:31 AM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5144 Patch attached. configure.jar is basically a signed zip which contains preferences.html therefore also all references to preferences.html should be

Re: [Freeipa-devel] [PATCH 0332] fix user post_callback

2015-11-12 Thread Martin Basti
On 21.10.2015 11:14, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5387 Patch attached. Fix for this ticket has been implemented in patch mbasti-0331-2 Attached patch contains only common postcallback code to from user and stageuser to parent class. From

Re: [Freeipa-devel] ipa-4-2 branch is broken !!!

2015-11-12 Thread Martin Basti
On 12.11.2015 11:00, Milan Kubík wrote: On 11/12/2015 10:35 AM, Martin Basti wrote: Lint failed in current ipa-4-2 branch. === Errors were found during the static code check. If you are certain that any of the

Re: [Freeipa-devel] [PATCH 0063] ipa-replica-manage del continues when host does not exist in domain level 1

2015-11-12 Thread Gabe Alford
Yeah. That's better. Thanks, Martin. Ack. On Thu, Nov 12, 2015 at 6:02 AM, Martin Basti wrote: > > > On 09.11.2015 14:37, Gabe Alford wrote: > > Hello, > > Fix for https://fedorahosted.org/freeipa/ticket/5424 > > thanks, > > Gabe > > > Thank you for you patch, almost ACK,

Re: [Freeipa-devel] [PATCH 0063] ipa-replica-manage del continues when host does not exist in domain level 1

2015-11-12 Thread Martin Basti
On 12.11.2015 14:32, Gabe Alford wrote: Yeah. That's better. Thanks, Martin. Ack. Pushed to master: efe8f26ddf81db471bbce693dacd35f80e7615e2 On Thu, Nov 12, 2015 at 6:02 AM, Martin Basti > wrote: On 09.11.2015 14:37, Gabe Alford wrote:

Re: [Freeipa-devel] [PATCH 0338] Drop configure.jar file

2015-11-12 Thread Martin Basti
On 12.11.2015 14:53, Petr Vobornik wrote: On 11/12/2015 12:27 PM, Martin Basti wrote: On 05.11.2015 18:27, Petr Vobornik wrote: On 10/30/2015 09:31 AM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5144 Patch attached. configure.jar is basically a signed zip which

Re: [Freeipa-devel] [PATCH 0338] Drop configure.jar file

2015-11-12 Thread Petr Vobornik
On 11/12/2015 12:27 PM, Martin Basti wrote: On 05.11.2015 18:27, Petr Vobornik wrote: On 10/30/2015 09:31 AM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5144 Patch attached. configure.jar is basically a signed zip which contains preferences.html therefore also all

Re: [Freeipa-devel] [PATCH 0093] perform connectivity checks for all topology suffixes during node deletion

2015-11-12 Thread Martin Babinsky
On 11/12/2015 02:04 PM, Petr Vobornik wrote: On 11/10/2015 05:43 PM, Martin Babinsky wrote: On 11/04/2015 06:50 PM, Petr Vobornik wrote: On 11/04/2015 01:30 PM, Martin Babinsky wrote: On 10/30/2015 05:06 PM, Martin Babinsky wrote: On 10/30/2015 03:38 PM, Petr Vobornik wrote: On 10/30/2015