[Freeipa-devel] [freeipa PR#237][comment] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/237 Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option mbasti-rh commented: """ So please re-triage it today, yesterday was only 4.5 milestone agreed """ See the full comment at

[Freeipa-devel] [freeipa PR#240][+ack] Document make_delete_command method in UserTracker

2016-11-15 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/240 Title: #240: Document make_delete_command method in UserTracker Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#237][reopened] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Author: pspacek Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option Action: reopened To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa

[Freeipa-devel] [freeipa PR#237][comment] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/237 Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option pspacek commented: """ Given the code change went to ipa-4-4 branch, I would merge it to ipa-4-4 as well. It does not make sense to keep it only in 4.5 and have

[Freeipa-devel] [freeipa PR#187][synchronized] Register entry points of Custodia plugins

2016-11-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/187 Author: tiran Title: #187: Register entry points of Custodia plugins Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/187/head:pr187 git checkout pr187 From

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/636aaa7dbc649e685233f382cb8dd424345bebd3

[Freeipa-devel] [freeipa PR#233][+pushed] Build phase 6: %install cleanup

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#233][closed] Build phase 6: %install cleanup

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/233/head:pr233 git checkout pr233 -- Manage your

[Freeipa-devel] [freeipa PR#229][comment] Remove the renewal lock file upon uninstall

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall mbasti-rh commented: """ Works for me on both domain levels, I'd ACK this if nobody is against """ See the full comment at

[Freeipa-devel] [freeipa PR#234][comment] Always use GSSAPI to set up initial replication

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/234 Title: #234: Always use GSSAPI to set up initial replication mbasti-rh commented: """ Works for me, but because to test this against IPA 3.x is not my destiny because "issues" I cannot add ACK yet """ See the full comment at

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup lslebodn commented: """ Thank you very much for removing problematic patch. Do not forget to remove it from "Build phase 8" :-) as well A) there are few conflicts => patch need to be rebased B) I do not

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn mbasti-rh commented: """ Works for me, I'll check code tomorrow """ See the full comment at https://github.com/freeipa/freeipa/pull/223#issuecomment-260710722 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#229][+ack] Remove the renewal lock file upon uninstall

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#241][synchronized] Port ipapython.dnssec.odsmgr to xml.etree

2016-11-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/241 Author: tiran Title: #241: Port ipapython.dnssec.odsmgr to xml.etree Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/241/head:pr241 git checkout pr241 From

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup mbasti-rh commented: """ @tiran do you agree with changes? """ See the full comment at https://github.com/freeipa/freeipa/pull/233#issuecomment-260666363 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-15 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn tomaskrizek commented: """ Bump for review. I forgot about this PR, it's a final change from the refactoring effort. """ See the full comment at

[Freeipa-devel] [freeipa PR#234][comment] Always use GSSAPI to set up initial replication

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/234 Title: #234: Always use GSSAPI to set up initial replication mbasti-rh commented: """ @martbab Working on it """ See the full comment at https://github.com/freeipa/freeipa/pull/234#issuecomment-260683430 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#234][comment] Always use GSSAPI to set up initial replication

2016-11-15 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/234 Title: #234: Always use GSSAPI to set up initial replication martbab commented: """ @mbasti-rh will you continue reviewing this PR or should I defer it to some other time? """ See the full comment at

[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system

2016-11-15 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system lslebodn commented: """ and also ``` Making install in po make[1]: Entering directory '/home/user/freeipa/po' make[1]: *** No rule to make target 'install'. Stop. make[1]:

[Freeipa-devel] [freeipa PR#180][comment] Make api.env.nss_dir relative to api.env.confdir

2016-11-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/180 Title: #180: Make api.env.nss_dir relative to api.env.confdir tiran commented: """ #143 has been merged. I made sure that consumers of hard-coded NSS directory will fail in the presence of ```IPA_CONFDIR```. """ See the full comment at

[Freeipa-devel] [freeipa PR#240][closed] Document make_delete_command method in UserTracker

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/240 Author: mirielka Title: #240: Document make_delete_command method in UserTracker Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/240/head:pr240 git checkout pr240

[Freeipa-devel] [freeipa PR#240][+pushed] Document make_delete_command method in UserTracker

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/240 Title: #240: Document make_delete_command method in UserTracker Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#240][comment] Document make_delete_command method in UserTracker

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/240 Title: #240: Document make_delete_command method in UserTracker mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4b3bd5424246d8386a33a73f9a98c6958823093e ipa-4-4:

[Freeipa-devel] [freeipa PR#236][synchronized] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Author: pspacek Title: #236: Build phase 7: cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/236/head:pr236 git checkout pr236 From

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ Rebased. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260769221 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ @lslebodn There is currently no plan to support distcheck: Python setuptools do not support VPATH builds as AFAIK it is impossible to do that without patching setuptools heavily. """

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ ACKing on behalf of Lukas. """ See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260776818 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#236][+ack] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#119][closed] [ipa-4-4] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/119 Author: mirielka Title: #119: [ipa-4-4] Tests: Providing trust tests with tree root domain Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/119/head:pr119 git

[Freeipa-devel] [freeipa PR#242][+ack] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/242 Title: #242: [master] Tests: Providing trust tests with tree root domain Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#215][comment] Add script to setup krb5 NFS exports

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/215 Title: #215: Add script to setup krb5 NFS exports pspacek commented: """ It sounds to me that it could be an useful plugin for ipa-advise tool. This is the tool which is supposed to given advies like 'install this and that' and so on. """ See

[Freeipa-devel] [freeipa PR#119][edited] [ipa-4-4] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/119 Author: mirielka Title: #119: [ipa-4-4] Tests: Providing trust tests with tree root domain Action: edited Changed field: title Original value: """ Tests: Providing trust tests with tree root domain """ -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#119][+pushed] [ipa-4-4] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/119 Title: #119: [ipa-4-4] Tests: Providing trust tests with tree root domain Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#242][opened] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/242 Author: mirielka Title: #242: [master] Tests: Providing trust tests with tree root domain Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6347 Note: This PR is rebased version of https://github.com/freeipa/freeipa/pull/119

[Freeipa-devel] [freeipa PR#242][+pushed] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/242 Title: #242: [master] Tests: Providing trust tests with tree root domain Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#242][comment] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/242 Title: #242: [master] Tests: Providing trust tests with tree root domain mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4df1d9d1a566af57b23d45ca4377ab77ed9e4d60 """ See the full comment at

[Freeipa-devel] [freeipa PR#241][synchronized] Port ipapython.dnssec.odsmgr to xml.etree

2016-11-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/241 Author: tiran Title: #241: Port ipapython.dnssec.odsmgr to xml.etree Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/241/head:pr241 git checkout pr241 From

[Freeipa-devel] [freeipa PR#197][comment] Make setup.py files PyPI compatible

2016-11-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/197 Title: #197: Make setup.py files PyPI compatible pvoborni commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/2dd66c6366454f9edd9b89861530e97c75b2d869 """ See the full comment at

[Freeipa-devel] [freeipa PR#197][+pushed] Make setup.py files PyPI compatible

2016-11-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/197 Title: #197: Make setup.py files PyPI compatible Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#197][closed] Make setup.py files PyPI compatible

2016-11-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/197 Author: tiran Title: #197: Make setup.py files PyPI compatible Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/197/head:pr197 git checkout pr197 -- Manage your

[Freeipa-devel] [freeipa PR#119][comment] [ipa-4-4] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/119 Title: #119: [ipa-4-4] Tests: Providing trust tests with tree root domain mbasti-rh commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/949e67692c427e0082ed32b729875b4fcffe631e """ See the full comment at

[Freeipa-devel] [freeipa PR#241][opened] Port ipapython.dnssec.odsmgr to xml.etree

2016-11-15 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/241 Author: tiran Title: #241: Port ipapython.dnssec.odsmgr to xml.etree Action: opened PR body: """ The module ipapython.dnssec.odsmgr is the only module in ipalib, ipaclient, ipapython and ipaplatform that uses lxml.etree.

[Freeipa-devel] [freeipa PR#241][comment] Port ipapython.dnssec.odsmgr to xml.etree

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/241 Title: #241: Port ipapython.dnssec.odsmgr to xml.etree mbasti-rh commented: """ I wrote some inline comments, I will test it later, DNSSEC is very hard to debug when an issue occurs, so review must be perfect. """ See the full comment at

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-15 Thread pspacek
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup pspacek commented: """ @lslebodn I've dropped the controversial patch which removes NULLs to allow you to send PR which adds it everywhere as you proposed. I'm going to wait till deadline at end of this

[Freeipa-devel] cannot edit freeipa.org wiki

2016-11-15 Thread Fraser Tweedale
Hi, I can no longer create or edit pages on the FreeIPA wiki. Could someone who administers the wiki help out? (Please follow up off-list.) Thanks, Fraser -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to