[Freeipa-devel] [DISCUSSION] checking *lint at configure time

2017-03-03 Thread Lukas Slebodnik
ehlo, This is a small continuation fo discussin from pull request "Make pylint and jsl optional" #502[1] Pylint and jslint are already optional because some downstream distributions does not have such packages. This is a reason why desing document[2] mention configuration options for disabling

[Freeipa-devel] [freeipa PR#537][synchronized] test_csrgen: adjusted comparison test scripts for CSRGenerator

2017-03-03 Thread Rezney
URL: https://github.com/freeipa/freeipa/pull/537 Author: Rezney Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/537/head:pr537

[Freeipa-devel] [freeipa PR#532][comment] Fix cookie with Max-Age processing

2017-03-03 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing apophys commented: """ Hi, can this PR get little more attention? The issue seems to be a cause for a lot of failures in our integration tests. (I'm not 100% sure though) """ See the full comment

Re: [Freeipa-devel] [DISCUSSION] checking *lint at configure time

2017-03-03 Thread Lukas Slebodnik
On (03/03/17 17:07), Lukas Slebodnik wrote: >ehlo, > >This is a small continuation fo discussin from pull request >"Make pylint and jsl optional" #502[1] > >Pylint and jslint are already optional because some downstream distributions >does not have such packages. This is a reason why desing

[Freeipa-devel] [freeipa PR#537][synchronized] test_csrgen: adjusted comparison test scripts for CSRGenerator

2017-03-03 Thread Rezney
URL: https://github.com/freeipa/freeipa/pull/537 Author: Rezney Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/537/head:pr537

[Freeipa-devel] [freeipa PR#537][+ack] test_csrgen: adjusted comparison test scripts for CSRGenerator

2017-03-03 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/537 Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#537][comment] test_csrgen: adjusted comparison test scripts for CSRGenerator

2017-03-03 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/537 Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator apophys commented: """ Ack. """ See the full comment at https://github.com/freeipa/freeipa/pull/537#issuecomment-284012793 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#537][comment] test_csrgen: adjusted comparison test scripts for CSRGenerator

2017-03-03 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/537 Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator apophys commented: """ Ack. """ See the full comment at https://github.com/freeipa/freeipa/pull/537#issuecomment-284012793 -- Manage your subscription for the

Re: [Freeipa-devel] [DISCUSSION] checking *lint at configure time

2017-03-03 Thread Rob Crittenden
Lukas Slebodnik wrote: > On (03/03/17 17:07), Lukas Slebodnik wrote: >> ehlo, >> >> This is a small continuation fo discussin from pull request >> "Make pylint and jsl optional" #502[1] >> >> Pylint and jslint are already optional because some downstream distributions >> does not have such

[Freeipa-devel] [freeipa PR#538][synchronized] Run test_ipaclient test suite

2017-03-03 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/538 Author: tiran Title: #538: Run test_ipaclient test suite Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/538/head:pr538 git checkout pr538 From

[Freeipa-devel] [freeipa PR#532][comment] Fix cookie with Max-Age processing

2017-03-03 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing simo5 commented: """ LGTM, please merge """ See the full comment at https://github.com/freeipa/freeipa/pull/532#issuecomment-284055799 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#532][+ack] Fix cookie with Max-Age processing

2017-03-03 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/532 Title: #532: Fix cookie with Max-Age processing Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#523][+pushed] cert-request: minor refactors

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/523 Title: #523: cert-request: minor refactors Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#502][+ack] Make pylint and jsl optional

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#400][comment] WebUI: Certificate Mapping

2017-03-03 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping flo-renaud commented: """ Hi @pvomacka thank you, LGTM. """ See the full comment at https://github.com/freeipa/freeipa/pull/400#issuecomment-283923415 -- Manage your subscription for the Freeipa-devel

[Freeipa-devel] [freeipa PR#523][+ack] cert-request: minor refactors

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/523 Title: #523: cert-request: minor refactors Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#523][closed] cert-request: minor refactors

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/523 Author: frasertweedale Title: #523: cert-request: minor refactors Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/523/head:pr523 git checkout pr523 -- Manage

[Freeipa-devel] [freeipa PR#523][comment] cert-request: minor refactors

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/523 Title: #523: cert-request: minor refactors tomaskrizek commented: """ master: * 2066a80be21258d9311ae374fe124d9ac3b79acd Remove redundant principal_type argument * 11c9df25774fbc8ed24b30f75c205d12ca3c5b90 Extract method to map principal to

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional tomaskrizek commented: """ Issues found by @HonzaCholasta were addressed and no one has raised any serious concern that this patch should not be accepted. """ See the full comment at

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional tomaskrizek commented: """ @tiran Needs rebase. """ See the full comment at https://github.com/freeipa/freeipa/pull/502#issuecomment-283931719 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#502][synchronized] Make pylint and jsl optional

2017-03-03 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/502 Author: tiran Title: #502: Make pylint and jsl optional Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/502/head:pr502 git checkout pr502 From

[Freeipa-devel] [freeipa PR#538][opened] Run test_ipaclient test suite

2017-03-03 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/538 Author: tiran Title: #538: Run test_ipaclient test suite Action: opened PR body: """ Depends on PR #537 to fix the test suite first. """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch

[Freeipa-devel] [freeipa PR#536][opened] ipa systemd unit should define Wants=network instead of Requires=network

2017-03-03 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/536 Author: flo-renaud Title: #536: ipa systemd unit should define Wants=network instead of Requires=network Action: opened PR body: """ The file ipa.service defines Requires=network.target which means that ipa stack will be restarted each

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-03 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional lslebodn commented: """ I am still expect some comment from @rcritten LS """ See the full comment at https://github.com/freeipa/freeipa/pull/502#issuecomment-283938711 -- Manage your subscription

[Freeipa-devel] [freeipa PR#507][comment] Use https to get security domain from Dogtag

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/507 Title: #507: Use https to get security domain from Dogtag tomaskrizek commented: """ master: * d1c5d92897d3e262edd2e43295c1270590aebd3d Use https to get security domain from Dogtag """ See the full comment at

[Freeipa-devel] [freeipa PR#507][+pushed] Use https to get security domain from Dogtag

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/507 Title: #507: Use https to get security domain from Dogtag Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#507][closed] Use https to get security domain from Dogtag

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/507 Author: tiran Title: #507: Use https to get security domain from Dogtag Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/507/head:pr507 git checkout pr507 --

[Freeipa-devel] [freeipa PR#516][comment] IdM Server: list all Employees with matching Smart Card

2017-03-03 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/516 Title: #516: IdM Server: list all Employees with matching Smart Card flo-renaud commented: """ @abbra , Thanks for your comment. Running in permissive mode I did not see any AVC logged in the journal. @HonzaCholasta thanks for the tips re.

[Freeipa-devel] [freeipa PR#502][-ack] Make pylint and jsl optional

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#507][+ack] Use https to get security domain from Dogtag

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/507 Title: #507: Use https to get security domain from Dogtag Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#507][comment] Use https to get security domain from Dogtag

2017-03-03 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/507 Title: #507: Use https to get security domain from Dogtag tomaskrizek commented: """ If backport for 4.4 is needed, please open another PR against `ipa-4-4`. Thanks. """ See the full comment at

[Freeipa-devel] [freeipa PR#538][synchronized] Run test_ipaclient test suite

2017-03-03 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/538 Author: tiran Title: #538: Run test_ipaclient test suite Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/538/head:pr538 git checkout pr538 From

[Freeipa-devel] [freeipa PR#519][comment] WebUI: add sizelimit:0 to cert-find

2017-03-03 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/519 Title: #519: WebUI: add sizelimit:0 to cert-find flo-renaud commented: """ Hi @pvomacka , thank you, the fix works as expected. """ See the full comment at https://github.com/freeipa/freeipa/pull/519#issuecomment-283949286 -- Manage your

[Freeipa-devel] [freeipa PR#519][+ack] WebUI: add sizelimit:0 to cert-find

2017-03-03 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/519 Title: #519: WebUI: add sizelimit:0 to cert-find Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#475][comment] Add options to run only ipaclient unittests

2017-03-03 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/475 Title: #475: Add options to run only ipaclient unittests martbab commented: """ I like the second approach better. If you squash the commits I will Ack the PR. I still think we need a substantial reorganization of the test suites but that needs